You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Fred Moyer <fr...@taperfriendlymusic.org> on 2008/02/03 21:29:34 UTC
Re: svn commit: r617965 -
/perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in
> Philip M. Gollucci wrote:
>> On Sun, 3 Feb 2008, gozer@apache.org wrote:
>>
>>> Author: gozer
>>> Date: Sun Feb 3 01:10:04 2008
>>> New Revision: 617965
>>>
>>> URL: http://svn.apache.org/viewvc?rev=617965&view=rev
>>> Log:
>>> Apache::Reload isn't part of the core anymore, so don't expect
>>> it to be available.
>> I thought this took a similiar root to Apache-SizeLimit and is pulled in
>> via and SVN external.
>
> Not sure if that's really planned for yet. It hasn't been done in
> any case, and it was unnecessary in the test suite.
Hadn't crossed my radar at all Can do if so desired.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r617965 -
/perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in
Posted by Fred Moyer <fr...@taperfriendlymusic.org>.
> Fred Moyer wrote:
>>> Philip M. Gollucci wrote:
>>>> On Sun, 3 Feb 2008, gozer@apache.org wrote:
>>>>
>>>>> Author: gozer
>>>>> Date: Sun Feb 3 01:10:04 2008
>>>>> New Revision: 617965
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=617965&view=rev
>>>>> Log:
>>>>> Apache::Reload isn't part of the core anymore, so don't expect
>>>>> it to be available.
>>>> I thought this took a similiar root to Apache-SizeLimit and is pulled
>>>> in
>>>> via and SVN external.
>>> Not sure if that's really planned for yet. It hasn't been done in
>>> any case, and it was unnecessary in the test suite.
>>
>> Hadn't crossed my radar at all Can do if so desired.
>
> +1
Where is Apache-SizeLimit specified in SVN external? I went through
README-SVN, and I'm only seeing Apache-Test and the docs in the external
propedit:
svn propedit svn:externals .
Apache-Test https://svn.apache.org/repos/asf/perl/Apache-Test/trunk
docs
https://svn.apache.org/repos/asf/perl/modperl/docs/trunk/src/docs/2.0
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r617965 -
/perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in
Posted by Fred Moyer <fr...@taperfriendlymusic.org>.
> Fred Moyer wrote:
>>>>>> in
>>>>>> via and SVN external.
>>>>> Not sure if that's really planned for yet. It hasn't been done in
>>>>> any case, and it was unnecessary in the test suite.
>>>> Hadn't crossed my radar at all Can do if so desired.
>>> +1
>>
>> So looks like 'svn propedit svn:externals .' needs to house this content
>> instead?
>>
>> Apache-Reload https://svn.apache.org/repos/asf/perl/Apache-Reload/trunk
>> Apache-SizeLimit
>> https://svn.apache.org/repos/asf/perl/Apache-SizeLimit/trunk
>
> Here, you might want to check with pgollucci, as I see there is still a
> lib/Apache/SizeLimit.pm in the mod_perl 2.x tree.
>
> I think this was partially reverted at some point, because of an impeding
> release or something like that.
>
> I think a few more things need to be checked after changing the
> svn:externals.
Yeah it looks like it. Sorry for moving ahead too fast, I thought we were
ok to update there based on previous emails. I'll deal with the
externals stuff after the release, I reverted back to the previous
version.
> - Making sure things correctly build from the top-level makefile
> - Making sure the tests run proprely nested, and failure status are
> correctly propagated (can look at ModPerl-Registry)
> - Making sure 'make dist' ends up packaging the right bits
> - Making sure the RELEASE documentation is updated, if it needs to be.
> - META.yml needs noindex exceptions for these, me thinks.
>
> Nothing too difficult, but quite a few places to get tripped up.
>
> Unless you have the time to get this sorted out quickly, I'd rather
> revert this until I can get the RCs out, then we can fiddle with
> this.
>
> --
> Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
> http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r617965 - /perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Fred Moyer wrote:
>> Fred Moyer wrote:
>>>> Philip M. Gollucci wrote:
>>>>> On Sun, 3 Feb 2008, gozer@apache.org wrote:
>>>>>
>>>>>> Author: gozer
>>>>>> Date: Sun Feb 3 01:10:04 2008
>>>>>> New Revision: 617965
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=617965&view=rev
>>>>>> Log:
>>>>>> Apache::Reload isn't part of the core anymore, so don't expect
>>>>>> it to be available.
>>>>> I thought this took a similiar root to Apache-SizeLimit and is pulled
>>>>> in
>>>>> via and SVN external.
>>>> Not sure if that's really planned for yet. It hasn't been done in
>>>> any case, and it was unnecessary in the test suite.
>>> Hadn't crossed my radar at all Can do if so desired.
>> +1
>
> So looks like 'svn propedit svn:externals .' needs to house this content
> instead?
>
> Apache-Reload https://svn.apache.org/repos/asf/perl/Apache-Reload/trunk
> Apache-SizeLimit https://svn.apache.org/repos/asf/perl/Apache-SizeLimit/trunk
Here, you might want to check with pgollucci, as I see there is still a
lib/Apache/SizeLimit.pm in the mod_perl 2.x tree.
I think this was partially reverted at some point, because of an impeding
release or something like that.
I think a few more things need to be checked after changing the svn:externals.
- Making sure things correctly build from the top-level makefile
- Making sure the tests run proprely nested, and failure status are
correctly propagated (can look at ModPerl-Registry)
- Making sure 'make dist' ends up packaging the right bits
- Making sure the RELEASE documentation is updated, if it needs to be.
- META.yml needs noindex exceptions for these, me thinks.
Nothing too difficult, but quite a few places to get tripped up.
Unless you have the time to get this sorted out quickly, I'd rather
revert this until I can get the RCs out, then we can fiddle with
this.
--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
Re: svn commit: r617965 -
/perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in
Posted by Fred Moyer <fr...@taperfriendlymusic.org>.
> Fred Moyer wrote:
>>> Philip M. Gollucci wrote:
>>>> On Sun, 3 Feb 2008, gozer@apache.org wrote:
>>>>
>>>>> Author: gozer
>>>>> Date: Sun Feb 3 01:10:04 2008
>>>>> New Revision: 617965
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=617965&view=rev
>>>>> Log:
>>>>> Apache::Reload isn't part of the core anymore, so don't expect
>>>>> it to be available.
>>>> I thought this took a similiar root to Apache-SizeLimit and is pulled
>>>> in
>>>> via and SVN external.
>>> Not sure if that's really planned for yet. It hasn't been done in
>>> any case, and it was unnecessary in the test suite.
>>
>> Hadn't crossed my radar at all Can do if so desired.
>
> +1
So looks like 'svn propedit svn:externals .' needs to house this content
instead?
Apache-Reload https://svn.apache.org/repos/asf/perl/Apache-Reload/trunk
Apache-SizeLimit https://svn.apache.org/repos/asf/perl/Apache-SizeLimit/trunk
Apache-Test https://svn.apache.org/repos/asf/perl/Apache-Test/trunk
docs
https://svn.apache.org/repos/asf/perl/modperl/docs/trunk/src/docs/2.0
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r617965 - /perl/modperl/trunk/ModPerl-Registry/t/conf/extra.conf.in
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Fred Moyer wrote:
>> Philip M. Gollucci wrote:
>>> On Sun, 3 Feb 2008, gozer@apache.org wrote:
>>>
>>>> Author: gozer
>>>> Date: Sun Feb 3 01:10:04 2008
>>>> New Revision: 617965
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=617965&view=rev
>>>> Log:
>>>> Apache::Reload isn't part of the core anymore, so don't expect
>>>> it to be available.
>>> I thought this took a similiar root to Apache-SizeLimit and is pulled in
>>> via and SVN external.
>> Not sure if that's really planned for yet. It hasn't been done in
>> any case, and it was unnecessary in the test suite.
>
> Hadn't crossed my radar at all Can do if so desired.
+1
--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/