You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2007/10/29 08:06:57 UTC
[jira] Created: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
[drlvm][jit][opt] improper opcode group lookup
----------------------------------------------
Key: HARMONY-5037
URL: https://issues.apache.org/jira/browse/HARMONY-5037
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Alexey Varlamov
Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HARMONY-5037) [drlvm][jit][opt] improper opcode group lookup
Posted by chunrong lai <ch...@gmail.com>.
I can also observe some failures introduced from the commit.
Benchmarks of specJVM fails in server or JET mode, in 32bits/64bits
platform.
Some GC helper can not be processed (if tunring on -XX:gc.prefetch=true)
now.
Should we just roll back the commit and commit a more clean one later?
Buqi, xiaoming, Alexey, others, do you have opinions?
On Mon, Oct 13, 2008 at 3:58 PM, Cheng, BuQi (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638963#action_12638963]
>
> Cheng, BuQi commented on HARMONY-5037:
> --------------------------------------
>
> Hi Alexey:
>
> Would you like to provide more information about the patch? The patch is
> too bigger to understand clearly.
>
> Thanks!
>
> Buqi
>
>
>
>
> > [drlvm][jit][opt] improper opcode group lookup
> > ----------------------------------------------
> >
> > Key: HARMONY-5037
> > URL: https://issues.apache.org/jira/browse/HARMONY-5037
> > Project: Harmony
> > Issue Type: Bug
> > Components: DRLVM
> > Reporter: Alexey Varlamov
> > Assignee: Alexey Varlamov
> > Fix For: 5.0M7
> >
> > Attachments: enc64.diff, enc_lookup.patch,
> HARMONY-5037-enc_lookup_gt3_May23.patch
> >
> >
> > Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to
> create invalid instructions. See for example HARMONY-5022
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609815#action_12609815 ]
Alexey Varlamov commented on HARMONY-5037:
------------------------------------------
Fixed spillgen issues at revision: 673297.
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Attachments: enc64.diff, enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgueni Brevnov updated HARMONY-5037:
-------------------------------------
Attachment: enc_lookup.patch
enc_lookup.patch entroduces the following changes:
1) Master encoder table was provided with extention information (signed/zero/none)
2) Base encoder lookup procedure was changed to match operand size and extention strictly.
3) Jitrino specific layer finds strict matching between operand but extends immediates taking into account allowed extention.
Next step should be fixing all use cases wich provides invalid operands.
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Attachments: enc_lookup.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-5037.
--------------------------------------
Resolution: Fixed
Fix Version/s: 5.0M7
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Fix For: 5.0M7
>
> Attachments: enc64.diff, enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Chunrong Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chunrong Lai reopened HARMONY-5037:
-----------------------------------
I see the big patch breaks mpegaudio and sunflow of specjvm2008.
So I re-open it.
Thanks.
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Fix For: 5.0M7
>
> Attachments: enc64.diff, enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-5037:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Attachments: enc_lookup.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608723#action_12608723 ]
Alexey Varlamov commented on HARMONY-5037:
------------------------------------------
OK, I've committed this big one at revision: 672239. Will file a separate bug against spillgen.
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Attachments: enc64.diff, enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "George Timoshenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Timoshenko updated HARMONY-5037:
---------------------------------------
Attachment: HARMONY-5037-enc_lookup_gt3_May23.patch
Current state:
JET and OPT runs eclipse startup
JET passes smoke.test, SPECjvm98, SPECjbb2005
OPT passes the most of smoke.test ( gc.LOS and io.Integers fail),
OPT fails on SPECjvm98, SPECjbb2005
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Attachments: enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov updated HARMONY-5037:
-------------------------------------
Attachment: enc64.diff
An updated patch: includes fixes for x86-64 platform.
George, I had to revert that workaround with Boolean size - in fact it is 8 bits in heap and AFAIU we have no other uses for this type.
Remained problem is with spillgen, it fails to handle some operands (assert(fails == 0); at vm\jitrino\src\codegenerator\ia32\Ia32SpillGen.cpp:669). Fortunately turning off global regalloc helps to bypass the issue and almost all tests and scenarios work.
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Attachments: enc64.diff, enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5037) [drlvm][jit][opt] improper opcode
group lookup
Posted by "Cheng, BuQi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638963#action_12638963 ]
Cheng, BuQi commented on HARMONY-5037:
--------------------------------------
Hi Alexey:
Would you like to provide more information about the patch? The patch is too bigger to understand clearly.
Thanks!
Buqi
> [drlvm][jit][opt] improper opcode group lookup
> ----------------------------------------------
>
> Key: HARMONY-5037
> URL: https://issues.apache.org/jira/browse/HARMONY-5037
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexey Varlamov
> Assignee: Alexey Varlamov
> Fix For: 5.0M7
>
> Attachments: enc64.diff, enc_lookup.patch, HARMONY-5037-enc_lookup_gt3_May23.patch
>
>
> Encoder of Jitrino.OPT improperly matches OpcodeGroups, allowing to create invalid instructions. See for example HARMONY-5022
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.