You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/01 20:30:42 UTC

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2789: imxrt: fixed CAN error while sending larger amount of data

acassis commented on a change in pull request #2789:
URL: https://github.com/apache/incubator-nuttx/pull/2789#discussion_r568119259



##########
File path: arch/arm/src/imxrt/imxrt_flexcan.c
##########
@@ -1183,6 +1198,27 @@ static uint32_t imxrt_waitmcr_change(uint32_t base, uint32_t mask,
   return false;
 }
 
+static uint32_t imxrt_waitesr2_change(uint32_t base, uint32_t mask,
+                                       uint32_t target_state)

Review comment:
       Hi @michallenc, since the "state" is bool shouldn't it be better if target_state also be bool ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org