You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/28 15:42:15 UTC
[GitHub] [submarine] FatalLin opened a new pull request #615: SUBMARINE-855. provid a handy submarine-server building script for veloping
FatalLin opened a new pull request #615:
URL: https://github.com/apache/submarine/pull/615
### What is this PR for?
Just like I mentioned in Jira story, it's common for operator members to fix the code of submarine-server when they hit some unexpected error in testing. Our current building tool compiles the whole project each time even they are only made some minor change, it really takes time and slow down the progress. I made a handy script aim to improve the developing progress in these kind of cases.
IMPORTANT: The developers have to make a whole project compiling once before using this script.
After we execute the script, it will enter the submarine-server directory and start to build the submarine-server module. The second step is moviong to submarin-dist directory to build the assembly tar ball, and call the build script to build image in step three. In the end, the script delete the submarine-server deployment in assigned namespace, and we expect the operator will launch another submarine-server deployment with the latest image.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-855
### How should this be tested?
usage: `./submarine-cloud-v2/hack/server-rapid-builder.sh <assigned-namespace>`
example: ` ./submarine-cloud-v2/hack/server-rapid-builder.sh submarine-user-test`
### Screenshots (if appropriate)
<img width="900" alt="ζͺε 2021-06-28 δΈε11 08 56" src="https://user-images.githubusercontent.com/5687317/123664932-63f3ff00-d86a-11eb-8b48-c1efaf7d2064.png">
### Questions:
* Do the license files need updating? Yes/No
* Are there breaking changes for older versions? Yes/No
* Does this need new documentation? Yes/No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #615: SUBMARINE-855. provide a handy submarine-server building script for developing
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #615:
URL: https://github.com/apache/submarine/pull/615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #615: SUBMARINE-855. provide a handy submarine-server building script for developing
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #615:
URL: https://github.com/apache/submarine/pull/615#discussion_r660759233
##########
File path: submarine-cloud-v2/hack/server-rapid-builder.sh
##########
@@ -0,0 +1,57 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Please make sure you've already built whole package once before executing this script!
+
+set -e
+
+
+if [ -L ${BASH_SOURCE-$0} ]; then
+ PWD=$(dirname $(readlink "${BASH_SOURCE-$0}"))
+else
+ PWD=$(dirname ${BASH_SOURCE-$0})
+fi
+
+export CURRENT_PATH=$(cd "${PWD}">/dev/null; pwd)
+export SUBMARINE_HOME=${CURRENT_PATH}/../..
+
+NAMESPACE=$1
+
+[[ ! -f mvnw ]] && mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.1
+eval $(minikube docker-env -u)
+
+if [ ! -d "${SUBMARINE_HOME}/submarine-dist/target" ]; then
+ mkdir "${SUBMARINE_HOME}/submarine-dist/target"
+fi
+
+# Build submarine-server module
+cd ${SUBMARINE_HOME}/submarine-server
+mvn clean package -DskipTests
+
+# Build assemble tar ball
+cd ${SUBMARINE_HOME}/submarine-dist
+mvn clean package -DskipTests
+
+[[ ! -f mvnw ]] && mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.1
Review comment:
This line can be removed because the maven wrapper has not been used in this script.
##########
File path: submarine-cloud-v2/hack/server-rapid-builder.sh
##########
@@ -0,0 +1,57 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Please make sure you've already built whole package once before executing this script!
+
+set -e
+
+
+if [ -L ${BASH_SOURCE-$0} ]; then
+ PWD=$(dirname $(readlink "${BASH_SOURCE-$0}"))
+else
+ PWD=$(dirname ${BASH_SOURCE-$0})
+fi
+
+export CURRENT_PATH=$(cd "${PWD}">/dev/null; pwd)
+export SUBMARINE_HOME=${CURRENT_PATH}/../..
+
+NAMESPACE=$1
+
+[[ ! -f mvnw ]] && mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.1
+eval $(minikube docker-env -u)
+
+if [ ! -d "${SUBMARINE_HOME}/submarine-dist/target" ]; then
+ mkdir "${SUBMARINE_HOME}/submarine-dist/target"
+fi
+
+# Build submarine-server module
+cd ${SUBMARINE_HOME}/submarine-server
+mvn clean package -DskipTests
+
+# Build assemble tar ball
+cd ${SUBMARINE_HOME}/submarine-dist
+mvn clean package -DskipTests
+
+[[ ! -f mvnw ]] && mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.1
+eval $(minikube docker-env -u)
Review comment:
To point your terminal to use the docker daemon inside minikube run this: `eval $(minikube docker-env)` rather than `eval $(minikube docker-env -u)`.
Reference:
(1) https://minikube.sigs.k8s.io/docs/handbook/pushing/
(2) https://minikube.sigs.k8s.io/docs/commands/docker-env/
##########
File path: submarine-cloud-v2/hack/server-rapid-builder.sh
##########
@@ -0,0 +1,57 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Please make sure you've already built whole package once before executing this script!
+
+set -e
+
+
+if [ -L ${BASH_SOURCE-$0} ]; then
+ PWD=$(dirname $(readlink "${BASH_SOURCE-$0}"))
+else
+ PWD=$(dirname ${BASH_SOURCE-$0})
+fi
+
+export CURRENT_PATH=$(cd "${PWD}">/dev/null; pwd)
+export SUBMARINE_HOME=${CURRENT_PATH}/../..
+
+NAMESPACE=$1
+
+[[ ! -f mvnw ]] && mvn -N io.takari:maven:0.7.7:wrapper -Dmaven=3.6.1
Review comment:
This line can be removed because the maven wrapper has not been used in this script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] FatalLin commented on pull request #615: SUBMARINE-855. provide a handy submarine-server building script for developing
Posted by GitBox <gi...@apache.org>.
FatalLin commented on pull request #615:
URL: https://github.com/apache/submarine/pull/615#issuecomment-873539894
@kevin85421 I just update the script to replace mvn with mvnw, also append some screenshots here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org