You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Thorsten Scherler (JIRA)" <ji...@apache.org> on 2008/07/31 14:38:32 UTC

[jira] Created: (FOR-1083) switch to Cocoon 2.1.x

switch to Cocoon 2.1.x
----------------------

                 Key: FOR-1083
                 URL: https://issues.apache.org/jira/browse/FOR-1083
             Project: Forrest
          Issue Type: Task
          Components: Compile, Core operations
            Reporter: Thorsten Scherler


it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-1083) switch to Cocoon 2.1.x

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624234#action_12624234 ] 

David Crossley commented on FOR-1083:
-------------------------------------

Discussion and testing moved to FOR-955

> switch to Cocoon 2.1.x
> ----------------------
>
>                 Key: FOR-1083
>                 URL: https://issues.apache.org/jira/browse/FOR-1083
>             Project: Forrest
>          Issue Type: Task
>          Components: Compile, Core operations
>            Reporter: Thorsten Scherler
>
> it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-1083) switch to Cocoon 2.1.x

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618658#action_12618658 ] 

Thorsten Scherler commented on FOR-1083:
----------------------------------------

I needed to tweak two classes:
Index: main/java/org/apache/forrest/util/IdGeneratorTransformer.java
===================================================================
--- main/java/org/apache/forrest/util/IdGeneratorTransformer.java	(revision 680993)
+++ main/java/org/apache/forrest/util/IdGeneratorTransformer.java	(working copy)
@@ -133,7 +133,7 @@
     }
 
     public void service(ServiceManager manager) throws ServiceException {
-        super.service(manager);
+        //super.service(manager);
         try {
             this.processor = (XPathProcessor)this.manager.lookup(XPathProcessor.ROLE);
         } catch (Exception e) {

Index: main/java/org/apache/forrest/util/XPathTransformer.java
===================================================================
--- main/java/org/apache/forrest/util/XPathTransformer.java	(revision 680993)
+++ main/java/org/apache/forrest/util/XPathTransformer.java	(working copy)
@@ -105,7 +105,7 @@
 
 
     public void service(ServiceManager manager) throws ServiceException {
-        super.service(manager);
+        //super.service(manager);
         try {
             this.processor = (XPathProcessor)this.manager.lookup(XPathProcessor.ROLE);
         } catch (Exception e) {


> switch to Cocoon 2.1.x
> ----------------------
>
>                 Key: FOR-1083
>                 URL: https://issues.apache.org/jira/browse/FOR-1083
>             Project: Forrest
>          Issue Type: Task
>          Components: Compile, Core operations
>            Reporter: Thorsten Scherler
>
> it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-1083) switch to Cocoon 2.1.x

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618656#action_12618656 ] 

Thorsten Scherler commented on FOR-1083:
----------------------------------------

I replaced all related libs:
?      lib/endorsed/xalan-2.7.1.jar
?      lib/endorsed/jakarta-regexp-1.5.jar
?      lib/endorsed/xml-apis-1.3.04.jar
?      lib/endorsed/xercesImpl-2.9.1.jar
!      lib/endorsed/jakarta-regexp-1.4.jar.license.txt
!      lib/endorsed/xalan-2.7.0.jar
!      lib/endorsed/xml-apis-1.3.03.jar
!      lib/endorsed/xercesImpl-2.8.0.jar
?      lib/core/excalibur-instrument-mgr-impl-2.1.jar
?      lib/core/cocoon-chaperon-block.jar
?      lib/core/cocoon-auth-block.jar
?      lib/core/cocoon-2.1.12-dev.jar
?      lib/core/excalibur-sourceresolve-2.2.3.jar
?      lib/core/excalibur-instrument-mgr-api-2.1.jar
?      lib/core/js-1.6R5.jar
?      lib/core/jdtcore-3.1.0.jar
?      lib/core/log4j-1.2.14.jar
?      lib/core/cocoon-template-block.jar
?      lib/core/commons-collections-3.2.jar
?      lib/core/cocoon-linkrewriter-block.jar
?      lib/core/cocoon-profiler-block.jar
?      lib/core/nekohtml-0.9.5.jar
?      lib/core/pizza-1.1.jar
?      lib/core/cocoon-validation-block.jar
?      lib/core/cocoon-batik-block.jar
?      lib/core/cocoon-html-block.jar
?      lib/core/excalibur-component-2.1.jar
?      lib/core/cocoon-lucene-block.jar
?      lib/core/cocoon-fop-block.jar
?      lib/core/cocoon-asciiart-block.jar
?      lib/core/javacImpl-0.9.jar
?      lib/core/ehcache-1.2.3.jar
?      lib/core/cocoon-xsp-block.jar
?      lib/core/javacApi-0.9.jar
?      lib/core/excalibur-instrument-mgr-http-2.1.jar
?      lib/core/commons-beanutils-core-1.7.0.jar
?      lib/core/commons-lang-2.4.jar
!      lib/core/cocoon-asciiart-block-2.2.0-dev.jar
!      lib/core/ehcache-1.2.jar
!      lib/core/cocoon-profiler-block-2.2.0-dev.jar
!      lib/core/cocoon-validation-block-2.2.0-dev.jar
!      lib/core/cocoon-batik-block-2.2.0-dev.jar
!      lib/core/cocoon-chaperon-block-2.2.0-dev.jar
!      lib/core/cocoon-html-block-2.2.0-dev.jar
!      lib/core/commons-collections-3.1.jar
!      lib/core/cocoon-fop-block-2.2.0-dev.jar
!      lib/core/cocoon-2.2.0-dev.jar
!      lib/core/cocoon-xsp-block-2.2.0-dev.jar
!      lib/core/cocoon-template-block-2.2.0-dev.jar
!      lib/core/cocoon-linkrewriter-block-2.2.0-dev.jar
!      lib/core/excalibur-sourceresolve-2.1.jar
!      lib/core/commons-lang-2.1.jar
!      lib/core/cocoon-lucene-block-2.2.0-dev.jar


> switch to Cocoon 2.1.x
> ----------------------
>
>                 Key: FOR-1083
>                 URL: https://issues.apache.org/jira/browse/FOR-1083
>             Project: Forrest
>          Issue Type: Task
>          Components: Compile, Core operations
>            Reporter: Thorsten Scherler
>
> it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x

Posted by Thorsten Scherler <th...@apache.org>.
On Thu, 2008-07-31 at 05:42 -0700, Thorsten Scherler (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618660#action_12618660 ] 
> 
> Thorsten Scherler commented on FOR-1083:
> ----------------------------------------
> 
> Neither mode is running:
> 
> Exception in thread "main" org.apache.avalon.framework.component.ComponentException: Could not find component (key [org.apache.cocoon.Processor])

Has somebody an idea?

Should I open a branch and commit what I have till now? It is not
running so far but ...?

salu2
> 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


[jira] Commented: (FOR-1083) switch to Cocoon 2.1.x

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618660#action_12618660 ] 

Thorsten Scherler commented on FOR-1083:
----------------------------------------

Neither mode is running:

Exception in thread "main" org.apache.avalon.framework.component.ComponentException: Could not find component (key [org.apache.cocoon.Processor])
	at org.apache.avalon.excalibur.component.ExcaliburComponentManager.lookup(ExcaliburComponentManager.java:245)
	at org.apache.cocoon.components.CocoonComponentManager.lookup(CocoonComponentManager.java:354)
	at org.apache.cocoon.Cocoon.initialize(Cocoon.java:348)
	at org.apache.avalon.framework.container.ContainerUtil.initialize(ContainerUtil.java:244)
	at org.apache.cocoon.bean.CocoonWrapper.initialize(CocoonWrapper.java:177)
	at org.apache.cocoon.bean.CocoonBean.initialize(CocoonBean.java:102)
	at org.apache.cocoon.Main.main(Main.java:320)
Caused by: org.apache.avalon.framework.configuration.ConfigurationException: Cannot resolve sitemap.xmap
	at org.apache.cocoon.components.treeprocessor.TreeProcessor.configure(TreeProcessor.java:204)
	at org.apache.avalon.framework.container.ContainerUtil.configure(ContainerUtil.java:201)
	at org.apache.avalon.excalibur.component.DefaultComponentFactory.newInstance(DefaultComponentFactory.java:289)
	at org.apache.avalon.excalibur.component.ThreadSafeComponentHandler.initialize(ThreadSafeComponentHandler.java:108)
	at org.apache.avalon.excalibur.component.ExcaliburComponentManager.lookup(ExcaliburComponentManager.java:236)
	... 6 more
Caused by: org.apache.excalibur.source.SourceException: Unable to select source factory for 'sitemap.xmap'. No default factory found.
	at org.apache.excalibur.source.impl.AbstractSourceResolver.resolveURI(AbstractSourceResolver.java:161)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.apache.avalon.excalibur.component.ComponentProxyGenerator$ComponentInvocationHandler.invoke(ComponentProxyGenerator.java:143)
	at $Proxy1.resolveURI(Unknown Source)
	at org.apache.cocoon.components.CocoonComponentManager.resolveURI(CocoonComponentManager.java:558)
	at org.apache.cocoon.components.CocoonComponentManager.resolveURI(CocoonComponentManager.java:541)
	at org.apache.cocoon.components.treeprocessor.TreeProcessor.configure(TreeProcessor.java:202)
	... 10 more
Java Result: 1


> switch to Cocoon 2.1.x
> ----------------------
>
>                 Key: FOR-1083
>                 URL: https://issues.apache.org/jira/browse/FOR-1083
>             Project: Forrest
>          Issue Type: Task
>          Components: Compile, Core operations
>            Reporter: Thorsten Scherler
>
> it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FOR-1083) switch to Cocoon 2.1.x

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Crossley closed FOR-1083.
-------------------------------

    Resolution: Fixed

Closing this duplicate of FOR-955

> switch to Cocoon 2.1.x
> ----------------------
>
>                 Key: FOR-1083
>                 URL: https://issues.apache.org/jira/browse/FOR-1083
>             Project: Forrest
>          Issue Type: Task
>          Components: Compile, Core operations
>            Reporter: Thorsten Scherler
>
> it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
I updated the licenses for the updated jars.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-08-21 at 14:49 +0200, Thorsten Scherler wrote:
...
> The third warning is from avalon
> http://excalibur.apache.org/apidocs/org/apache/avalon/framework/container/ContainerUtil.html#compose(java.lang.Object, org.apache.avalon.framework.component.ComponentManager)
> 
> Our code is the following:
> ContainerUtil.compose(context, new WrapperComponentManager(m_manager));
> ContainerUtil.service(context, m_manager);
> 
> and the above link states: "Deprecated. compose() is no longer the
> preferred method via which components will be supplied with Components.
> Please Use service() from Composable instead." So we may just delete the
> compose line as I understand it. However not sure about that.

I deleted the line and it works like before, maybe Ross knows some
unconsidered side effect.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-08-21 at 14:02 +0200, Thorsten Scherler wrote:
> On Thu, 2008-08-21 at 20:16 +1000, David Crossley wrote:
> > I am updating our $FORREST_HOME/etc/cocoon_upgrade stuff so
> > that we can easily repeat a build of the cocoon-2.1 jars.
> > That will also help me to get on with fixing our cocoon.xconf
> > 
> > Finished for tonight - will pick up again tomorrow.
> > 
> > By the way, do you get some deprecation warnings when doing
> 
> Yeah, have not come around to them yet.

Compiling 32 source files
to /home/thorsten/src/apache/forrest/trunk/build/classes
/home/thorsten/src/apache/forrest/trunk/main/java/org/apache/forrest/log/ForrestLogTargetFactory.java:22: warning: [deprecation] org.apache.cocoon.util.log.CocoonTargetFactory in org.apache.cocoon.util.log has been deprecated
import org.apache.cocoon.util.log.CocoonTargetFactory;
                                  ^
/home/thorsten/src/apache/forrest/trunk/main/java/org/apache/forrest/log/ForrestLogTargetFactory.java:30: warning: [deprecation] org.apache.cocoon.util.log.CocoonTargetFactory in org.apache.cocoon.util.log has been deprecated
    extends CocoonTargetFactory {
            ^
/home/thorsten/src/apache/forrest/trunk/main/java/org/apache/forrest/locationmap/lm/LocationMap.java:256: warning: [deprecation] compose(java.lang.Object,org.apache.avalon.framework.component.ComponentManager) in org.apache.avalon.framework.container.ContainerUtil has been deprecated
        ContainerUtil.compose(context, new
WrapperComponentManager(m_manager));
                     ^
3 warnings


The first two warning are because the CocoonTargetFactory is deprecated.
The comment states "This class will be removed in 2.2".

However we could use 
@SuppressWarnings("deprecation") for ForrestLogTargetFactory, this
however only is allowed in jdk 1.5 and higher. Or implement the methods
that offers cocoon in this class (it is pretty simple stuff).

The third warning is from avalon
http://excalibur.apache.org/apidocs/org/apache/avalon/framework/container/ContainerUtil.html#compose(java.lang.Object, org.apache.avalon.framework.component.ComponentManager)

Our code is the following:
ContainerUtil.compose(context, new WrapperComponentManager(m_manager));
ContainerUtil.service(context, m_manager);

and the above link states: "Deprecated. compose() is no longer the
preferred method via which components will be supplied with Components.
Please Use service() from Composable instead." So we may just delete the
compose line as I understand it. However not sure about that.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-08-21 at 20:16 +1000, David Crossley wrote:
> I am updating our $FORREST_HOME/etc/cocoon_upgrade stuff so
> that we can easily repeat a build of the cocoon-2.1 jars.
> That will also help me to get on with fixing our cocoon.xconf
> 
> Finished for tonight - will pick up again tomorrow.
> 
> By the way, do you get some deprecation warnings when doing

Yeah, have not come around to them yet.

salu2


> cd main
> ./build.sh clean
> ./build.sh
> 
> -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
I am updating our $FORREST_HOME/etc/cocoon_upgrade stuff so
that we can easily repeat a build of the cocoon-2.1 jars.
That will also help me to get on with fixing our cocoon.xconf

Finished for tonight - will pick up again tomorrow.

By the way, do you get some deprecation warnings when doing
cd main
./build.sh clean
./build.sh

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
I manually synchronised our cocoon.xconf with that generated
when we build Cocoon-2.1 configured for our blocks. 
I still have more to do. Also need to add configurable values.
Will get to that tomorrow.

In forrest trunk we have two config files, almost the same
but the one used in webapp mode has a different value for
"forrest.plugins" parameter. Need to find a way to handle that.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-08-21 at 17:16 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
...

> 
> > > It also uses the "Cocoon properties" system to set some values, e.g.
> > > <parameter name="freememory" value="${store-janitor.freememory}"/>
> > > In the Cocoon-2.1 SVN those values come from
> > > src/webapp/WEB-INF/properties/core.properties
> > > A while ago i added that ability to Forrest (FOR-917)
> > > so we should now be able to set up something similar.
> > 
> > I do not understand I can find
> > main/webapp/WEB-INF/properties/core.properties but there is no
> > store-janitor.freememory property in this file. 
> 
> No. See above. That property is in "Cocoon-2.1 SVN". Not ours yet.

Hmm, I used cocoon svn for the update, but I reckon we need to sync this
files.

> 
> > If I understand correctly we should move this property (and I guess
> > other as well)  to this properties file, right?
> 
> Leave it. There are many more to attend to and
> we need to preserve our existing settings too.
> As i said, i will do it.

ok
...
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley wrote:
> ...
> > I found the problem. It was the Cocoon configuration file.
> > 
> > In my working setup, i had kept our old configuration
> > by copying the content of our main/webapp/WEB-INF/xconf/forrest-core.xconf
> > into main/webapp/WEB-INF/cocoon.xconf (see FOR-955).
> > 
> > In your setup, i am not clear where you got the content from.
> > Perhaps it was direct from the Cocoon-2.1 cocoon.xconf file
> > or from its build/webapp/WEB-INF/cocoon.xconf which is produced
> > after processing block configurations.
> 
> Hmm, I thought that I did exactly this (copying the content from our
> forrest-core.xconf). 

Doing 'diff cocoon.xconf xconf/forrest-core.xconf' shows otherwise.

> > So it has some different parameters to ours, e.g.
> > the "catalog" parameter for "entity-resolver".
> > Hence the error described above.
> 
> Thanks very much to find the cause of the problem and fix it. 

Now you can remove your symbols-core-v10.ent copies.

> > It also uses the "Cocoon properties" system to set some values, e.g.
> > <parameter name="freememory" value="${store-janitor.freememory}"/>
> > In the Cocoon-2.1 SVN those values come from
> > src/webapp/WEB-INF/properties/core.properties
> > A while ago i added that ability to Forrest (FOR-917)
> > so we should now be able to set up something similar.
> 
> I do not understand I can find
> main/webapp/WEB-INF/properties/core.properties but there is no
> store-janitor.freememory property in this file. 

No. See above. That property is in "Cocoon-2.1 SVN". Not ours yet.

> If I understand correctly we should move this property (and I guess
> other as well)  to this properties file, right?

Leave it. There are many more to attend to and
we need to preserve our existing settings too.
As i said, i will do it.

> > I will work on this aspect of our upgrade.
> > It is a big task. We need to find some way to make
> > it easy to keep the configuration synchronised with
> > that at Cocoon-2.1 and its blocks config, each time
> > we upgrade our packaged Cocoon.
> 
> In lenya there is a cocoon as svn:external that are used every time you
> build.  There we are patching the default cocoon files like
> 
> <!-- Patch cocoon.xconf -->
>     <property name="patch.webapp" value="true"/>
>     <xpatch file="${build.webapp}/WEB-INF/cocoon.xconf"
>       srcdir="${build.patch}/cocoon-xconf" 
>       includes="prepare/*.xconf"
>       addComments="true"/>
>     <xpatch file="${build.webapp}/WEB-INF/cocoon.xconf"
>       srcdir="${build.patch}/cocoon-xconf" 
>       includes="**/*.xconf"
>       excludes="prepare/*.xconf"
>       addComments="false"/>
> 
> Something similar may work for us when we update. The best would be to
> use ant to do the update process for us.

Thanks. I will investigate.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-08-21 at 16:19 +1000, David Crossley wrote:
...
> I found the problem. It was the Cocoon configuration file.
> 
> In my working setup, i had kept our old configuration
> by copying the content of our main/webapp/WEB-INF/xconf/forrest-core.xconf
> into main/webapp/WEB-INF/cocoon.xconf (see FOR-955).
> 
> In your setup, i am not clear where you got the content from.
> Perhaps it was direct from the Cocoon-2.1 cocoon.xconf file
> or from its build/webapp/WEB-INF/cocoon.xconf which is produced
> after processing block configurations.

Hmm, I thought that I did exactly this (copying the content from our
forrest-core.xconf). 

> 
> So it has some different parameters to ours, e.g.
> the "catalog" parameter for "entity-resolver".
> Hence the error described above.

Thanks very much to find the cause of the problem and fix it. 


> It also uses the "Cocoon properties" system to set some values, e.g.
> <parameter name="freememory" value="${store-janitor.freememory}"/>
> In the Cocoon-2.1 SVN those values come from
> src/webapp/WEB-INF/properties/core.properties
> A while ago i added that ability to Forrest (FOR-917)
> so we should now be able to set up something similar.
> 

I do not understand I can find
main/webapp/WEB-INF/properties/core.properties but there is no
store-janitor.freememory property in this file. 

If I understand correctly we should move this property (and I guess
other as well)  to this properties file, right?

> I will work on this aspect of our upgrade.
> It is a big task. We need to find some way to make
> it easy to keep the configuration synchronised with
> that at Cocoon-2.1 and its blocks config, each time
> we upgrade our packaged Cocoon.

In lenya there is a cocoon as svn:external that are used every time you
build.  There we are patching the default cocoon files like

<!-- Patch cocoon.xconf -->
    <property name="patch.webapp" value="true"/>
    <xpatch file="${build.webapp}/WEB-INF/cocoon.xconf"
      srcdir="${build.patch}/cocoon-xconf" 
      includes="prepare/*.xconf"
      addComments="true"/>
    <xpatch file="${build.webapp}/WEB-INF/cocoon.xconf"
      srcdir="${build.patch}/cocoon-xconf" 
      includes="**/*.xconf"
      excludes="prepare/*.xconf"
      addComments="false"/>

Something similar may work for us when we update. The best would be to
use ant to do the update process for us.

I will try to bring back forrest site since that is failing:
* [1/0]     [0/0]     1.203s 0b      linkmap.html
org.apache.cocoon.sitemap.PatternException: Cannot get variable
'plugin.xmap.output' in expression '{lm:plugin.xmap.output}'
	at
org.apache.cocoon.components.treeprocessor.variables.PreparedVariableResolver.processModule(PreparedVariableResolver.java:262)
	at
org.apache.cocoon.components.treeprocessor.variables.PreparedVariableResolver.resolve(PreparedVariableResolver.java:209)

in forrest run that is no problem.

salu2
> 
> -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Thorsten Scherler wrote:
> > David Crossley wrote:
> > > Thorsten Scherler wrote:
> > > > David Crossley wrote:
> > > > >
> > > > > I did not need to do anything with that project symbols ent file.
> > > > 
> > > > Hmm, I always get error because of the ent files (I tried as well with a
> > > > new seed).
> > 
> > Hmm, you have not tried the branch, or?
> 
> That is correct. I was reporting that mine was working.
> You got to commit all your stuff before i could. So i now
> need to svn up and follow on.
> 
> > If  you do you will see the
> > problem, but I reckon you will know right away how to fix it.
>  [ snip]
> > Actually the resolver issue may be caused by updating
> > excalibur-sourceresolve-2.2.3.jar but that needs fixing after all if we
> > want to be able to constantly update cocoon.
> 
> That is why i was progressively updating the jars,
> getting something that works with minimal changes.
> 
> I now reverted mine and did 'svn up'. With yours i
> now see the problem you describe.
> 
> It is a big issue. The first error can be worked around
> by copying that symbols-core-v10.ent to main/webapp
> However, after that the xml framework is busted and every
> occasion that a DTD needs resolving, it goes to apache.org
> and other websites, rather than local copies.
> 
> I will go back to what i had, and come forward to find
> which new jar caused it.

I found the problem. It was the Cocoon configuration file.

In my working setup, i had kept our old configuration
by copying the content of our main/webapp/WEB-INF/xconf/forrest-core.xconf
into main/webapp/WEB-INF/cocoon.xconf (see FOR-955).

In your setup, i am not clear where you got the content from.
Perhaps it was direct from the Cocoon-2.1 cocoon.xconf file
or from its build/webapp/WEB-INF/cocoon.xconf which is produced
after processing block configurations.

So it has some different parameters to ours, e.g.
the "catalog" parameter for "entity-resolver".
Hence the error described above.

It also uses the "Cocoon properties" system to set some values, e.g.
<parameter name="freememory" value="${store-janitor.freememory}"/>
In the Cocoon-2.1 SVN those values come from
src/webapp/WEB-INF/properties/core.properties
A while ago i added that ability to Forrest (FOR-917)
so we should now be able to set up something similar.

I will work on this aspect of our upgrade.
It is a big task. We need to find some way to make
it easy to keep the configuration synchronised with
that at Cocoon-2.1 and its blocks config, each time
we upgrade our packaged Cocoon.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley wrote:
> > Thorsten Scherler wrote:
> > > David Crossley wrote:
> > > >
> > > > I did not need to do anything with that project symbols ent file.
> > > 
> > > Hmm, I always get error because of the ent files (I tried as well with a
> > > new seed).
> 
> Hmm, you have not tried the branch, or?

That is correct. I was reporting that mine was working.
You got to commit all your stuff before i could. So i now
need to svn up and follow on.

> If  you do you will see the
> problem, but I reckon you will know right away how to fix it.
 [ snip]
> Actually the resolver issue may be caused by updating
> excalibur-sourceresolve-2.2.3.jar but that needs fixing after all if we
> want to be able to constantly update cocoon.

That is why i was progressively updating the jars,
getting something that works with minimal changes.

I now reverted mine and did 'svn up'. With yours i
now see the problem you describe.

It is a big issue. The first error can be worked around
by copying that symbols-core-v10.ent to main/webapp
However, after that the xml framework is busted and every
occasion that a DTD needs resolving, it goes to apache.org
and other websites, rather than local copies.

I will go back to what i had, and come forward to find
which new jar caused it.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@apache.org>.
On Thu, 2008-08-21 at 01:01 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
> > David Crossley wrote:
> > > 
> > > I tried before going out to dinner ... Hooray it works.
> > > http://localhost:8888/ ... looks correct. Haven't yet tried plugins.
> > 
> > Thanks for trying.
> 
> As you can imagine, i was so happy when it presented.
> I hope that others are so excited and will help. ;-)

Yeah, we would need some testing, but as soon we have done some basic
testing we should directly release.

> 
> > > However i don't have time to commit.
> > > 
> > > But i see that you have now committed jars and stuff in r687295.
> > > This adds many more jars than i have.
> > 
> > If you can reduce them perfect.
> 
> Hmmm, i would rather know why you added so many.
> 
> I can understand those in "endorsed" but why the rest?

Well I updated the dependencies as well:

lib/core/commons-lang-2.4.jar -> was 2.1
lib/core/excalibur-sourceresolve-2.2.3.jar -> was 2.1.jar
lib/core/commons-collections-3.2.jar -> was 3.1

The rest I just removed after testing whether they are optional.

> 
...
> 
> > > I did not need to do anything with that project symbols ent file.
> > > Mine just works by doing:
> > > cd new-directory
> > > forrest seed
> > > forrest run
> > 
> > Hmm, I always get error because of the ent files (I tried as well with a
> > new seed).
> 
> I recall you mentioned this issue a while ago.
> I reckon that it is separate to our main stuff.
> Works for me.
> 

Hmm, you have not tried the branch, or? If  you do you will see the
problem, but I reckon you will know right away how to fix it.

>          -- oOo ---
> 
> I see that you have started describing other stuff
> against FOR-955 - fine. I will do some cross-references.

Actually the resolver issue may be caused by updating
excalibur-sourceresolve-2.2.3.jar but that needs fixing after all if we
want to be able to constantly update cocoon.

> 
> Now that Cocoon-2.1 is basically working for us, do you
> think that we should have separate Jira issues for skins mode 
> and dispatcher mode, or lump them all together?

Not sure, I need to do some more testing, but if you think we should split them that is fine with me either.

Cheers mate for the feedback.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley wrote:
> > 
> > I tried before going out to dinner ... Hooray it works.
> > http://localhost:8888/ ... looks correct. Haven't yet tried plugins.
> 
> Thanks for trying.

As you can imagine, i was so happy when it presented.
I hope that others are so excited and will help. ;-)

> > However i don't have time to commit.
> > 
> > But i see that you have now committed jars and stuff in r687295.
> > This adds many more jars than i have.
> 
> If you can reduce them perfect.

Hmmm, i would rather know why you added so many.

I can understand those in "endorsed" but why the rest?

> > I will get my list of jars when i get back home.
> 
> Perfect.

This is all that i needed:
?      lib/core/cocoon-chaperon-block.jar
?      lib/core/cocoon-2.1.12-dev.jar
?      lib/core/cocoon-template-block.jar
?      lib/core/cocoon-linkrewriter-block.jar
?      lib/core/cocoon-profiler-block.jar
?      lib/core/cocoon-batik-block.jar
?      lib/core/cocoon-validation-block.jar
?      lib/core/cocoon-html-block.jar
?      lib/core/cocoon-lucene-block.jar
?      lib/core/cocoon-fop-block.jar
?      lib/core/cocoon-asciiart-block.jar
?      lib/core/cocoon-xsp-block.jar
D      lib/core/cocoon-asciiart-block-2.2.0-dev.jar
D      lib/core/ehcache-1.2.jar
D      lib/core/excalibur-io-1.1.jar
D      lib/core/cocoon-profiler-block-2.2.0-dev.jar
D      lib/core/cocoon-validation-block-2.2.0-dev.jar
D      lib/core/cocoon-batik-block-2.2.0-dev.jar
D      lib/core/cocoon-chaperon-block-2.2.0-dev.jar
D      lib/core/cocoon-html-block-2.2.0-dev.jar
D      lib/core/commons-collections-3.1.jar
A  +   lib/core/commons-collections-3.2.jar
D      lib/core/cocoon-fop-block-2.2.0-dev.jar
A  +   lib/core/excalibur-component-2.1.jar
D      lib/core/cocoon-2.2.0-dev.jar
D      lib/core/cocoon-xsp-block-2.2.0-dev.jar
D      lib/core/cocoon-template-block-2.2.0-dev.jar
D      lib/core/cocoon-linkrewriter-block-2.2.0-dev.jar
A  +   lib/core/ehcache-1.2.3.jar
D      lib/core/cocoon-lucene-block-2.2.0-dev.jar

I would rather start with the minimum and build up.
Forrest is already way too bloated.

> > I did not need to do anything with that project symbols ent file.
> > Mine just works by doing:
> > cd new-directory
> > forrest seed
> > forrest run
> 
> Hmm, I always get error because of the ent files (I tried as well with a
> new seed).

I recall you mentioned this issue a while ago.
I reckon that it is separate to our main stuff.
Works for me.

         -- oOo ---

I see that you have started describing other stuff
against FOR-955 - fine. I will do some cross-references.

Now that Cocoon-2.1 is basically working for us, do you
think that we should have separate Jira issues for skins mode 
and dispatcher mode, or lump them all together?

Anyway, too late at night now. Hiccup.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Wed, 2008-08-20 at 19:20 +1000, David Crossley wrote:
> David Crossley wrote:
> > Thorsten Scherler wrote:
> > >
> > > Okay, but my setup is not working, that is why I think adding your
> > > installation makes more sense.
> > > 
> > > Anyway will create a branch now.
> > 
> > But mine is using a two-year old version of Cocoon-2.1
> > 
> > Okay, i will have a look at updating to the current Cocoon
> > later tonight.
> 
> I tried before going out to dinner ... Hooray it works.
> http://localhost:8888/ ... looks correct. Haven't yet tried plugins.

Thanks for trying.

> 
> However i don't have time to commit.
> 
> But i see that you have now committed jars and stuff in r687295.
> This adds many more jars than i have.

If you can reduce them perfect.

> 
> I will get my list of jars when i get back home.

Perfect.

> 
> I did not need to do anything with that project symbols ent file.
> Mine just works by doing:
> cd new-directory
> forrest seed
> forrest run
> 

Hmm, I always get error because of the ent files (I tried as well with a
new seed).

salu2

> -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Thorsten Scherler wrote:
> >
> > Okay, but my setup is not working, that is why I think adding your
> > installation makes more sense.
> > 
> > Anyway will create a branch now.
> 
> But mine is using a two-year old version of Cocoon-2.1
> 
> Okay, i will have a look at updating to the current Cocoon
> later tonight.

I tried before going out to dinner ... Hooray it works.
http://localhost:8888/ ... looks correct. Haven't yet tried plugins.

However i don't have time to commit.

But i see that you have now committed jars and stuff in r687295.
This adds many more jars than i have.

I will get my list of jars when i get back home.

I did not need to do anything with that project symbols ent file.
Mine just works by doing:
cd new-directory
forrest seed
forrest run

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley wrote:
> > Thorsten Scherler wrote:
> > > David Crossley wrote:
> > > >
> > > > Also i edited cocoon.xconf to set the "Cocoon version" etc.
> > > > That would probably explain your error.
> > > 
> > > -<cocoon version="2.2">
> > > +<cocoon version="2.1">
> > > 
> > > > See my notes on FOR-955.
> > > 
> > > I am now a step further ahead and see another error (after adding the
> > > webapp/WEB-INF/xconf/forrest-core.xconf directly into cocoon.xconf):
> > > /home/thorsten/src/apache/forrest/trunk/main/webapp/symbols-core-v10.ent
> > 
> > Are you using a new 'forrest seed' initiated using that new
> > FORREST_HOME etc. ?
> 
> I am testing directly in fresh-site.

Try with a 'forrest seed'.

> > > > > I will try to update our cocoon this week since I have some time this
> > > > > week for the task.
> > > > > 
> > > > > I wonder whether it would be a good idea to create a branch for it so it
> > > > > is easier to debug in team.
> > > > 
> > > > I agree that we should do a branch so that a few of us
> > > > can work on it. Didn't want to do that if it was just me,
> > > > because the branch might be too long-lived - two years
> > > > since my last attempt. Great to see renewed interest.
> > > 
> > > It would be good if you could add what you have into the branch this way
> > > I can have a look.
> > 
> > When you have created the branch and added your Cocoon and
> > other jar changes. I have a couple of hours remaining before
> > going out to dinner and will have a look when i return.
>  
> Okay, but my setup is not working, that is why I think adding your
> installation makes more sense.
> 
> Anyway will create a branch now.

But mine is using a two-year old version of Cocoon-2.1

Okay, i will have a look at updating to the current Cocoon
later tonight.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-08-21 at 16:37 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
> > 
> > https://svn.apache.org/repos/asf/forrest/branches/update_cocoon_2.1.12-dev
> 
> Don't forget that you have a pending patch to Dispatcher files
> as an attachment to FOR-955.

Yeah cheers, the part of the core I applied yesterday at home the rest
for the dispatcher needs more investigation. 

I opened a thread on cocoon-dev
http://marc.info/?t=121923623100002&r=1&w=2 and need to investigate a
hint from Andreas.

salu2

> 
> -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> 
> https://svn.apache.org/repos/asf/forrest/branches/update_cocoon_2.1.12-dev

Don't forget that you have a pending patch to Dispatcher files
as an attachment to FOR-955.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Wed, 2008-08-20 at 09:12 +0200, Thorsten Scherler wrote:
...
> 
> Anyway will create a branch now.

done 

https://svn.apache.org/repos/asf/forrest/branches/update_cocoon_2.1.12-dev

> 
> salu2
> 
> > 
> > -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Wed, 2008-08-20 at 17:04 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
> > David Crossley wrote:
> > > Thorsten Scherler wrote:
> > > > David Crossley (JIRA) wrote:
> > > > > 
> > > > > David Crossley commented on FOR-1083:
> > > > > -------------------------------------
> > > > > 
> > > > > Do the notes help that i made in FOR-955? It seems that i got further than you have.
> > > > 
> > > > Hmm, not sure whether it is because of the cocoon you used in 955, but
> > > > with my current setup I actually always getting:
> > > > Unable to select source factory for 'sitemap.xmap'. No default factory
> > > > found.
> > > 
> > > Yesterday i started another attempt with the current
> > > Cocoon-2.1 branch. My setup is not ready yet. Probably
> > > won't have time today - other stuff to attend to.
> > > 
> > > In my previous attempt, i changed the XPathTransformer and
> > > IdGeneratorTransformer differently to you.
> > 
> > You write there:
> > 
> > Revert main/java/org/apache/forrest/util/XPathTransformer.java r111200
> > Revert main/java/org/apache/forrest/util/IdGeneratorTransformer.java
> > r111200
> > 
> > Do you mean 
> > svn up -r111200 main/java/org/apache/forrest/util/
> > 
> > which results in 
> > D    main/java/org/apache/forrest/util
> 
> No. I looked at the changes in r111200 for those two files
> and manually changed those lines to what it was prior to r111200.

http://svn.apache.org/viewvc/forrest/trunk/main/java/org/apache/forrest/util/IdGeneratorTransformer.java?r1=56266&r2=111200&diff_format=h

Index: java/org/apache/forrest/util/XPathTransformer.java
===================================================================
--- java/org/apache/forrest/util/XPathTransformer.java	(revision 687263)
+++ java/org/apache/forrest/util/XPathTransformer.java	(working copy)
@@ -21,6 +21,7 @@
 import java.util.Map;
 import java.util.Stack;
 
+import org.apache.avalon.framework.component.ComponentManager;
 import org.apache.avalon.framework.parameters.Parameters;
 import org.apache.avalon.framework.service.ServiceManager;
 import org.apache.avalon.framework.service.ServiceException;
@@ -104,8 +105,8 @@
         }
 
 
-    public void service(ServiceManager manager) throws ServiceException
{
-        super.service(manager);
+    public void compose(ComponentManager manager) {
+      super.compose(manager);
         try {


> 
> > > Also i edited cocoon.xconf to set the "Cocoon version" etc.
> > > That would probably explain your error.
> > 
> > -<cocoon version="2.2">
> > +<cocoon version="2.1">
> > 
> > > See my notes on FOR-955.
> > 
> > I am now a step further ahead and see another error (after adding the
> > webapp/WEB-INF/xconf/forrest-core.xconf directly into cocoon.xconf):
> > /home/thorsten/src/apache/forrest/trunk/main/webapp/symbols-core-v10.ent
> 
> Are you using a new 'forrest seed' initiated using that new
> FORREST_HOME etc. ?

I am testing directly in fresh-site.

> 
> > > > I will try to update our cocoon this week since I have some time this
> > > > week for the task.
> > > > 
> > > > I wonder whether it would be a good idea to create a branch for it so it
> > > > is easier to debug in team.
> > > 
> > > I agree that we should do a branch so that a few of us
> > > can work on it. Didn't want to do that if it was just me,
> > > because the branch might be too long-lived - two years
> > > since my last attempt. Great to see renewed interest.
> > 
> > It would be good if you could add what you have into the branch this way
> > I can have a look.
> 
> When you have created the branch and added your Cocoon and
> other jar changes. I have a couple of hours remaining before
> going out to dinner and will have a look when i return.
 
Okay, but my setup is not working, that is why I think adding your
installation makes more sense.

Anyway will create a branch now.

salu2

> 
> -David
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley wrote:
> > Thorsten Scherler wrote:
> > > David Crossley (JIRA) wrote:
> > > > 
> > > > David Crossley commented on FOR-1083:
> > > > -------------------------------------
> > > > 
> > > > Do the notes help that i made in FOR-955? It seems that i got further than you have.
> > > 
> > > Hmm, not sure whether it is because of the cocoon you used in 955, but
> > > with my current setup I actually always getting:
> > > Unable to select source factory for 'sitemap.xmap'. No default factory
> > > found.
> > 
> > Yesterday i started another attempt with the current
> > Cocoon-2.1 branch. My setup is not ready yet. Probably
> > won't have time today - other stuff to attend to.
> > 
> > In my previous attempt, i changed the XPathTransformer and
> > IdGeneratorTransformer differently to you.
> 
> You write there:
> 
> Revert main/java/org/apache/forrest/util/XPathTransformer.java r111200
> Revert main/java/org/apache/forrest/util/IdGeneratorTransformer.java
> r111200
> 
> Do you mean 
> svn up -r111200 main/java/org/apache/forrest/util/
> 
> which results in 
> D    main/java/org/apache/forrest/util

No. I looked at the changes in r111200 for those two files
and manually changed those lines to what it was prior to r111200.

> > Also i edited cocoon.xconf to set the "Cocoon version" etc.
> > That would probably explain your error.
> 
> -<cocoon version="2.2">
> +<cocoon version="2.1">
> 
> > See my notes on FOR-955.
> 
> I am now a step further ahead and see another error (after adding the
> webapp/WEB-INF/xconf/forrest-core.xconf directly into cocoon.xconf):
> /home/thorsten/src/apache/forrest/trunk/main/webapp/symbols-core-v10.ent

Are you using a new 'forrest seed' initiated using that new
FORREST_HOME etc. ?

> > > I will try to update our cocoon this week since I have some time this
> > > week for the task.
> > > 
> > > I wonder whether it would be a good idea to create a branch for it so it
> > > is easier to debug in team.
> > 
> > I agree that we should do a branch so that a few of us
> > can work on it. Didn't want to do that if it was just me,
> > because the branch might be too long-lived - two years
> > since my last attempt. Great to see renewed interest.
> 
> It would be good if you could add what you have into the branch this way
> I can have a look.

When you have created the branch and added your Cocoon and
other jar changes. I have a couple of hours remaining before
going out to dinner and will have a look when i return.

-David

Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Wed, 2008-08-20 at 12:17 +1000, David Crossley wrote:
> Thorsten Scherler wrote:
> > David Crossley (JIRA) wrote:
> > > 
> > > David Crossley commented on FOR-1083:
> > > -------------------------------------
> > > 
> > > Do the notes help that i made in FOR-955? It seems that i got further than you have.
> > 
> > Hmm, not sure whether it is because of the cocoon you used in 955, but
> > with my current setup I actually always getting:
> > Unable to select source factory for 'sitemap.xmap'. No default factory
> > found.
> 
> Yesterday i started another attempt with the current
> Cocoon-2.1 branch. My setup is not ready yet. Probably
> won't have time today - other stuff to attend to.
> 
> In my previous attempt, i changed the XPathTransformer and
> IdGeneratorTransformer differently to you.

You write there:

Revert main/java/org/apache/forrest/util/XPathTransformer.java r111200
Revert main/java/org/apache/forrest/util/IdGeneratorTransformer.java
r111200

Do you mean 
svn up -r111200 main/java/org/apache/forrest/util/

which results in 
D    main/java/org/apache/forrest/util

> 
> Also i edited cocoon.xconf to set the "Cocoon version" etc.
> That would probably explain your error.

-<cocoon version="2.2">
+<cocoon version="2.1">

> 
> See my notes on FOR-955.

I am now a step further ahead and see another error (after adding the
webapp/WEB-INF/xconf/forrest-core.xconf directly into cocoon.xconf):
/home/thorsten/src/apache/forrest/trunk/main/webapp/symbols-core-v10.ent


> 
> > I will try to update our cocoon this week since I have some time this
> > week for the task.
> > 
> > I wonder whether it would be a good idea to create a branch for it so it
> > is easier to debug in team.
> 
> I agree that we should do a branch so that a few of us
> can work on it. Didn't want to do that if it was just me,
> because the branch might be too long-lived - two years
> since my last attempt. Great to see renewed interest.

It would be good if you could add what you have into the branch this way
I can have a look.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> David Crossley (JIRA) wrote:
> > 
> > David Crossley commented on FOR-1083:
> > -------------------------------------
> > 
> > Do the notes help that i made in FOR-955? It seems that i got further than you have.
> 
> Hmm, not sure whether it is because of the cocoon you used in 955, but
> with my current setup I actually always getting:
> Unable to select source factory for 'sitemap.xmap'. No default factory
> found.

Yesterday i started another attempt with the current
Cocoon-2.1 branch. My setup is not ready yet. Probably
won't have time today - other stuff to attend to.

In my previous attempt, i changed the XPathTransformer and
IdGeneratorTransformer differently to you.

Also i edited cocoon.xconf to set the "Cocoon version" etc.
That would probably explain your error.

See my notes on FOR-955.

> I will try to update our cocoon this week since I have some time this
> week for the task.
> 
> I wonder whether it would be a good idea to create a branch for it so it
> is easier to debug in team.

I agree that we should do a branch so that a few of us
can work on it. Didn't want to do that if it was just me,
because the branch might be too long-lived - two years
since my last attempt. Great to see renewed interest.

-David

Re: Open points for updating (was Re: Updating cocoon)

Posted by Ross Gardler <rg...@apache.org>.
David Crossley wrote:
> Thorsten Scherler wrote:
>> Hi devs,
>>
>> the update process is getting smoothly and there only some open points
>> left:

Great work Thorsten (and David).

I'll do some testing tomorrow and report back.

Ross

Re: Open points for updating (was Re: Updating cocoon)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> Hi devs,
> 
> the update process is getting smoothly and there only some open points
> left:
> 
> 1) Finish $FORREST_HOME/etc/cocoon_upgrade update and synchronization
> with the cocoon files -> David is mainly attending this

Yes. I am happy with the progress.

> 2) Decide about the depreciation issue while building forrest. Open is
> the ForrestLogTargetFactory the other one I could remove. -> we need to
> decide what we want to do (implement the functionality or live with the
> message). I doubt that this depreciation will be solved in cocoon but
> IMO that is the only place where it makes sense to solve it. Will write
> a mail to cocoon dev.

Adding the word "deprecation" to assist with searching mail archives ;-)

> 3) Issues with the CLI caused by AbstractCachingProcessingPipeline see
> http://marc.info/?t=121932134400001&r=1&w=2 -> I submitted a patch but
> would like to wait the feedback. For now I added the patched cocoon jar
> to our libs but we need to get the patch into cocoon. I will take care
> of this topic.
> 
> 4) Testing the branch and merge it after vote -> it would be nice if
> people can find time to test. The open issues will not influence the
> testing so you can start now if you can.

Item 4 should be just testing.

5) Proposal. Need to ensure that there is consensus
about doing the move. There are other possibilities.
A vote is not necessary, but it does help to draw
attention to it. I will get a Proposal email started.

-David

Re: Open points for updating (was Re: Updating cocoon)

Posted by David Crossley <cr...@apache.org>.
I added some notes about the upgrade to Apache Cocoon-2.1 version.

Please review r694614 which added upgrading notes to
upgrading_09.html#cocoon and an entry in the Changes list.
http://svn.apache.org/viewvc?view=rev&revision=694614
or type "694614" in Forrestbar and search "SVN Revision".

I trust that it casts this move in its positive light.
If not then please patch.

-David

Re: Open points for updating (was Re: Updating cocoon)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Mon, 2008-08-25 at 13:36 +0200, Thorsten Scherler wrote:
> On Fri, 2008-08-22 at 13:48 +0200, Thorsten Scherler wrote:
> > Hi devs,
> ...
> > 2) Decide about the depreciation issue while building forrest. Open is
> > the ForrestLogTargetFactory the other one I could remove. -> we need to
> > decide what we want to do (implement the functionality or live with the
> > message). I doubt that this depreciation will be solved in cocoon but
> > IMO that is the only place where it makes sense to solve it. Will write
> > a mail to cocoon dev.
> 
> I started a thread around this issue.
> http://marc.info/?l=xml-cocoon-dev&m=121966122007383&w=2 However I would
> like to know your opinion as well.

Till nobody comment on the issue neither here nor on cocoon. I do not
see it critical so I guess we will live with the message. 

> 
> > 
> > 3) Issues with the CLI caused by AbstractCachingProcessingPipeline see
> > http://marc.info/?t=121932134400001&r=1&w=2 -> I submitted a patch but
> > would like to wait the feedback. For now I added the patched cocoon jar
> > to our libs but we need to get the patch into cocoon. I will take care
> > of this topic.
> 
> I opened as well an issue around this issue: 
> https://issues.apache.org/jira/browse/COCOON-2241

I just committed the fix and closed the issue.

salu2

> salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Open points for updating (was Re: Updating cocoon)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Fri, 2008-08-22 at 13:48 +0200, Thorsten Scherler wrote:
> Hi devs,
...
> 2) Decide about the depreciation issue while building forrest. Open is
> the ForrestLogTargetFactory the other one I could remove. -> we need to
> decide what we want to do (implement the functionality or live with the
> message). I doubt that this depreciation will be solved in cocoon but
> IMO that is the only place where it makes sense to solve it. Will write
> a mail to cocoon dev.

I started a thread around this issue.
http://marc.info/?l=xml-cocoon-dev&m=121966122007383&w=2 However I would
like to know your opinion as well.

> 
> 3) Issues with the CLI caused by AbstractCachingProcessingPipeline see
> http://marc.info/?t=121932134400001&r=1&w=2 -> I submitted a patch but
> would like to wait the feedback. For now I added the patched cocoon jar
> to our libs but we need to get the patch into cocoon. I will take care
> of this topic.

I opened as well an issue around this issue: 
https://issues.apache.org/jira/browse/COCOON-2241

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: Open points for updating (was Re: Updating cocoon)

Posted by David Crossley <cr...@apache.org>.
I have done various tests on my Dispatcher-based golf site
which is listed on the Forrest examples page.

It uses the "gallery" plugin and also a "simple on-line store"
plugin.

We use the Forrestbot "scp" method to deploy this, in conjunction
with the "checksums" ability of Cocoon. That worked as expected,
deploying only the single changed document. That also proved
that the html output generated by this Cocoon-2.1 is identical
in layout and formatting to Forrest trunk. Nice.

-David

Re: Open points for updating (was Re: Updating cocoon)

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> 
> 1) Finish $FORREST_HOME/etc/cocoon_upgrade update and synchronization
> with the cocoon files -> David is mainly attending this

That has reached a suitable stage now.

The process described in $FORREST_HOME/etc/cocoon_upgrade
is now working with Cocoon-2.1 branch.

The main/webapp/WEB-INF/cocoon.xconf is synchronised with
that of Cocoon-2.1 branch. There is some more tweaking to do
and need some way to assist with its update. However, that
can happen later.

-David

Open points for updating (was Re: Updating cocoon)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
Hi devs,

the update process is getting smoothly and there only some open points
left:

1) Finish $FORREST_HOME/etc/cocoon_upgrade update and synchronization
with the cocoon files -> David is mainly attending this

2) Decide about the depreciation issue while building forrest. Open is
the ForrestLogTargetFactory the other one I could remove. -> we need to
decide what we want to do (implement the functionality or live with the
message). I doubt that this depreciation will be solved in cocoon but
IMO that is the only place where it makes sense to solve it. Will write
a mail to cocoon dev.

3) Issues with the CLI caused by AbstractCachingProcessingPipeline see
http://marc.info/?t=121932134400001&r=1&w=2 -> I submitted a patch but
would like to wait the feedback. For now I added the patched cocoon jar
to our libs but we need to get the patch into cocoon. I will take care
of this topic.

4) Testing the branch and merge it after vote -> it would be nice if
people can find time to test. The open issues will not influence the
testing so you can start now if you can.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Updating cocoon (was Re: [jira] Commented: (FOR-1083) switch to Cocoon 2.1.x)

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2008-07-31 at 18:44 -0700, David Crossley (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618917#action_12618917 ] 
> 
> David Crossley commented on FOR-1083:
> -------------------------------------
> 
> Do the notes help that i made in FOR-955? It seems that i got further than you have.

Hmm, not sure whether it is because of the cocoon you used in 955, but
with my current setup I actually always getting:
Unable to select source factory for 'sitemap.xmap'. No default factory
found.

I will try to update our cocoon this week since I have some time this
week for the task.

I wonder whether it would be a good idea to create a branch for it so it
is easier to debug in team.

salu2

> 
> > switch to Cocoon 2.1.x
> > ----------------------
> >
> >                 Key: FOR-1083
> >                 URL: https://issues.apache.org/jira/browse/FOR-1083
> >             Project: Forrest
> >          Issue Type: Task
> >          Components: Compile, Core operations
> >            Reporter: Thorsten Scherler
> >
> > it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.
> 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


[jira] Commented: (FOR-1083) switch to Cocoon 2.1.x

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618917#action_12618917 ] 

David Crossley commented on FOR-1083:
-------------------------------------

Do the notes help that i made in FOR-955? It seems that i got further than you have.

> switch to Cocoon 2.1.x
> ----------------------
>
>                 Key: FOR-1083
>                 URL: https://issues.apache.org/jira/browse/FOR-1083
>             Project: Forrest
>          Issue Type: Task
>          Components: Compile, Core operations
>            Reporter: Thorsten Scherler
>
> it would be blissful to get our internal Cocoon upgraded to at least use Cocoon-2.1 head.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.