You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2011/06/01 23:10:47 UTC

[jira] [Created] (BOOKKEEPER-23) Timeout requests

Timeout requests
----------------

                 Key: BOOKKEEPER-23
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
             Project: Bookkeeper
          Issue Type: Improvement
            Reporter: Flavio Junqueira


If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-23) Timeout requests

Posted by "Sijie Guo (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197729#comment-13197729 ] 

Sijie Guo commented on BOOKKEEPER-23:
-------------------------------------

+1
                
> Timeout requests
> ----------------
>
>                 Key: BOOKKEEPER-23
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-23.diff
>
>
> If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-23) Timeout requests

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194944#comment-13194944 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-23:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3662/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.


This addresses bug BOOKKEEPER-23.
    https://issues.apache.org/jira/browse/BOOKKEEPER-23


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java cb3bb26 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java 5e1c964 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java 2a8df38 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 2fa79bb 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadTimeout.java PRE-CREATION 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 7403604 

Diff: https://reviews.apache.org/r/3662/diff


Testing
-------


Thanks,

Ivan


                
> Timeout requests
> ----------------
>
>                 Key: BOOKKEEPER-23
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-23.diff
>
>
> If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-23) Timeout requests

Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-23:
---------------------------------

    Attachment: BOOKKEEPER-23.diff
    
> Timeout requests
> ----------------
>
>                 Key: BOOKKEEPER-23
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-23.diff
>
>
> If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-23) Timeout requests

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197758#comment-13197758 ] 

Hudson commented on BOOKKEEPER-23:
----------------------------------

Integrated in bookkeeper-trunk #338 (See [https://builds.apache.org/job/bookkeeper-trunk/338/])
    BOOKKEEPER-23: Timeout requests (ivank)

ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadTimeout.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java

                
> Timeout requests
> ----------------
>
>                 Key: BOOKKEEPER-23
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-23.diff
>
>
> If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-23) Timeout requests

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196893#comment-13196893 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-23:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3662/#review4700
-----------------------------------------------------------


it looks good to me. thanks Ivan, this feature is very useful.

- Sijie


On 2012-01-27 17:39:58, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3662/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-27 17:39:58)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-23.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-23
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java cb3bb26 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java 5e1c964 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java 2a8df38 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 2fa79bb 
bq.    bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadTimeout.java PRE-CREATION 
bq.    bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 7403604 
bq.  
bq.  Diff: https://reviews.apache.org/r/3662/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Timeout requests
> ----------------
>
>                 Key: BOOKKEEPER-23
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-23
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-23.diff
>
>
> If a client remains connected to a bookie, requests do not timeout. This is an undesirable behavior if a bookie is up but not responding to a request for some reason, like it is slow or has not handled an exception appropriately and did not respond to the client. I propose to add a timeout mechanism.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira