You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/08/07 10:18:37 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1794: [CELEBORN-846][FOLLOWUP] Fix broken link cause by unknown RPC.
FMX opened a new pull request, #1794:
URL: https://github.com/apache/incubator-celeborn/pull/1794
### What changes were proposed in this pull request?
Keep ReleaseSlots RPC to make sure that 0.3 client can worker with 0.3.1-SNAPSHOT and 0.4.0-SNAPSHOT.
### Why are the changes needed?
Ditto.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
GA and cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1794: [CELEBORN-846][FOLLOWUP] Fix broken link cause by unknown RPC.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1794:
URL: https://github.com/apache/incubator-celeborn/pull/1794#issuecomment-1667602964
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1794?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1794](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1794?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (736a751) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/6ea1ee2ec424c1011eef80a5d74c54cc1464f471?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6ea1ee2) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1794 +/- ##
==========================================
- Coverage 46.60% 46.46% -0.13%
==========================================
Files 162 162
Lines 10079 10105 +26
Branches 928 930 +2
==========================================
- Hits 4696 4694 -2
- Misses 5073 5100 +27
- Partials 310 311 +1
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `1.61% <0.00%> (-0.06%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1794/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1794: [CELEBORN-846][FOLLOWUP] Fix broken link caused by unknown RPC.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1794:
URL: https://github.com/apache/incubator-celeborn/pull/1794#discussion_r1286630150
##########
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala:
##########
@@ -170,6 +170,16 @@ object ControlMessages extends Logging {
override var requestId: String = ZERO_UUID)
extends MasterRequestMessage
+ @Deprecated
Review Comment:
```suggestion
@deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1794: [CELEBORN-846][FOLLOWUP] Fix broken link caused by unknown RPC.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1794:
URL: https://github.com/apache/incubator-celeborn/pull/1794#discussion_r1286631207
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -25,7 +25,8 @@ enum MessageType {
REGISTER_SHUFFLE = 4;
REGISTER_SHUFFLE_RESPONSE = 5;
REQUEST_SLOTS = 6;
- // RELEASE_SLOTS = 7;
+ // keep it for compatible reason
Review Comment:
```suggestion
// keep it for compatible with 0.3 client, will remove in 0.5
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1794: [CELEBORN-846][FOLLOWUP] Fix broken link caused by unknown RPC.
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1794: [CELEBORN-846][FOLLOWUP] Fix broken link caused by unknown RPC.
URL: https://github.com/apache/incubator-celeborn/pull/1794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org