You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/14 18:20:56 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
dongjoon-hyun opened a new pull request #625:
URL: https://github.com/apache/orc/pull/625
### What changes were proposed in this pull request?
This PR aims to upgrade Zookeeper from 2.4.6 to 3.6.2.
### Why are the changes needed?
This upgrade is recommended by Zookeeper community.
- https://issues.apache.org/jira/browse/ZOOKEEPER-3779 (Zookeeper client 3.4.x fails to connect when using Java 14)
### How was this patch tested?
Pass the CIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #625:
URL: https://github.com/apache/orc/pull/625#issuecomment-760496727
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #625:
URL: https://github.com/apache/orc/pull/625#discussion_r557711238
##########
File path: java/pom.xml
##########
@@ -659,7 +659,11 @@
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>netty-handler</artifactId>
Review comment:
`Zookeeper` dependency changed. Previously, Zookeeper 3.4 depends on `io.netty:netty`. Now, Zookeeper 3.6 depends on these two. So, in order to cut `netty` dependency, we need to cut these new artifacts.
- https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper/3.6.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on a change in pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #625:
URL: https://github.com/apache/orc/pull/625#discussion_r557669385
##########
File path: java/pom.xml
##########
@@ -659,7 +659,11 @@
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>netty-handler</artifactId>
Review comment:
Just wondering what is the reason behind the exclusion change here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #625:
URL: https://github.com/apache/orc/pull/625#issuecomment-760389847
cc @pgaref
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #625:
URL: https://github.com/apache/orc/pull/625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #625:
URL: https://github.com/apache/orc/pull/625#discussion_r557711238
##########
File path: java/pom.xml
##########
@@ -659,7 +659,11 @@
<exclusions>
<exclusion>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
+ <artifactId>netty-handler</artifactId>
Review comment:
`Zookeeper` dependency changed. Previously, Zookeeper 3.4 depends on `io.netty:netty`. Now, Zookeeper 3.6 depends on these two.
- https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper/3.6.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #625: ORC-733: Upgrade Zookeeper to 3.6.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #625:
URL: https://github.com/apache/orc/pull/625#issuecomment-760496490
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org