You are viewing a plain text version of this content. The canonical link for it is here.
Posted to submarine-dev@hadoop.apache.org by li...@apache.org on 2019/10/25 09:00:57 UTC

[hadoop-submarine] branch master updated: SUBMARINE-260. Remove submarine.version properties define in pom.xml

This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hadoop-submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 9e1d1c0  SUBMARINE-260. Remove submarine.version properties define in pom.xml
9e1d1c0 is described below

commit 9e1d1c0cb0cbfc17a31533e3c36cec5673363186
Author: Xun Liu <li...@apache.org>
AuthorDate: Fri Oct 25 14:48:10 2019 +0800

    SUBMARINE-260. Remove submarine.version properties define in pom.xml
    
    ### What is this PR for?
    The submarine.version property is now defined in the pom.xml file. In fact, this property is duplicated with project.version.
    So need to delete.
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/SUBMARINE-260
    
    ### How should this be tested?
    * [CI Pass](https://travis-ci.org/liuxunorg/hadoop-submarine/builds/602666779)
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? Yes/No
    * Is there breaking changes for older versions? Yes/No
    * Does this needs documentation? Yes/No
    
    Author: Xun Liu <li...@apache.org>
    
    Closes #62 from liuxunorg/SUBMARINE-260 and squashes the following commits:
    
    722308d [Xun Liu] SUBMARINE-260. Remove submarine.version properties define in pom.xml
---
 pom.xml                                                    | 2 --
 submarine-client/pom.xml                                   | 4 ++--
 submarine-commons/commons-cluster/pom.xml                  | 2 +-
 submarine-workbench/interpreter/interpreter-engine/pom.xml | 4 ++--
 submarine-workbench/interpreter/python-interpreter/pom.xml | 2 +-
 submarine-workbench/workbench-server/pom.xml               | 2 +-
 6 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index 1ad57f4..7b8c8e2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -42,8 +42,6 @@
   </licenses>
 
   <properties>
-    <submarine.version>0.3.0-SNAPSHOT</submarine.version>
-
     <!-- language versions -->
     <java.version>1.8</java.version>
 
diff --git a/submarine-client/pom.xml b/submarine-client/pom.xml
index fb3fd40..11e0cc0 100644
--- a/submarine-client/pom.xml
+++ b/submarine-client/pom.xml
@@ -36,7 +36,7 @@
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>commons-runtime</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
     </dependency>
     <dependency>
       <groupId>org.yaml</groupId>
@@ -59,7 +59,7 @@
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>commons-runtime</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
diff --git a/submarine-commons/commons-cluster/pom.xml b/submarine-commons/commons-cluster/pom.xml
index 1978a73..5b46ebe 100644
--- a/submarine-commons/commons-cluster/pom.xml
+++ b/submarine-commons/commons-cluster/pom.xml
@@ -34,7 +34,7 @@
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>commons-utils</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
     </dependency>
 
     <dependency>
diff --git a/submarine-workbench/interpreter/interpreter-engine/pom.xml b/submarine-workbench/interpreter/interpreter-engine/pom.xml
index 70344d7..45492e9 100644
--- a/submarine-workbench/interpreter/interpreter-engine/pom.xml
+++ b/submarine-workbench/interpreter/interpreter-engine/pom.xml
@@ -39,13 +39,13 @@
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>commons-utils</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
     </dependency>
 
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>commons-cluster</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
     </dependency>
 
     <dependency>
diff --git a/submarine-workbench/interpreter/python-interpreter/pom.xml b/submarine-workbench/interpreter/python-interpreter/pom.xml
index 0ba09a2..71b2c59 100644
--- a/submarine-workbench/interpreter/python-interpreter/pom.xml
+++ b/submarine-workbench/interpreter/python-interpreter/pom.xml
@@ -39,7 +39,7 @@
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>interpreter-engine</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
     </dependency>
     <dependency>
       <groupId>org.apache.zeppelin</groupId>
diff --git a/submarine-workbench/workbench-server/pom.xml b/submarine-workbench/workbench-server/pom.xml
index 264f25e..17dd20a 100644
--- a/submarine-workbench/workbench-server/pom.xml
+++ b/submarine-workbench/workbench-server/pom.xml
@@ -38,7 +38,7 @@
     <dependency>
       <groupId>org.apache.submarine</groupId>
       <artifactId>commons-cluster</artifactId>
-      <version>${submarine.version}</version>
+      <version>${project.version}</version>
     </dependency>
 
     <dependency>