You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/18 03:32:36 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request #2543: make prometheus bind addr can cofigure
Shoothzj opened a new pull request #2543:
URL: https://github.com/apache/bookkeeper/pull/2543
Descriptions of the changes in this PR:
make prometheus bind addr can cofigure
### Motivation
For security, make prometheus bind addr can config.
For compatibility, make default value is 0.0.0.0
### Changes
make prometheus bind addr can cofigure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2543: make prometheus bind addr can cofigure
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #2543:
URL: https://github.com/apache/bookkeeper/pull/2543#discussion_r559362456
##########
File path: bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
##########
@@ -63,6 +63,9 @@
public static final String PROMETHEUS_STATS_HTTP_ENABLE = "prometheusStatsHttpEnable";
public static final boolean DEFAULT_PROMETHEUS_STATS_HTTP_ENABLE = true;
+ public static final String PROMETHEUS_STATS_HTTP_ADDR = "prometheusStatsHttpAddr";
Review comment:
can we name this 'prometheusStatsHttpAddress' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on a change in pull request #2543: make prometheus bind addr can cofigure
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #2543:
URL: https://github.com/apache/bookkeeper/pull/2543#discussion_r559399261
##########
File path: bookkeeper-stats-providers/prometheus-metrics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
##########
@@ -63,6 +63,9 @@
public static final String PROMETHEUS_STATS_HTTP_ENABLE = "prometheusStatsHttpEnable";
public static final boolean DEFAULT_PROMETHEUS_STATS_HTTP_ENABLE = true;
+ public static final String PROMETHEUS_STATS_HTTP_ADDR = "prometheusStatsHttpAddr";
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2543: Allow to configure Prometheus HTTP Server bind address
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2543:
URL: https://github.com/apache/bookkeeper/pull/2543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org