You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2016/05/10 14:29:06 UTC

[GitHub] trafficserver pull request: TS4433: Did not consider NULL return f...

GitHub user oknet opened a pull request:

    https://github.com/apache/trafficserver/pull/626

    TS4433: Did not consider NULL return from TSVConnFdCreate

    example plugin: intercept
    Did not consider NULL return from TSVConnFdCreate only do a check on connect.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oknet/trafficserver patch-10

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #626
    
----
commit 93af01fa5d58266ce64c2e1fb57216bb06504cb9
Author: Oknet <xu...@gmail.com>
Date:   2016-05-10T14:20:32Z

    Did not consider NULL return from TSVConnFdCreate

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4433: Did not consider NULL return ...

Posted by jpeach <gi...@git.apache.org>.

Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/626#issuecomment-218517477
  
    Thanks @oknet. I split the error condition so we could log separate debug messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS4433: Did not consider NULL return f...

Posted by shinrich <gi...@git.apache.org>.

Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/626#issuecomment-218235455
  
    Looks reasonable to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS4433: Did not consider NULL return f...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/626


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---