[GitHub] [airflow] ashb commented on a change in pull request #17030: Check for missing DagRun rows for "downstream" tables before migrating DB

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #17030:
URL: https://github.com/apache/airflow/pull/17030#discussion_r703075530



##########
File path: airflow/utils/db.py
##########
@@ -706,17 +748,22 @@ def upgradedb(session=None):
     # alembic adds significant import time, so we import it lazily
     from alembic import command
 
-    log.info("Creating tables")
     config = _get_alembic_config()
 
     config.set_main_option('sqlalchemy.url', settings.SQL_ALCHEMY_CONN.replace('%', '%%'))
-    # check automatic migration is available
-    errs = auto_migrations_available()
-    if errs:
-        for err in errs:
-            log.error("Automatic migration is not available\n%s", err)
-        return
+
+    errors_seen = False
+    for err in _check_migration_errors():

Review comment:
       ```suggestion
       for err in _check_migration_errors(session=session):
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org