You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/01/16 18:23:38 UTC

[GitHub] mbeckerle commented on a change in pull request #26: Daffodil 1773 - ambiguous names rebase changes - extension of PR 23

mbeckerle commented on a change in pull request #26: Daffodil 1773 - ambiguous names rebase changes - extension of PR 23
URL: https://github.com/apache/incubator-daffodil/pull/26#discussion_r161843855
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/dsom/CompiledExpression1.scala
 ##########
 @@ -383,13 +392,61 @@ class DPathElementCompileInfo(
         matchesERD
       }
 
+    //
+    // We must indicate for all children having this path step as their name
 
 Review comment:
   Just fixing this to name it findNamedMatches and put the setting of the indicator var in a separate private method called at each place findNamedMatches is called.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services