[GitHub] [parquet-format] gszadovszky commented on pull request #165: PARQUET-675: Specify Interval LogicalType

[GitBox <gi...@apache.org>]

gszadovszky commented on pull request #165:
URL: https://github.com/apache/parquet-format/pull/165#issuecomment-766730709


   @nevi-me, based on the previous PR it will require some time to agree on it. Starting a discussion in the dev list might also help as a heads up. (I do not have the required experience on the SQL standard and the different engines to have an opinion.)
   
   About this PR. We will certainly need an update in LogicalTypes.md as well. `parquet-format` has the java code generation included with some additional unit tests so it should be covered automatically. The java code for production is generation inside `parquet-mr` after the `parquet-format` version reference is upgraded. Because of that we will need a `parquet-format` release first.
   Currently, I am not sure why the checks are failing. It seems to be a travis issue but I am not sure. You may try a close/re-open on this PR to re-trigger the travis build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org