You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Bill Havanki <bh...@clouderagovt.com> on 2013/12/16 21:22:22 UTC
Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-2030
https://issues.apache.org/jira/browse/ACCUMULO-2030
Repository: accumulo
Description
-------
Javadoc for o.a.a.core.security.
I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
Diffs
-----
core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
Diff: https://reviews.apache.org/r/16305/diff/
Testing
-------
mvn javadoc:javadoc returns no errors or warnings for these classes.
Thanks,
Bill Havanki
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/#review30536
-----------------------------------------------------------
Ship it!
core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java
<https://reviews.apache.org/r/16305/#comment58496>
Needs the doesn't-validate-UTF8 warning?
- Sean Busbey
On Dec. 17, 2013, 3:02 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16305/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 3:02 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2030
> https://issues.apache.org/jira/browse/ACCUMULO-2030
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Javadoc for o.a.a.core.security.
>
> I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
> core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
> core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
> core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
> core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
> core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
> core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
> core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
> core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
> core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
>
> Diff: https://reviews.apache.org/r/16305/diff/
>
>
> Testing
> -------
>
> mvn javadoc:javadoc returns no errors or warnings for these classes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/#review30537
-----------------------------------------------------------
Ship it!
Ship It!
- kturner
On Dec. 17, 2013, 3:02 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16305/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 3:02 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2030
> https://issues.apache.org/jira/browse/ACCUMULO-2030
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Javadoc for o.a.a.core.security.
>
> I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
> core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
> core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
> core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
> core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
> core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
> core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
> core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
> core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
> core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
>
> Diff: https://reviews.apache.org/r/16305/diff/
>
>
> Testing
> -------
>
> mvn javadoc:javadoc returns no errors or warnings for these classes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/
-----------------------------------------------------------
(Updated Dec. 17, 2013, 10:02 a.m.)
Review request for accumulo.
Changes
-------
Changes based on Sean's feedback.
Bugs: ACCUMULO-2030
https://issues.apache.org/jira/browse/ACCUMULO-2030
Repository: accumulo
Description
-------
Javadoc for o.a.a.core.security.
I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
Diffs (updated)
-----
core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
Diff: https://reviews.apache.org/r/16305/diff/
Testing
-------
mvn javadoc:javadoc returns no errors or warnings for these classes.
Thanks,
Bill Havanki
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Authorizations.java, lines 101-107
> > <https://reviews.apache.org/r/16305/diff/1/?file=398441#file398441line101>
> >
> > Does this (or any of the "already in UTF-8 bytes" methods) validate that the bytes are actually UTF-8? If not, I would include a warning.
It doesn't, and it apparently doesn't matter upon construction, which makes a warning a very good idea, as invalid strings could cause problems much later.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java, lines 435-439
> > <https://reviews.apache.org/r/16305/diff/1/?file=398442#file398442line435>
> >
> > I think you'd be in rights to fix all the within-javadocs whitespace errors, like this one.
Sure. I think this is one spot where there just happened not to be a whitespace error, within an existing Javadoc comment. I generally avoid futzing with those if I can, to reduce the changeset.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Authorizations.java, line 222
> > <https://reviews.apache.org/r/16305/diff/1/?file=398441#file398441line222>
> >
> > Can we get a TODO or a follow on Jira that this shouldn't be making a copy?
I'll file a follow-on JIRA.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java, line 26
> > <https://reviews.apache.org/r/16305/diff/1/?file=398444#file398444line26>
> >
> > Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language?
Existing comment, but I'll strengthen it.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java, line 27
> > <https://reviews.apache.org/r/16305/diff/1/?file=398445#file398445line27>
> >
> > Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language?
Existing comment, but I'll strengthen it.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/TablePermission.java, line 26
> > <https://reviews.apache.org/r/16305/diff/1/?file=398446#file398446line26>
> >
> > Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language?
Existing comment, but I'll strengthen it.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java, lines 27-29
> > <https://reviews.apache.org/r/16305/diff/1/?file=398444#file398444line27>
> >
> > Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
I haven't found docs, and I don't think I could write anything particularly elucidating. I will file a follow-on JIRA.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java, lines 28-30
> > <https://reviews.apache.org/r/16305/diff/1/?file=398445#file398445line28>
> >
> > Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
I haven't found docs, and I don't think I could write anything particularly elucidating. I will file a follow-on JIRA.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/TablePermission.java, lines 27-29
> > <https://reviews.apache.org/r/16305/diff/1/?file=398446#file398446line27>
> >
> > Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
I haven't found docs, and I don't think I could write anything particularly elucidating. I will file a follow-on JIRA.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/#review30513
-----------------------------------------------------------
On Dec. 16, 2013, 3:22 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16305/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 3:22 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2030
> https://issues.apache.org/jira/browse/ACCUMULO-2030
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Javadoc for o.a.a.core.security.
>
> I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
> core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
> core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
> core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
> core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
> core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
> core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
> core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
> core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
> core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
>
> Diff: https://reviews.apache.org/r/16305/diff/
>
>
> Testing
> -------
>
> mvn javadoc:javadoc returns no errors or warnings for these classes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/Authorizations.java, line 222
> > <https://reviews.apache.org/r/16305/diff/1/?file=398441#file398441line222>
> >
> > Can we get a TODO or a follow on Jira that this shouldn't be making a copy?
>
> Bill Havanki wrote:
> I'll file a follow-on JIRA.
ACCUMULO-2039
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java, lines 28-30
> > <https://reviews.apache.org/r/16305/diff/1/?file=398445#file398445line28>
> >
> > Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
>
> Bill Havanki wrote:
> I haven't found docs, and I don't think I could write anything particularly elucidating. I will file a follow-on JIRA.
ACCUMULO-2040
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/TablePermission.java, lines 27-29
> > <https://reviews.apache.org/r/16305/diff/1/?file=398446#file398446line27>
> >
> > Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
>
> Bill Havanki wrote:
> I haven't found docs, and I don't think I could write anything particularly elucidating. I will file a follow-on JIRA.
ACCUMULO-2040
> On Dec. 16, 2013, 9:06 p.m., Sean Busbey wrote:
> > core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java, lines 27-29
> > <https://reviews.apache.org/r/16305/diff/1/?file=398444#file398444line27>
> >
> > Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
>
> Bill Havanki wrote:
> I haven't found docs, and I don't think I could write anything particularly elucidating. I will file a follow-on JIRA.
ACCUMULO-2040
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/#review30513
-----------------------------------------------------------
On Dec. 17, 2013, 10:02 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16305/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 10:02 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2030
> https://issues.apache.org/jira/browse/ACCUMULO-2030
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Javadoc for o.a.a.core.security.
>
> I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
> core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
> core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
> core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
> core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
> core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
> core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
> core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
> core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
> core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
>
> Diff: https://reviews.apache.org/r/16305/diff/
>
>
> Testing
> -------
>
> mvn javadoc:javadoc returns no errors or warnings for these classes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/#review30513
-----------------------------------------------------------
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java
<https://reviews.apache.org/r/16305/#comment58426>
Does this (or any of the "already in UTF-8 bytes" methods) validate that the bytes are actually UTF-8? If not, I would include a warning.
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java
<https://reviews.apache.org/r/16305/#comment58423>
Can we get a TODO or a follow on Jira that this shouldn't be making a copy?
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java
<https://reviews.apache.org/r/16305/#comment58425>
I think you'd be in rights to fix all the within-javadocs whitespace errors, like this one.
core/src/main/java/org/apache/accumulo/core/security/Credentials.java
<https://reviews.apache.org/r/16305/#comment58427>
Consider something more informative. e.g.
@param principal A unique identifier for the entity (e.g. a user or service) authorized for these credentials.
core/src/main/java/org/apache/accumulo/core/security/Credentials.java
<https://reviews.apache.org/r/16305/#comment58428>
Consider something more informative. e.g.
Gets the unique identifier for the entity associated with these credentials. This could be e.g. a user name or system application.
core/src/main/java/org/apache/accumulo/core/security/Credentials.java
<https://reviews.apache.org/r/16305/#comment58429>
Consider something more informative. e.g.
Gets the authentication token used to prove that the principal for these credentials can been properly verified.
core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java
<https://reviews.apache.org/r/16305/#comment58430>
Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language?
core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java
<https://reviews.apache.org/r/16305/#comment58431>
Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java
<https://reviews.apache.org/r/16305/#comment58432>
Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language?
core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java
<https://reviews.apache.org/r/16305/#comment58433>
Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
core/src/main/java/org/apache/accumulo/core/security/TablePermission.java
<https://reviews.apache.org/r/16305/#comment58435>
Can we make this language stronger? maybe use RFC MAY, MUST, and MUST NOT language?
core/src/main/java/org/apache/accumulo/core/security/TablePermission.java
<https://reviews.apache.org/r/16305/#comment58434>
Can you add a brief description of the permissions, or are they documented somewhere else we can link to?
- Sean Busbey
On Dec. 16, 2013, 8:22 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16305/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 8:22 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2030
> https://issues.apache.org/jira/browse/ACCUMULO-2030
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Javadoc for o.a.a.core.security.
>
> I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
> core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
> core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
> core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
> core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
> core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
> core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
> core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
> core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
> core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
>
> Diff: https://reviews.apache.org/r/16305/diff/
>
>
> Testing
> -------
>
> mvn javadoc:javadoc returns no errors or warnings for these classes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16305: ACCUMULO-2030 - Javadoc for core/security
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16305/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 3:22 p.m.)
Review request for accumulo.
Bugs: ACCUMULO-2030
https://issues.apache.org/jira/browse/ACCUMULO-2030
Repository: accumulo
Description
-------
Javadoc for o.a.a.core.security.
I'll wait to submit the patch until a committer +1 or three business days inactivity, whichever happens first.
Diffs
-----
core/src/main/java/org/apache/accumulo/core/security/AuthorizationContainer.java 041bf3c
core/src/main/java/org/apache/accumulo/core/security/Authorizations.java 5cecefb
core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java bd16b84
core/src/main/java/org/apache/accumulo/core/security/Credentials.java 45708a8
core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java fb6847b
core/src/main/java/org/apache/accumulo/core/security/SystemPermission.java 6bdb8e6
core/src/main/java/org/apache/accumulo/core/security/TablePermission.java 912b5fb
core/src/main/java/org/apache/accumulo/core/security/VisibilityConstraint.java ae29cc7
core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 45b595f
core/src/main/java/org/apache/accumulo/core/security/VisibilityParseException.java 2f46dc9
Diff: https://reviews.apache.org/r/16305/diff/
Testing
-------
mvn javadoc:javadoc returns no errors or warnings for these classes.
Thanks,
Bill Havanki