You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Geode Integration (Jira)" <ji...@apache.org> on 2021/04/27 18:37:00 UTC
[jira] [Commented] (GEODE-7445) A public interface method should
not return an instance of an "internal" class
[ https://issues.apache.org/jira/browse/GEODE-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333464#comment-17333464 ]
Geode Integration commented on GEODE-7445:
------------------------------------------
Seen on support/1.14 in [DistributedTestOpenJDK11 #65|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-14-main/jobs/DistributedTestOpenJDK11/builds/65] ... see [test results|http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.0-build.0766/test-results/distributedTest/1619048260/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-support-1-14-main/1.14.0-build.0766/test-artifacts/1619048260/distributedtestfiles-OpenJDK11-1.14.0-build.0766.tgz].
> A public interface method should not return an instance of an "internal" class
> ------------------------------------------------------------------------------
>
> Key: GEODE-7445
> URL: https://issues.apache.org/jira/browse/GEODE-7445
> Project: Geode
> Issue Type: Bug
> Reporter: John Blum
> Assignee: Ernest Burghardt
> Priority: Minor
> Fix For: 1.12.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The {{org.apache.geode.cache.TransactionId}} class's {{getMemberId()}} method returns an instance of {{org.apache.geode.distriburted.internal.InternalDistributedMember}}.
> See here: https://geode.apache.org/releases/latest/javadoc/org/apache/geode/cache/TransactionId.html#getMemberId--
> If anything, the getMemberId methods should return and "ID" and not (even) a {{DistributedMember}}, but, if it must, then it should adhere to the "public" API by return an instance of [{{org.apache.geode.distributed.DistributedMember}}|https://geode.apache.org/releases/latest/javadoc/org/apache/geode/distributed/DistributedMember.html]!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)