[GitHub] [superset] betodealmeida commented on issue #14909: [SIP-68] A better model for Datasets

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #14909:
URL: https://github.com/apache/superset/issues/14909#issuecomment-958342866


   > @betodealmeida overall this LGTM. I have one question regarding the `Dataset.expression` attribute, wouldn't it be simpler to make it optional and thus would be `NULL` for datasets which represent physical database entities? Granted it makes your SQL substitution logic more complex but it could provide a cleaner mechanism of differentiating between physical and virtual datasets.
   
   @john-bodley I really like the symmetry of having just an expression for both virtual and physical datasets, since it simplifies building the SQL for a given dataset — though I agree it makes it harder for differentiating between them.
   
   What are your thoughts on having a boolean attribute, `is_physical`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org