You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/30 00:01:49 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #36718: [SPARK-39331][PYTHON][TESTS][SS] Check None for offsets in SourceProgress

HyukjinKwon opened a new pull request, #36718:
URL: https://github.com/apache/spark/pull/36718

   ### What changes were proposed in this pull request?
   
   This PR fixes the flaky test (https://github.com/apache/spark/runs/6643112037):
   
   ```
   Traceback (most recent call last):
     File "/__w/spark/spark/python/pyspark/sql/tests/test_streaming_listener.py", line 121, in test_listener_events
       self.check_progress_event(progress_event)
     File "/__w/spark/spark/python/pyspark/sql/tests/test_streaming_listener.py", line 140, in check_progress_event
       self.check_streaming_query_progress(event.progress)
     File "/__w/spark/spark/python/pyspark/sql/tests/test_streaming_listener.py", line 198, in check_streaming_query_progress
       self.check_source_progress(so)
     File "/__w/spark/spark/python/pyspark/sql/tests/test_streaming_listener.py", line 248, in check_source_progress
       self.assertTrue(isinstance(progress.startOffset, str))
   AssertionError: False is not true
   ```
   
   `startOffset`, `endOffset` and `latestOffset` can be `None`, and this PR changes the possible types in the tests.
   
   ### Why are the changes needed?
   
   To fix the flakiness.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   This PR fixes the test. We should monitor if it fixes the flakiness after it gets merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #36718: [SPARK-39331][PYTHON][TESTS][SS] Check None for offsets in SourceProgress

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36718:
URL: https://github.com/apache/spark/pull/36718#issuecomment-1140551293

   cc @HeartSaVioR mind taking a quick look please when you find some time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #36718: [SPARK-39331][PYTHON][TESTS][SS] Check None for offsets in SourceProgress

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36718:
URL: https://github.com/apache/spark/pull/36718#issuecomment-1140564237

   Thanks @dongjoon-hyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #36718: [SPARK-39331][PYTHON][TESTS][SS] Check None for offsets in SourceProgress

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36718: [SPARK-39331][PYTHON][TESTS][SS] Check None for offsets in SourceProgress
URL: https://github.com/apache/spark/pull/36718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #36718: [SPARK-39331][PYTHON][TESTS][SS] Check None for offsets in SourceProgress

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36718:
URL: https://github.com/apache/spark/pull/36718#issuecomment-1140615057

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org