[jira] [Commented] (STORM-330) storm.messaging.netty.max_retries option in config file not being used if > 30

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004988#comment-14004988 ] 

Robert Joseph Evans commented on STORM-330:
-------------------------------------------

I think this was an attempt to avoid an integer overflow issue that happens with shifting the bit too many times.  there is similar code to protect against this at 

https://github.com/apache/incubator-storm/blob/1a0b46e95ab4ac467525314a75819a75dec92c40/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L120-122

So the min can probably be removed.

> storm.messaging.netty.max_retries option in config file not being used if > 30
> ------------------------------------------------------------------------------
>
>                 Key: STORM-330
>                 URL: https://issues.apache.org/jira/browse/STORM-330
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.1-incubating
>            Reporter: Roland Jungnickel
>            Priority: Minor
>
> I have been trying to set the storm.messaging.netty.max_retries to 240 because of connection issues when one worker takes a longer time to start its processes. But due to this line https://github.com/apache/incubator-storm/blob/1a0b46e95ab4ac467525314a75819a75dec92c40/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L73 the max_retries is capped at 30. I am guessing this is a bug or at least should be noted somewhere in the documentation?



--
This message was sent by Atlassian JIRA
(v6.2#6252)