You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 04:27:22 UTC

[GitHub] [spark] sandeep-katta commented on a change in pull request #32284: [SPARK-35096][SQL][3.0] SchemaPruning should adhere spark.sql.caseSensitive config

sandeep-katta commented on a change in pull request #32284:
URL: https://github.com/apache/spark/pull/32284#discussion_r618070895



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SchemaPruning.scala
##########
@@ -28,6 +31,7 @@ object SchemaPruning {
   def pruneDataSchema(
       dataSchema: StructType,
       requestedRootFields: Seq[RootField]): StructType = {
+    val resolver = sqlConf.resolver

Review comment:
       This will always returns same resolver, it cannot be changed dynmanically




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org