You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/07/20 12:38:05 UTC
Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE
environment variable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Till Toenshoff.
Bugs: MESOS-7792
https://issues.apache.org/jira/browse/MESOS-7792
Repository: mesos
Description
-------
This adds the adequate documentation entry for the new
`LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
configuration of ECDHE key exchange while establishing TLS sessions.
Diffs
-----
docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
Diff: https://reviews.apache.org/r/60996/diff/1/
Testing
-------
non functional change.
Thanks,
Alexander Rojas
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181051
-----------------------------------------------------------
docs/ssl.md
Lines 78 (patched)
<https://reviews.apache.org/r/60996/#comment256487>
s/The valid values depends of OpenSSL version/Valid values depend on the OpenSSL version used/
- Till Toenshoff
On July 20, 2017, 12:38 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 12:38 p.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/1/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
> On July 26, 2017, 11:12 p.m., Greg Mann wrote:
> > docs/ssl.md
> > Lines 78-79 (patched)
> > <https://reviews.apache.org/r/60996/diff/2/?file=1780637#file1780637line78>
> >
> > Proposing a couple small tweaks for grammar/spelling:
> >
> > ```
> > List of elliptic curves which should be used for ECDHE-based cipher suites, in preferred order. Available values depend on the OpenSSL version used. Default value `auto` allows OpenSSL to pick the curve automatically.
> > OpenSSL versions prior to `1.0.2` allow for the use of only one curve; in those cases, `auto` defaults to `prime256v1`.
> > ```
Thanks Greg - much appreciated -- will fix while committing.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181502
-----------------------------------------------------------
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181502
-----------------------------------------------------------
docs/ssl.md
Lines 78-79 (patched)
<https://reviews.apache.org/r/60996/#comment257119>
Proposing a couple small tweaks for grammar/spelling:
```
List of elliptic curves which should be used for ECDHE-based cipher suites, in preferred order. Available values depend on the OpenSSL version used. Default value `auto` allows OpenSSL to pick the curve automatically.
OpenSSL versions prior to `1.0.2` allow for the use of only one curve; in those cases, `auto` defaults to `prime256v1`.
```
- Greg Mann
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181433
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181491
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181436
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60913, 60996]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 21, 2017, 2:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181517
-----------------------------------------------------------
docs/ssl.md
Lines 81 (patched)
<https://reviews.apache.org/r/60996/#comment257124>
Indeed - thanks!
- Till Toenshoff
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
> On July 26, 2017, 11:08 p.m., Gastón Kleiman wrote:
> > docs/ssl.md
> > Lines 81 (patched)
> > <https://reviews.apache.org/r/60996/diff/2/?file=1780637#file1780637line81>
> >
> > There was only one empty line before, do we need two?
True - thanks a bunch again :)
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181500
-----------------------------------------------------------
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
> On July 26, 2017, 11:08 p.m., Gastón Kleiman wrote:
> > docs/ssl.md
> > Lines 78 (patched)
> > <https://reviews.apache.org/r/60996/diff/2/?file=1780637#file1780637line78>
> >
> > s/Valid values depends on OpenSSL version used/Valid values depend on the OpenSSL version used./
Indeed - commented on that earlier but missed the remaining "depends" -- thanks!
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181500
-----------------------------------------------------------
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Till Toenshoff <to...@me.com>.
> On July 26, 2017, 11:08 p.m., Gastón Kleiman wrote:
> > Nit: AFAIK we try to write our commit messages in simple past.
The summary should be past tense, description present tense.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181500
-----------------------------------------------------------
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181500
-----------------------------------------------------------
Nit: AFAIK we try to write our commit messages in simple past.
docs/ssl.md
Lines 78 (patched)
<https://reviews.apache.org/r/60996/#comment257117>
s/Valid values depends on OpenSSL version used/Valid values depend on the OpenSSL version used./
docs/ssl.md
Lines 81 (patched)
<https://reviews.apache.org/r/60996/#comment257118>
There was only one empty line before, do we need two?
- Gastón Kleiman
On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 9:30 a.m.)
>
>
> Review request for mesos, Jie Yu and Till Toenshoff.
>
>
> Bugs: MESOS-7792
> https://issues.apache.org/jira/browse/MESOS-7792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
>
>
> Diffs
> -----
>
> docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
>
>
> Diff: https://reviews.apache.org/r/60996/diff/2/
>
>
> Testing
> -------
>
> non functional change.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 60996: Adds documentation for
LIBPROCESS_SSL_ECDH_CURVE environment variable.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/
-----------------------------------------------------------
(Updated July 21, 2017, 11:30 a.m.)
Review request for mesos, Jie Yu and Till Toenshoff.
Bugs: MESOS-7792
https://issues.apache.org/jira/browse/MESOS-7792
Repository: mesos
Description (updated)
-------
This adds the adequate documentation entry for the new
`LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
configuration of ECDHE key exchange while establishing TLS sessions.
Diffs (updated)
-----
docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd
Diff: https://reviews.apache.org/r/60996/diff/2/
Changes: https://reviews.apache.org/r/60996/diff/1-2/
Testing
-------
non functional change.
Thanks,
Alexander Rojas