You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adrian Crum <ad...@sandglass-software.com> on 2014/01/05 14:56:55 UTC
Re: svn commit: r1555506 - /ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js
It looks like you left some debugging code in this change.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/5/2014 8:54 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Sun Jan 5 13:54:39 2014
> New Revision: 1555506
>
> URL: http://svn.apache.org/r1555506
> Log:
> Adds a line between the license header and the getDependentDropdownValues() function documentation. My JS editor in Eclipse (Aptana) was hiding it all together with the license header
>
> Modified:
> ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js
>
> Modified: ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js?rev=1555506&r1=1555505&r2=1555506&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js (original)
> +++ ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js Sun Jan 5 13:54:39 2014
> @@ -16,6 +16,7 @@
> * specific language governing permissions and limitations
> * under the License.
> */
> +
> // *** getDependentDropdownValues allows to dynamically populate a dependent drop-down on change on its parent drop-down, doesn't require any fixed naming convention
> // request = request calling the service which retrieve the info from the DB, ex: getAssociatedStateList
> // paramKey = parameter value used in the called service
> @@ -30,9 +31,9 @@
> // hide = optional boolean argument, if true the dependent drop-down field (targetField) will be hidden when no options are available else only disabled. False by default.
> // hideTitle = optional boolean argument (hide must be set to true), if true the title of the dependent drop-down field (targetField) will be hidden when no options are available else only disabled. False by default.
> // inputField = optional name of an input field
> -// this is to handle a specific case where an input field is needed instead of a drop-down when no values are returned by the request
> -// this will be maybe extended later to use an auto-completed drop-down or a lookup, instead of straight drop-down currently, when there are too much values to populate
> -// this is e.g. currently used in the Product Price Rules screen
> +// this is to handle a specific case where an input field is needed instead of a drop-down when no values are returned by the request
> +// this will be maybe extended later to use an auto-completed drop-down or a lookup, instead of straight drop-down currently, when there are too much values to populate
> +// this is e.g. currently used in the Product Price Rules screen
> function getDependentDropdownValues(request, paramKey, paramField, targetField, responseName, keyName, descName, selected, callback, allowEmpty, hide, hideTitle, inputField){
> target = '#' + targetField;
> input = '#' + inputField;
> @@ -132,6 +133,7 @@ function getServiceResult(){
> data = result;
> }
> });
> + alert(data);
> return data;
> }
>
> @@ -188,4 +190,4 @@ function initTimeZone() {
> timezoneJS.timezone.zoneFileBasePath = '/images/date/timezones/min';
> timezoneJS.timezone.loadingSchemes.PRELOAD_ALL;
> timezoneJS.timezone.init();
> -}
> \ No newline at end of file
> +}
>
>
Re: svn commit: r1555506 -
/ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes, thanks spotted it few seconds after commit :)
Unfortunately adding this line is not enough for Aptana js editor to separate comments, well not a big deal...
Jacques
On Sunday, January 05, 2014 2:56 PM adrian.crum@sandglass-software.com wrote
> It looks like you left some debugging code in this change.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 1/5/2014 8:54 AM, jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Sun Jan 5 13:54:39 2014
>> New Revision: 1555506
>>
>> URL: http://svn.apache.org/r1555506
>> Log:
>> Adds a line between the license header and the getDependentDropdownValues() function documentation. My JS editor in Eclipse
>> (Aptana) was hiding it all together with the license header
>>
>> Modified:
>> ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js
>>
>> Modified: ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js?rev=1555506&r1=1555505&r2=1555506&view=diff
>> ============================================================================== ---
>> ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js (original) +++
>> ofbiz/trunk/framework/images/webapp/images/miscAjaxFunctions.js Sun Jan 5 13:54:39 2014 @@ -16,6 +16,7 @@
>> * specific language governing permissions and limitations
>> * under the License.
>> */
>> +
>> // *** getDependentDropdownValues allows to dynamically populate a dependent drop-down on change on its parent drop-down,
>> doesn't require any fixed naming convention // request = request calling the service which retrieve the info from the DB,
>> ex: getAssociatedStateList // paramKey = parameter value used in the called service
>> @@ -30,9 +31,9 @@
>> // hide = optional boolean argument, if true the dependent drop-down field (targetField) will be hidden when no
>> options are available else only disabled. False by default. // hideTitle = optional boolean argument (hide must be set to
>> true), if true the title of the dependent drop-down field (targetField) will be hidden when no options are available else only
>> disabled. False by default. // inputField = optional name of an input field
>> -// this is to handle a specific case where an input field is needed instead of a drop-down when no values are returned by the
>> request
>> -// this will be maybe extended later to use an auto-completed drop-down or a lookup, instead of straight drop-down currently,
>> when there are too much values to populate
>> -// this is e.g. currently used in the Product Price Rules screen
>> +// this is to handle a specific case where an input field is needed instead of a drop-down when no values are
>> returned by the request +// this will be maybe extended later to use an auto-completed drop-down or a lookup, instead
>> of straight drop-down currently, when there are too much values to populate +// this is e.g. currently used in the
>> Product Price Rules screen function getDependentDropdownValues(request, paramKey, paramField, targetField, responseName,
>> keyName, descName, selected, callback, allowEmpty, hide, hideTitle, inputField){ target = '#' + targetField;
>> input = '#' + inputField;
>> @@ -132,6 +133,7 @@ function getServiceResult(){
>> data = result;
>> }
>> });
>> + alert(data);
>> return data;
>> }
>>
>> @@ -188,4 +190,4 @@ function initTimeZone() {
>> timezoneJS.timezone.zoneFileBasePath = '/images/date/timezones/min';
>> timezoneJS.timezone.loadingSchemes.PRELOAD_ALL;
>> timezoneJS.timezone.init();
>> -}
>> \ No newline at end of file
>> +}