You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/05/19 07:34:54 UTC
[jira] Created: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Create timers to reload cassandra-rack.properties and datacenters.properties
----------------------------------------------------------------------------
Key: CASSANDRA-1105
URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
Project: Cassandra
Issue Type: Task
Components: Core
Reporter: Jonathan Ellis
Priority: Minor
Fix For: 0.7
PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1105:
----------------------------------
Attachment: CASSANDRA-1105-4.patch
Attaching quick patch. Changed
{noformat}
logger.error("{}", data, throwable);
{noformat}
to
{noformat}
logger.error(String.format("%s",data), throwable);
{noformat}
I don't think the first one does what it's supposed to do.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105-3.patch, CASSANDRA-1105-4.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869370#action_12869370 ]
Jonathan Ellis commented on CASSANDRA-1105:
-------------------------------------------
> Would it be better to reload based purely on modified time instead of a minute timer?
No. We want to avoid doing the reload check during any performance-critical code, and all the methods here that get called often enough to be useful for a check, are performance-critical.
> Do we need to change the interface or just leave the option to manual-reload?
Delete PFSMBean and the methods it defines.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871382#action_12871382 ]
Jon Hermes commented on CASSANDRA-1105:
---------------------------------------
Should getting the file handle from a resource name be done once at creation (file never expected to disappear, only change), or every time it checks for modification (file can go away and we should explode when it does)?
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869330#action_12869330 ]
Jon Hermes commented on CASSANDRA-1105:
---------------------------------------
Would it be better to reload based purely on modified time instead of a minute timer?
At the top of the getters, say if modified, reload()?
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871152#action_12871152 ]
Jonathan Ellis commented on CASSANDRA-1105:
-------------------------------------------
This is pretty good. I'd make one more change: instead of PropertyConfigurationTimerTask being tied to PropertyConfigurationLoadable, make it a more generic FileWatcher class that takes a Runnable to execute when changes are detected. (Then PCL isn't needed at all.)
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1105:
----------------------------------
Attachment: CASSANDRA-1105-2.patch
Status after second patch:
M src/java/org/apache/cassandra/locator/DatacenterShardStrategy.java
D src/java/org/apache/cassandra/locator/PropertyFileSnitchMBean.java
M src/java/org/apache/cassandra/locator/PropertyFileSnitch.java
A src/java/org/apache/cassandra/locator/util
A src/java/org/apache/cassandra/locator/util/PropertyConfigurationLoadable.java
A src/java/org/apache/cassandra/locator/util/PropertyConfigurationTimerTask.java
Added a util directory for locator.
PCLoadable is an interface for both PFS and DSS.
PCTimerTask covers both the extension of TimerTask and removes duplicate code.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872953#action_12872953 ]
Hudson commented on CASSANDRA-1105:
-----------------------------------
Integrated in Cassandra #448 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/448/])
Add ResourceWatcher to generalize reloading Strategy configurations. patch by Jon Hermes and jbellis for CASSANDRA-1105
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105-3.patch, CASSANDRA-1105-4.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869472#action_12869472 ]
Jon Hermes commented on CASSANDRA-1105:
---------------------------------------
Yeah, I should be able to do that by tomorrow.
The reloadConf calls can pass the X.properties name up to a bigger class, and it can pass back the real filename after it's done the lookup and checked modification for the non-common code to use.
Might be able to unduplicate the TimerTasks in the same way.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869117#action_12869117 ]
Jonathan Ellis commented on CASSANDRA-1105:
-------------------------------------------
I didn't see anything about setting configuration by api call there -- that doesn't sound like a direction we want to go.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869063#action_12869063 ]
Jeremy Hanna commented on CASSANDRA-1105:
-----------------------------------------
Might be related to what I'm trying to do with CASSANDRA-1066 - going to hopefully put the datacenters.properties configuration into an API call so that it can be set dynamically.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869393#action_12869393 ]
Jonathan Ellis commented on CASSANDRA-1105:
-------------------------------------------
Can you break out the check-for-file-changes-and-maybe-call-reload logic somehow so it's not duplicated in 2 places?
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1105:
----------------------------------
Attachment: CASSANDRA-1105-3.patch
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105-3.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869342#action_12869342 ]
Jon Hermes commented on CASSANDRA-1105:
---------------------------------------
Also, the manual-reload code is required by the interface PropertyFileSnitchMBean.
Do we need to change the interface or just leave the option to manual-reload?
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871414#action_12871414 ]
Jonathan Ellis commented on CASSANDRA-1105:
-------------------------------------------
A File object in Java is just a glorified String. You don't want to be opening it here, just checking the mtime.
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105-2.patch, CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1105) Create timers to reload
cassandra-rack.properties and datacenters.properties
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1105:
----------------------------------
Attachment: CASSANDRA-1105.patch
> Create timers to reload cassandra-rack.properties and datacenters.properties
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-1105
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1105
> Project: Cassandra
> Issue Type: Task
> Components: Core
> Affects Versions: 0.7
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7
>
> Attachments: CASSANDRA-1105.patch
>
>
> PropertyFileSnitch allows reloading changes from its config file manually. DatacenterShardStrategy doesn't allow reloading at all [after I ripped out the reload-for-each-getNaturalEndpoints call code, in CASSANDRA-1103].
> Let's check each of these for changes (modification time on the fs is sufficient) every minute and reload automatically if changes are seen. The manual-reload code from PFS can then be dropped.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.