You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2007/09/20 05:50:34 UTC
Simple bug in AliasKeyManager
in org.ofbiz.base.util.AliasKeyManager, chooseClientAlias has 2 nested
loops; the inner loop uses the index variable from the outer loop
correctly. Could someone please fix it? I've got a rather large set of
changes that make it hard for me to file a separate patch.
svk diff /job/ofbiz/ofbiz-svn|diffstat
...
160 files changed, 3144 insertions(+), 3378 deletions(-)
Re: Simple bug in AliasKeyManager
Posted by Al Byers <by...@automationgroups.com>.
ok, i just changed line 51 to:
if (this.alias.equals(aliases[x])) {
I did not even compile, so let me know if that was not the right change.
-Al
On 9/19/07, Al Byers <by...@automationgroups.com> wrote:
>
> I will take a look at it.
> -Al
>
> On 9/19/07, Tim Ruppert <ti...@hotwaxmedia.com> wrote:
> >
> > I just checked it out - at a simple glance it does look like a bug. I
> > don't have framework perms though so someone else will have to get it.
> >
> > Cheers,
> > Tim
> > --
> > Tim Ruppert
> > HotWax Media
> > http://www.hotwaxmedia.com
> >
> > o:801.649.6594
> > f:801.649.6595
> >
> >
> > On Sep 19, 2007, at 9:50 PM, Adam Heath wrote:
> >
> > in org.ofbiz.base.util.AliasKeyManager, chooseClientAlias has 2 nested
> > loops; the inner loop uses the index variable from the outer loop
> > correctly. Could someone please fix it? I've got a rather large set of
> > changes that make it hard for me to file a separate patch.
> >
> >
> > svk diff /job/ofbiz/ofbiz-svn|diffstat
> > ...
> > 160 files changed, 3144 insertions(+), 3378 deletions(-)
> >
> >
> >
> >
>
Re: Simple bug in AliasKeyManager
Posted by Al Byers <by...@automationgroups.com>.
I will take a look at it.
-Al
On 9/19/07, Tim Ruppert <ti...@hotwaxmedia.com> wrote:
>
> I just checked it out - at a simple glance it does look like a bug. I
> don't have framework perms though so someone else will have to get it.
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
>
> On Sep 19, 2007, at 9:50 PM, Adam Heath wrote:
>
> in org.ofbiz.base.util.AliasKeyManager, chooseClientAlias has 2 nested
> loops; the inner loop uses the index variable from the outer loop
> correctly. Could someone please fix it? I've got a rather large set of
> changes that make it hard for me to file a separate patch.
>
>
> svk diff /job/ofbiz/ofbiz-svn|diffstat
> ...
> 160 files changed, 3144 insertions(+), 3378 deletions(-)
>
>
>
>
Re: Simple bug in AliasKeyManager
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
I just checked it out - at a simple glance it does look like a bug.
I don't have framework perms though so someone else will have to get it.
Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Sep 19, 2007, at 9:50 PM, Adam Heath wrote:
> in org.ofbiz.base.util.AliasKeyManager, chooseClientAlias has 2 nested
> loops; the inner loop uses the index variable from the outer loop
> correctly. Could someone please fix it? I've got a rather large
> set of
> changes that make it hard for me to file a separate patch.
>
>
> svk diff /job/ofbiz/ofbiz-svn|diffstat
> ...
> 160 files changed, 3144 insertions(+), 3378 deletions(-)