[GitHub] [helix] kaisun2000 edited a comment on pull request #1637: Skip cancellation for partition reset pending message

[GitBox <gi...@apache.org>]

kaisun2000 edited a comment on pull request #1637:
URL: https://github.com/apache/helix/pull/1637#issuecomment-773691056


   > > Can I clarify about the root of the bug?
   > > The error msg is send by the participant itself, not the controller. controller only send cancellation upon seeing the Error message and send cancellation of this error in message generation phase?
   > 
   > It's described in the issue #1636
   > 
   > Helix ST cancellation is a feature that helix can cancel pending or ongoing partition assignment state transitions(ST) that are unnecessary due to some reasons, eg. pending state does not match the target state. The feature expects ST messages are only sent by helix controller so controller knows what kind of ST can be cancelled.
   > 
   > Root cause: When SN resets partition with ERROR -> OFFLINE ST, helix controller determines it is an unnecessary ST so it sends out cancellation, which is expected for helix ST cancellation feature.
   > 
   > This PR improves it by skipping cancelling the reset ST sent by Admin or participant.
   
   Do we have other messages similar to error message that can be set by admin tool/ participant, that can be cancelled by controller? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org