You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/12 21:27:10 UTC
[GitHub] [airflow] philipherrmann opened a new pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
philipherrmann opened a new pull request #20239:
URL: https://github.com/apache/airflow/pull/20239
Also:
- set min httpx version to 0.21.1 to match follow_redirects API
- fix weakness in _get_bool which prevented to explicitly set parameters to 'false' in extras
Trying to solve https://github.com/apache/airflow/issues/20088#issue-1072711201
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#discussion_r775873035
##########
File path: airflow/providers/google/cloud/hooks/cloud_sql.py
##########
@@ -769,7 +775,7 @@ def __init__(
@staticmethod
def _get_bool(val: Any) -> bool:
- if val == 'False':
+ if val == 'False' or val is False:
return False
return True
Review comment:
```suggestion
return val not in ("False", False)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1001639226
ANy chance to get it thsi way @philipherrmann ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] philipherrmann commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
philipherrmann commented on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1001747849
Sure. I can't oversee the consequences nearly as good, so I would just follow your suggestion. Sensing is a nice idea, but just try/except is more "pythonic" (EAFP), isn't it? I would go for that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20239:
URL: https://github.com/apache/airflow/pull/20239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1001761604
> Sure. I can't oversee the consequences nearly as good, so I would just follow your suggestion. Sensing is a nice idea, but just try/except is more "pythonic" (EAFP), isn't it? I would go for that later.
Both would work, I guess, but I think checking for attr is more explicit IMHO and better expresses the intent. Also same exception can be thrown if you happen to pass another parameter which is unexpected which might hide another error/typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-991973550
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1001761604
> Sure. I can't oversee the consequences nearly as good, so I would just follow your suggestion. Sensing is a nice idea, but just try/except is more "pythonic" (EAFP), isn't it? I would go for that later.
Both would work, I guess, but I think checking for attr is more explicit IMHO and better expresses the intent. Also same exception can be thrown if you happen to pass another argument which is unexpected which might hide another error/typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#discussion_r775873035
##########
File path: airflow/providers/google/cloud/hooks/cloud_sql.py
##########
@@ -769,7 +775,7 @@ def __init__(
@staticmethod
def _get_bool(val: Any) -> bool:
- if val == 'False':
+ if val == 'False' or val is False:
return False
return True
Review comment:
```suggestion
return val not in ("False", False)
```
##########
File path: airflow/providers/google/cloud/hooks/cloud_sql.py
##########
@@ -769,7 +775,7 @@ def __init__(
@staticmethod
def _get_bool(val: Any) -> bool:
- if val == 'False':
+ if val == 'False' or val is False:
return False
return True
Review comment:
```suggestion
return val not in ("False", False)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1002057531
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1002326641
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1001761604
> Sure. I can't oversee the consequences nearly as good, so I would just follow your suggestion. Sensing is a nice idea, but just try/except is more "pythonic" (EAFP), isn't it? I would go for that later.
Both would work, I guess, but I think checking for attr is more explicit IMHO and better expresses the intent. Also same exception can be thrown if you happen to pass another parameter which is unexpected which might hide another error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org