You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 22:19:53 UTC
[GitHub] [arrow] wolfeidau commented on a diff in pull request #13059: ARROW-16450: [Go][Docs] Include error handling in csv examples
wolfeidau commented on code in PR #13059:
URL: https://github.com/apache/arrow/pull/13059#discussion_r865430756
##########
go/arrow/csv/reader_test.go:
##########
@@ -61,6 +62,11 @@ func Example() {
n++
}
+ err := r.Err()
+ if err != nil {
+ log.Fatal(err)
+ }
Review Comment:
I have added a comment describing why we are checking the error.
##########
go/arrow/csv/writer_test.go:
##########
@@ -81,6 +81,11 @@ func Example_writer() {
n++
}
+ err = r.Err()
+ if err != nil {
+ log.Fatal(err)
+ }
Review Comment:
As above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org