You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2023/04/14 02:09:23 UTC
[GitHub] [arrow] zanmato1984 opened a new issue, #35124: [C++] Possibly an unnecessary copy when outputting join result batch
zanmato1984 opened a new issue, #35124:
URL: https://github.com/apache/arrow/issues/35124
### Describe the enhancement requested
See this line: https://github.com/apache/arrow/blob/913c34506000fd77444ea7b7f24dcb6402003d6b/cpp/src/arrow/acero/swiss_join_internal.h#L571
According the email discussion with @save-buffer :
> I _think_ the compiler will automatically emit the move because it sees we’re copying from an object that’ll never be used again [1], but adding the std::move would be good just to remove any ambiguity.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace closed issue #35124: [C++] Possibly an unnecessary copy when outputting join result batch
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace closed issue #35124: [C++] Possibly an unnecessary copy when outputting join result batch
URL: https://github.com/apache/arrow/issues/35124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org