You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/02/02 09:08:00 UTC
[jira] [Commented] (PHOENIX-5708) GlobalIndexChecker returns
unverified index row cells
[ https://issues.apache.org/jira/browse/PHOENIX-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028317#comment-17028317 ]
Hadoop QA commented on PHOENIX-5708:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12992436/PHOENIX-5708.master.001.patch
against master branch at commit b27168de1922d429229935b16eef49c00a88aab1.
ATTACHMENT ID: 12992436
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100:
+ // No need to run the same test twice one for async = true and the other for async = false
+ " (id varchar(10) not null primary key, val1 varchar(10), val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
+ conn.createStatement().execute("upsert into " + dataTableName + " values ('a', 'ab','abc', 'abcd')");
+ conn.createStatement().execute("upsert into " + dataTableName + " (id, val1, val2) values ('a', 'ab','abc')");
+ * An index row is composed of cells with the same timestamp. However, if there are multiple versions of an
+ * index row, HBase can return an index row with cells from multiple versions, and thus it can return cells
+ * with different timestamps. This happens if the version of the row we are reading does not have a value
+ * (i.e., effectively has null value) for a column whereas an older version has a value for the column.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3376//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3376//console
This message is automatically generated.
> GlobalIndexChecker returns unverified index row cells
> -----------------------------------------------------
>
> Key: PHOENIX-5708
> URL: https://issues.apache.org/jira/browse/PHOENIX-5708
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5708.master.001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the current implementation, unverified index row cells can be visible to clients. One scenario where this can happen is as follows. A client attempts to write a full data row but the data row write fails. This leaves an unverified index row corresponding to this data row. Later, the client attempts to write to the same row but this time it writes a partial data row such that one of the covered columns does not have a value in this partial write. After this, there will be two versions of the index row, the first one is unverified and the second one is verified. When the client reads the row back from the index table, since HBase will merge two versions of this index row, the client will get some cells from the unverified index row such that these cells are not in the verified index row. This is a bug. The fix is very simple. In GlobalIndexChecker, we need to remove the cells from the previous versions of the row. Please note that every index row is composed of cells with the same timestamp by design. By implementing this fix, we will ensure that this property always holds.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)