You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2005/10/05 04:17:47 UTC

[jira] Created: (FOR-702) Improve logging from Locationmap

Improve logging from Locationmap
--------------------------------

         Key: FOR-702
         URL: http://issues.apache.org/jira/browse/FOR-702
     Project: Forrest
        Type: Improvement
    Reporter: Ross Gardler
     Fix For: 0.8-dev


Debugging locationmaps is currently very difficult as no log information is provided.

We need the following debug log entries:

- for matches - record all entries encountered
- for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: tuning the logfiles (Was: (FOR-702))

Posted by David Crossley <cr...@apache.org>.
David Crossley wrote:
> Ross Gardler commented on FOR-702:
> > ----------------------------------
> > 
> > Right now the locatonmap logs are being duplicated in the
> > linkrewriter, the locationmap and the core logs. This is a
> > waste of resources, we need to make them appear in just
> > the locationmap log. I guess this is a logkit.xconf setting
> 
> Yes it is managed by logkit and easily changed.
> 
> However there is a reason for that duplication.
> 
> The locationmap.log provides only locationmap
> messages, so that they are easily to focus on.
> 
> Whereas core.log provides the full context.
> It is important to be able to see the requests
> that spawned the locationmap requests.
> 
> I don't agree that this duplication is a waste of resources.
> This only happens if the developer deliberately sets
> the level to be DEBUG in logkit.xconf
> 
> Set DEBUG on the core.log so that locationmap
> messages go there along with everything else.
> If you want to also see the locationmap messages
> separately, then also raise its log-level.

Sorry, i only answered part of the issue.

Why also duplicated in the linkrewriter log?

I don't know. These separate logs were added
when trying to debug the Linkrewriter issues
with the JXPath bug. I found these logs useful
so left them configured.

Now there must have been a reason for the
duplication. Probably the same reason as above:
"to provide context".

I just made a commit which commented that one out
as an example of how to gain more contextual info.

-David

tuning the logfiles (Was: (FOR-702))

Posted by David Crossley <cr...@apache.org>.
Ross Gardler commented on FOR-702:
> ----------------------------------
> 
> Right now the locatonmap logs are being duplicated in the
> linkrewriter, the locationmap and the core logs. This is a
> waste of resources, we need to make them appear in just
> the locationmap log. I guess this is a logkit.xconf setting

Yes it is managed by logkit and easily changed.

However there is a reason for that duplication.

The locationmap.log provides only locationmap
messages, so that they are easily to focus on.

Whereas core.log provides the full context.
It is important to be able to see the requests
that spawned the locationmap requests.

I don't agree that this duplication is a waste of resources.
This only happens if the developer deliberately sets
the level to be DEBUG in logkit.xconf

Set DEBUG on the core.log so that locationmap
messages go there along with everything else.
If you want to also see the locationmap messages
separately, then also raise its log-level.

-David

[jira] Commented: (FOR-702) Improve logging from Locationmap

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-702?page=comments#action_12359867 ] 

David Crossley commented on FOR-702:
------------------------------------

There used to be an issue that, if a match is not found, then no actual error is recorded - the request sort of silently falls out the end of the locationmap. Not sure if that can even be helped.

Also there is the related issue FOR-701 "Missing locationmap entry gives poor error"

> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>   Components: Locationmap
>     Reporter: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-702) Improve logging from Locationmap

Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-702?page=comments#action_12359381 ] 

Tim Williams commented on FOR-702:
----------------------------------

Is this still an issue?  Someone has apparently improved this significantly.  I just turned on debugging and was pleasantly suprised to see some good info being logged.  Is there something more specific that is needed with this issue?


> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>   Components: Locationmap
>     Reporter: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-702) Improve logging from Locationmap

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-702?page=comments#action_12359498 ] 

David Crossley commented on FOR-702:
------------------------------------

Re: Comment [06/Dec/05 10:40 AM]
The logkit.conf issue is followed up here:
 http://marc.theaimsgroup.com/?l=forrest-dev&m=11339125672532
 Re: tuning the logfiles

> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>   Components: Locationmap
>     Reporter: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-702) Improve logging from Locationmap

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-702?page=comments#action_12331344 ] 

David Crossley commented on FOR-702:
------------------------------------

Sorry don't understand what you mean. Did you raise the log level in WEB-INF/logkit.xconf file? .... you said "no log information is provided".

Or do you want "extra" information to be logged?

> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>     Reporter: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-702) Improve logging from Locationmap

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-702?page=comments#action_12359394 ] 

Ross Gardler commented on FOR-702:
----------------------------------

Yeah, I've been working on it periodically as I work on Locationmaps. Basically, if I find a problem I can't solve I add logging.

I've not found such a problem for a while, so maybe this issue can be closed, but not yet...

Right now the locatonmap logs are being duplicated in the linkrewriter, the locationmap and the core logs. This is a waste of resources, we need to make them appear in just the locationmap log. I guess this is a logkit.xconf setting

> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>   Components: Locationmap
>     Reporter: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (FOR-702) Improve logging from Locationmap

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-702?page=all ]
     
Ross Gardler resolved FOR-702:
------------------------------

    Resolution: Fixed
     Assign To: Ross Gardler

Resolving this issue, logs are fairly good now.

> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>   Components: Locationmap
>     Reporter: Ross Gardler
>     Assignee: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-702) Improve logging from Locationmap

Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-702?page=all ]

Tim Williams updated FOR-702:
-----------------------------

    Component: Locationmap

> Improve logging from Locationmap
> --------------------------------
>
>          Key: FOR-702
>          URL: http://issues.apache.org/jira/browse/FOR-702
>      Project: Forrest
>         Type: Improvement
>   Components: Locationmap
>     Reporter: Ross Gardler
>      Fix For: 0.8-dev

>
> Debugging locationmaps is currently very difficult as no log information is provided.
> We need the following debug log entries:
> - for matches - record all entries encountered
> - for select statements, record all entries being tested

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira