You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/05/13 01:44:17 UTC
[GitHub] [spark] ueshin opened a new pull request, #41160: [SPARK-41971][SQL][PYTHON][FOLLOWUP] Fix toPandas to support empty columns
ueshin opened a new pull request, #41160:
URL: https://github.com/apache/spark/pull/41160
### What changes were proposed in this pull request?
This is a follow-up of #40988.
Fixes `df.toPandas` to support empty columns.
The result will be no-column, same-length dataframe.
```py
>>> spark.range(2).select([]).toPandas()
Empty DataFrame
Columns: []
Index: [0, 1]
```
### Why are the changes needed?
Currently `df.toPandas()` fails if the columns are empty:
```py
>>> spark.range(2).select([]).toPandas()
Traceback (most recent call last):
...
ValueError: No objects to concatenate
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added the related test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41160: [SPARK-41971][PYTHON][FOLLOWUP] Fix toPandas to support empty columns
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41160: [SPARK-41971][PYTHON][FOLLOWUP] Fix toPandas to support empty columns
URL: https://github.com/apache/spark/pull/41160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng commented on pull request #41160: [SPARK-41971][PYTHON][FOLLOWUP] Fix toPandas to support empty columns
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #41160:
URL: https://github.com/apache/spark/pull/41160#issuecomment-1548618044
Late LGTM, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41160: [SPARK-41971][PYTHON][FOLLOWUP] Fix toPandas to support empty columns
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41160:
URL: https://github.com/apache/spark/pull/41160#issuecomment-1547089134
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org