You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "zhaoyansheng163 (via GitHub)" <gi...@apache.org> on 2023/02/07 15:15:48 UTC

[GitHub] [incubator-eventmesh] zhaoyansheng163 opened a new pull request, #3064: [ISSUE #2978] [Enhancement] Can be replaced with single 'Map.computeIfAbsent' method call[HeartBeatProcessor]

zhaoyansheng163 opened a new pull request, #3064:
URL: https://github.com/apache/incubator-eventmesh/pull/3064

   fix #2978 
    Can be replaced with single 'Map.computeIfAbsent' method call[HeartBeatProcessor]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] zhaoyansheng163 commented on pull request #3064: [ISSUE #2978] [Enhancement] Can be replaced with single 'Map.computeIfAbsent' method call[HeartBeatProcessor]

Posted by "zhaoyansheng163 (via GitHub)" <gi...@apache.org>.
zhaoyansheng163 commented on PR #3064:
URL: https://github.com/apache/incubator-eventmesh/pull/3064#issuecomment-1422174156

   resolve the checkstyle error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 merged pull request #3064: [ISSUE #2978] [Enhancement] Can be replaced with single 'Map.computeIfAbsent' method call[HeartBeatProcessor]

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3064:
URL: https://github.com/apache/incubator-eventmesh/pull/3064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3064: [ISSUE #2978] [Enhancement] Can be replaced with single 'Map.computeIfAbsent' method call[HeartBeatProcessor]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3064:
URL: https://github.com/apache/incubator-eventmesh/pull/3064#issuecomment-1422214513

   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3064](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ed00d1) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/e62b600e10ff6b08e96ecd3dc17fb6b746ffeffc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e62b600) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3064      +/-   ##
   ============================================
   - Coverage     12.86%   12.85%   -0.01%     
   - Complexity     1094     1096       +2     
   ============================================
     Files           548      548              
     Lines         28695    28656      -39     
     Branches       2860     2850      -10     
   ============================================
   - Hits           3691     3684       -7     
   + Misses        24692    24661      -31     
   + Partials        312      311       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...re/protocol/http/processor/HeartBeatProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGVhcnRCZWF0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...org/apache/eventmesh/common/ThreadPoolFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9UaHJlYWRQb29sRmFjdG9yeS5qYXZh) | `16.66% <0.00%> (-9.65%)` | :arrow_down: |
   | [.../apache/eventmesh/client/tcp/common/TcpClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3RjcC9jb21tb24vVGNwQ2xpZW50LmphdmE=) | `13.97% <0.00%> (-1.82%)` | :arrow_down: |
   | [...ntmesh/runtime/metrics/http/HTTPMetricsServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL21ldHJpY3MvaHR0cC9IVFRQTWV0cmljc1NlcnZlci5qYXZh) | `2.08% <0.00%> (-0.89%)` | :arrow_down: |
   | [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `91.20% <0.00%> (-0.34%)` | :arrow_down: |
   | [...sh/client/grpc/consumer/EventMeshGrpcConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvY29uc3VtZXIvRXZlbnRNZXNoR3JwY0NvbnN1bWVyLmphdmE=) | `62.13% <0.00%> (-0.23%)` | :arrow_down: |
   | [...time/core/protocol/tcp/client/session/Session.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `2.05% <0.00%> (-0.12%)` | :arrow_down: |
   | [...rg/apache/eventmesh/runtime/trace/LogExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3RyYWNlL0xvZ0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...g/apache/eventmesh/runtime/util/EventMeshUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvRXZlbnRNZXNoVXRpbC5qYXZh) | `75.16% <0.00%> (ø)` | |
   | [...ntmesh/client/http/AbstractProducerHttpClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvQWJzdHJhY3RQcm9kdWNlckh0dHBDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/3064?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org