You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by cu...@apache.org on 2019/05/22 14:05:12 UTC
[whimsy] branch master updated: Fix auth realm
This is an automated email from the ASF dual-hosted git repository.
curcuru pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new f7a9b58 Fix auth realm
f7a9b58 is described below
commit f7a9b588f74afec0a8551b6db667c28c5d3b5d05
Author: Shane Curcuru <as...@shanecurcuru.org>
AuthorDate: Wed May 22 10:05:02 2019 -0400
Fix auth realm
---
www/board/list-traffic.cgi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/board/list-traffic.cgi b/www/board/list-traffic.cgi
index f02119a..0d843aa 100755
--- a/www/board/list-traffic.cgi
+++ b/www/board/list-traffic.cgi
@@ -13,7 +13,7 @@ require 'mail'
user = ASF::Person.new($USER)
unless user.asf_member? or ASF.pmc_chairs.include? user
print "Status: 401 Unauthorized\r\n"
- print "WWW-Authenticate: Basic realm=\"ASF Members and PMC chairs\"\r\n\r\n"
+ print "WWW-Authenticate: Basic realm=\"ASF Members and Officers\"\r\n\r\n"
exit
end
Re: [whimsy] branch master updated: Fix auth realm
Posted by Shane Curcuru <as...@shanecurcuru.org>.
sebb wrote on 2019-5-22 1:08PM EDT:
> On Wed, 22 May 2019 at 15:05, <cu...@apache.org> wrote:
...snip...
>> unless user.asf_member? or ASF.pmc_chairs.include? user
>> print "Status: 401 Unauthorized\r\n"
>> - print "WWW-Authenticate: Basic realm=\"ASF Members and PMC chairs\"\r\n\r\n"
>> + print "WWW-Authenticate: Basic realm=\"ASF Members and Officers\"\r\n\r\n"
>
> This apparent discrepancy of text and check needs documenting, else it
> may be 'fixed' again.
The realm should match the realm from the httpd config in any case:
https://github.com/apache/infrastructure-puppet/blob/913ae1ba3b4dfca0c480add75765a3b5436f1230/data/nodes/whimsy-vm4.apache.org.yaml#L150
I'm happy to have someone update the "or ASF.pmc_chairs.include? user"
to be a more appropriate method, although see also the "Clarify karma
check" thread for the $reasons. The intent is that anyone who can
subscribe to board@ should be able to see this page.
--
- Shane
Whimsy PMC
The Apache Software Foundation
Re: [whimsy] branch master updated: Fix auth realm
Posted by sebb <se...@gmail.com>.
On Wed, 22 May 2019 at 15:05, <cu...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> curcuru pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new f7a9b58 Fix auth realm
> f7a9b58 is described below
>
> commit f7a9b588f74afec0a8551b6db667c28c5d3b5d05
> Author: Shane Curcuru <as...@shanecurcuru.org>
> AuthorDate: Wed May 22 10:05:02 2019 -0400
>
> Fix auth realm
> ---
> www/board/list-traffic.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/board/list-traffic.cgi b/www/board/list-traffic.cgi
> index f02119a..0d843aa 100755
> --- a/www/board/list-traffic.cgi
> +++ b/www/board/list-traffic.cgi
> @@ -13,7 +13,7 @@ require 'mail'
> user = ASF::Person.new($USER)
> unless user.asf_member? or ASF.pmc_chairs.include? user
> print "Status: 401 Unauthorized\r\n"
> - print "WWW-Authenticate: Basic realm=\"ASF Members and PMC chairs\"\r\n\r\n"
> + print "WWW-Authenticate: Basic realm=\"ASF Members and Officers\"\r\n\r\n"
This apparent discrepancy of text and check needs documenting, else it
may be 'fixed' again.
> exit
> end
>
>