You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:30:43 UTC
[GitHub] [buildstream] BuildStream-Migration-Bot opened a new pull request #1424: .pylintrc: Simplify config, only list overrides
BuildStream-Migration-Bot opened a new pull request #1424:
URL: https://github.com/apache/buildstream/pull/1424
[See original merge request on GitLab](https://gitlab.com/BuildStream/buildstream/-/merge_requests/2011)
In GitLab by [[Gitlab user @cs-shadow]](https://gitlab.com/cs-shadow) on Aug 3, 2020, 21:36
Rather than having the full `.pylintrc`, only list the overrides that we
have compared to the default options. This makes it easy to identify
what options we have modified, which is also similar to what we do for
configuring other tools.
At the same time, also remove overrides corresponding to the `gi`
module. They were added when this repository depended on the `ostree`
module but that's no longer the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on pull request #1424: .pylintrc: Simplify config, only list overrides
Posted by GitBox <gi...@apache.org>.
abderrahim commented on pull request #1424:
URL: https://github.com/apache/buildstream/pull/1424#issuecomment-1073275958
I think we should merge this. The concern raised that we would need to modify the config in case a new warning is added is incorrect as we already have to make changes whenever we update pylint (see #1494 #1531 #1564).
@cs-shadow do you want to rebase or shall I do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1424: .pylintrc: Simplify config, only list overrides
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1424:
URL: https://github.com/apache/buildstream/pull/1424#issuecomment-773097039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1424: .pylintrc: Simplify config, only list overrides
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1424:
URL: https://github.com/apache/buildstream/pull/1424#issuecomment-773097187
In GitLab by [[Gitlab user @tristanvb]](https://gitlab.com/tristanvb) on Aug 4, 2020, 08:13
I believe the original configuration was by [[Gitlab user @tlater]](https://gitlab.com/tlater) and had the specific intent of ensuring that new versions of the linter did not behave drastically different (I think in the current setup, new `pylint` errors need to be explicitly disabled or fixed in the code in order to upgrade `pylint`).
Note that `pylint` support predates our usage of `tox`, which might in itself obsolete the complicated `.pylintrc`, but I think this needs to be explicitly confirmed before drastically changing the configuration approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1424: .pylintrc: Simplify config, only list overrides
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1424:
URL: https://github.com/apache/buildstream/pull/1424#issuecomment-773097039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1424: .pylintrc: Simplify config, only list overrides
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1424:
URL: https://github.com/apache/buildstream/pull/1424#issuecomment-773097261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org