You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/11 09:49:01 UTC
[GitHub] [spark] gaborgsomogyi opened a new pull request #27877:
[WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
gaborgsomogyi opened a new pull request #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599886589
**[Test build #119911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119911/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599648359
**[Test build #119869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119869/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877: [SPARK-30541][TESTS]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601723051
**[Test build #120100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120100/testReport)** for PR 27877 at commit [`c4df60c`](https://github.com/apache/spark/commit/c4df60cd48897071d0a6f75187d6271f896a47d5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601050268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24756/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599910702
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119911/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600672936
**[Test build #119996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119996/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601840107
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597740100
I've just double checked `ZookeeperServer` and seems like implemented it's own Kerberos authentication manually. Tried to mimic the same steps and clear the shared state in the following way without success:
```
System.setProperty(JAVA_AUTH_CONFIG, jaasConfigFile)
Configuration.getConfiguration.refresh()
val lcs = new LoginContext("Server")
lcs.login()
lcs.getSubject().getPublicCredentials().clear();
lcs.getSubject().getPrivateCredentials().clear();
val lcc = new LoginContext("Client")
lcc.login()
lcc.getSubject().getPublicCredentials().clear();
lcc.getSubject().getPrivateCredentials().clear();
val lck = new LoginContext("KafkaServer")
lck.login()
lck.getSubject().getPublicCredentials().clear();
lck.getSubject().getPrivateCredentials().clear();
```
Now checking to execute it in a separate JVM but not sure how it will behave with `testRetry`. If I undertand the code properly retries will be executed in the exact same separate JVM which is not good for us, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597539520
**[Test build #119666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119666/testReport)** for PR 27877 at commit [`21129c4`](https://github.com/apache/spark/commit/21129c4d6b002e1cee77f949a5380603d807b2cf).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600270933
**[Test build #119953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119953/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601603280
**[Test build #120090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120090/testReport)** for PR 27877 at commit [`ef9868f`](https://github.com/apache/spark/commit/ef9868f54383abaa0556c8254227e0a74ac473e3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601603280
**[Test build #120090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120090/testReport)** for PR 27877 at commit [`ef9868f`](https://github.com/apache/spark/commit/ef9868f54383abaa0556c8254227e0a74ac473e3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601044712
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600878663
**[Test build #120004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120004/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600767582
**[Test build #119996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119996/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600566982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119979/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27877: [SPARK-30541][TESTS]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-602139244
LGTM too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599782441
**[Test build #119887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119887/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599532502
**[Test build #119867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119867/testReport)** for PR 27877 at commit [`065ad0d`](https://github.com/apache/spark/commit/065ad0d3569672bd9b36384904d828874d888afb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r395662927
##########
File path: external/kafka-0-10-sql/src/test/resources/log4j.properties
##########
@@ -25,4 +25,6 @@ log4j.appender.file.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{
# Ignore messages below warning level from Jetty, because it's a bit verbose
log4j.logger.org.spark-project.jetty=WARN
-
+log4j.logger.org.apache.spark.sql.kafka010.KafkaTestUtils=DEBUG
+log4j.logger.org.apache.directory.server.kerberos.kdc.authentication=DEBUG
+log4j.logger.org.apache.directory.server.core.DefaultDirectoryService=DEBUG
Review comment:
Without these 3 loggers the output is `2836` lines and with them `3116`. I think it's a feasible addition. Having no/missing spots in the debug logs it's pretty hard to debug failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600458527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119969/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r395657579
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -74,6 +74,7 @@ class KafkaTestUtils(
logInfo(s"Local host name is $localCanonicalHostName")
private var kdc: MiniKdc = _
+ private var kdcDataDir: File = _
Review comment:
Thought the cleanup was not fully done and now I've fixed it. I've just double checked and `Utils.createTempDir()` adds this so the clean part is not needed: `ShutdownHookManager.registerShutdownDeleteDir(dir)`. Rolling back...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600347184
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119953/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600270933
**[Test build #119953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119953/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600878837
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120004/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600767778
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599648739
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600878837
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120004/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600028960
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600458527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119969/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601179694
Yes, it's okay from my side. Looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601049566
**[Test build #120039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120039/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600347184
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119953/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601210442
Thanks guys, proceeding with it...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r395609658
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -74,6 +74,7 @@ class KafkaTestUtils(
logInfo(s"Local host name is $localCanonicalHostName")
private var kdc: MiniKdc = _
+ private var kdcDataDir: File = _
Review comment:
consider `createKeytabsAndJaasConfigFile` as setup and `teardown` as cleanup - you'll find the reason. There might be some utility method to do cleanup of temp dir automatically as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601723051
**[Test build #120100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120100/testReport)** for PR 27877 at commit [`c4df60c`](https://github.com/apache/spark/commit/c4df60cd48897071d0a6f75187d6271f896a47d5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601668582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120090/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600207117
**[Test build #119937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119937/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600571004
**[Test build #119985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119985/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600797951
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597538363
**[Test build #119666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119666/testReport)** for PR 27877 at commit [`21129c4`](https://github.com/apache/spark/commit/21129c4d6b002e1cee77f949a5380603d807b2cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597545597
**[Test build #119667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119667/testReport)** for PR 27877 at commit [`1aafd83`](https://github.com/apache/spark/commit/1aafd83609d0f23548ce192fbdbb5a8f700c2dc2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600801562
**[Test build #120004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120004/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r395604822
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -74,6 +74,7 @@ class KafkaTestUtils(
logInfo(s"Local host name is $localCanonicalHostName")
private var kdc: MiniKdc = _
+ private var kdcDataDir: File = _
Review comment:
Hm, quick question. Is this related to the fix? I couldn't follow why we need to have this var.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599782666
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119887/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600652303
**[Test build #119985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119985/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597555150
cc @zsxwing since you've also started to reproduce this issue. Maybe you find my part useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599687142
**[Test build #119887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119887/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597617627
**[Test build #119667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119667/testReport)** for PR 27877 at commit [`1aafd83`](https://github.com/apache/spark/commit/1aafd83609d0f23548ce192fbdbb5a8f700c2dc2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599910662
**[Test build #119911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119911/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600652569
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119985/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599547375
@zsxwing I've changed to a new approach, namely:
* execute the suite in separate JVM => this will reduce (but not fully solve) `beforeAll` related issues. Newly created JVM mustn't have any old authentication information in place.
* use `testRetry("Roundtrip", 3)` => this will solve test related flakyness
Let's see how it behaves and I'll kick this couple of hundred times...
The bulletproof solution would be to use separate JVM with full suite retry but haven't found solution to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597707477
> @gaborgsomogyi Great investigation. Maybe we can look at Kafka's own token tests to see if they have solved the same issue.
Great idea, until now I've understood `Krb5LoginModule` control flags as a whole but not yet found the cure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601840107
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601125139
**[Test build #120039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120039/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601048160
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600668879
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600458523
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597538723
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600767778
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600102099
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600566974
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600652569
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119985/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599782657
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600801562
**[Test build #120004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120004/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600104484
**[Test build #119937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119937/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600029774
**[Test build #119930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119930/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601125344
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120039/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600566982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119979/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599627348
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119867/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597748239
Kafka broker may not come up since it's flaky so I think we need some kind of retry to protect us. Actually this is one of the main cause of flakyness...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600568502
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601840115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120100/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599648739
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601125344
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120039/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600207388
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600486548
**[Test build #119979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119979/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27877:
[WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r390853889
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaDelegationTokenSuite.scala
##########
@@ -44,75 +46,79 @@ class KafkaDelegationTokenSuite extends StreamTest with SharedSparkSession with
.set("spark.kafka.clusters.cluster1.auth.bootstrap.servers", testUtils.brokerAddress)
.set("spark.kafka.clusters.cluster1.security.protocol", SASL_PLAINTEXT.name)
- override def beforeAll(): Unit = {
- testUtils = new KafkaTestUtils(Map.empty, true)
- testUtils.setup()
- super.beforeAll()
- }
-
- override def afterAll(): Unit = {
+ testRetry("Roundtrip", 3) {
try {
- if (testUtils != null) {
- testUtils.teardown()
- testUtils = null
+ deInitializeSession()
+
+ testUtils = new KafkaTestUtils(Map.empty, true)
+ testUtils.setup()
+
+ initializeSession()
+
+ val hadoopConf = new Configuration()
+ val manager = new HadoopDelegationTokenManager(spark.sparkContext.conf, hadoopConf, null)
+ val credentials = new Credentials()
+ manager.obtainDelegationTokens(credentials)
+ val serializedCredentials = SparkHadoopUtil.get.serialize(credentials)
+ SparkHadoopUtil.get.addDelegationTokens(serializedCredentials, spark.sparkContext.conf)
+
+ val topic = "topic-" + UUID.randomUUID().toString
+ testUtils.createTopic(topic, partitions = 5)
+
+ withTempDir { checkpointDir =>
+ val input = MemoryStream[String]
+
+ val df = input.toDF()
+ val writer = df.writeStream
+ .outputMode(OutputMode.Append)
+ .format("kafka")
+ .option("checkpointLocation", checkpointDir.getCanonicalPath)
+ .option("kafka.bootstrap.servers", testUtils.brokerAddress)
+ .option("topic", topic)
+ .start()
+
+ try {
+ input.addData("1", "2", "3", "4", "5")
+ failAfter(streamingTimeout) {
+ writer.processAllAvailable()
+ }
+ } finally {
+ writer.stop()
+ }
}
- UserGroupInformation.reset()
- } finally {
- super.afterAll()
- }
- }
-
- ignore("Roundtrip") {
- val hadoopConf = new Configuration()
- val manager = new HadoopDelegationTokenManager(spark.sparkContext.conf, hadoopConf, null)
- val credentials = new Credentials()
- manager.obtainDelegationTokens(credentials)
- val serializedCredentials = SparkHadoopUtil.get.serialize(credentials)
- SparkHadoopUtil.get.addDelegationTokens(serializedCredentials, spark.sparkContext.conf)
-
- val topic = "topic-" + UUID.randomUUID().toString
- testUtils.createTopic(topic, partitions = 5)
- withTempDir { checkpointDir =>
- val input = MemoryStream[String]
-
- val df = input.toDF()
- val writer = df.writeStream
- .outputMode(OutputMode.Append)
+ if (KafkaDelegationTokenSuite.cnt == 0) {
Review comment:
This is just to simulate retry. Later it will be deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600101808
**[Test build #119930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119930/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r395606549
##########
File path: external/kafka-0-10-sql/src/test/resources/log4j.properties
##########
@@ -25,4 +25,6 @@ log4j.appender.file.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{
# Ignore messages below warning level from Jetty, because it's a bit verbose
log4j.logger.org.spark-project.jetty=WARN
-
+log4j.logger.org.apache.spark.sql.kafka010.KafkaTestUtils=DEBUG
+log4j.logger.org.apache.directory.server.kerberos.kdc.authentication=DEBUG
+log4j.logger.org.apache.directory.server.core.DefaultDirectoryService=DEBUG
Review comment:
Another quick question. How much noisy is it? I haven't tried it by myself yet but seems a bit overkill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600484152
seems unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597749918
`KafkaTestUtils.setup` creates an embedded broker (+KDC +zookeeper) and the broker sometimes simply not coming up (blows up in `waitUntilMetadataIsPropagated`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600767785
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119996/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r396046145
##########
File path: external/kafka-0-10-sql/src/test/resources/log4j.properties
##########
@@ -25,4 +25,6 @@ log4j.appender.file.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{
# Ignore messages below warning level from Jetty, because it's a bit verbose
log4j.logger.org.spark-project.jetty=WARN
-
+log4j.logger.org.apache.spark.sql.kafka010.KafkaTestUtils=DEBUG
+log4j.logger.org.apache.directory.server.kerberos.kdc.authentication=DEBUG
+log4j.logger.org.apache.directory.server.core.DefaultDirectoryService=DEBUG
Review comment:
Thanks. Since this is a test resource, it looks safe to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600672936
**[Test build #119996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119996/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600566974
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597539539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119666/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600767785
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119996/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600458379
**[Test build #119969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119969/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600437781
**[Test build #119969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119969/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600102121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119930/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600878834
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600347052
**[Test build #119953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119953/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600652559
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601125331
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599782666
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119887/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601170209
That's a great news! I'm OK to go forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600207399
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119937/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597545597
**[Test build #119667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119667/testReport)** for PR 27877 at commit [`1aafd83`](https://github.com/apache/spark/commit/1aafd83609d0f23548ce192fbdbb5a8f700c2dc2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600652559
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600104484
**[Test build #119937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119937/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600267136
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600207399
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119937/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599885091
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600486548
**[Test build #119979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119979/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601840115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120100/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601049566
**[Test build #120039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120039/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597768461
Double checked the Kafka tests with the guys and haven't found test which is secure and retries within one JVM. Maybe external JVM with retry could be a solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599910702
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119911/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599684285
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599532502
**[Test build #119867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119867/testReport)** for PR 27877 at commit [`065ad0d`](https://github.com/apache/spark/commit/065ad0d3569672bd9b36384904d828874d888afb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600437781
**[Test build #119969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119969/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597554402
After local testing I've seen an interesting phenomenon. The first round of test executed properly and then the hardcoded `IllegalArgumentException` fired. Then `KDC` and Zookeeper server started properly but when `KafkaZkClient` must authenticate Kerberos is not doing a brand new authentication but found the `TGT` from the previous run (which is generated by the previous `KDC` and won't be accepted by the new):
```
Found ticket for zookeeper/localhost@EXAMPLE.COM to go to krbtgt/EXAMPLE.COM@EXAMPLE.COM expiring on Thu Mar 12 02:53:17 PDT 2020
Found ticket for zkclient/localhost@EXAMPLE.COM to go to krbtgt/EXAMPLE.COM@EXAMPLE.COM expiring on Thu Mar 12 02:53:02 PDT 2020
```
See the 15 seconds timegap between the 2, `zookeeper` `TGT` just created but `zkclient` found in the JVM's shared state. Honestly not sure why only `zkclient` `TGT` found?!
At the moment no idea how to reset this shared state and analysing the JVM source code. If somebody has idea then feel free to shed some lights...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599886589
**[Test build #119911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119911/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600103790
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599648742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119869/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599782657
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601050257
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601668576
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599984029
retest this plese
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600878834
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601050268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24756/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597538723
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600029774
**[Test build #119930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119930/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599687142
**[Test build #119887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119887/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600347174
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599551977
**[Test build #119869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119869/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877: [SPARK-30541][TESTS]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601667812
**[Test build #120090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120090/testReport)** for PR 27877 at commit [`ef9868f`](https://github.com/apache/spark/commit/ef9868f54383abaa0556c8254227e0a74ac473e3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600571004
**[Test build #119985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119985/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600347174
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877: [SPARK-30541][TESTS]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601838536
**[Test build #120100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120100/testReport)** for PR 27877 at commit [`c4df60c`](https://github.com/apache/spark/commit/c4df60cd48897071d0a6f75187d6271f896a47d5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597538363
**[Test build #119666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119666/testReport)** for PR 27877 at commit [`21129c4`](https://github.com/apache/spark/commit/21129c4d6b002e1cee77f949a5380603d807b2cf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597539533
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877: [WIP][SPARK-30541]
Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597539539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119666/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zsxwing commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
zsxwing commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597704945
@gaborgsomogyi Great investigation. Maybe we can look at Kafka's own token tests to see if they have solved the same issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599551977
**[Test build #119869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119869/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597617833
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119667/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601050257
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600436184
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599648742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119869/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601668582
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120090/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600207388
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601125331
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599627348
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119867/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599910697
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600102121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119930/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600102099
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599984029
retest this plese
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599627342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599983970
looks unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600566804
**[Test build #119979 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119979/testReport)** for PR 27877 at commit [`bc4fb8b`](https://github.com/apache/spark/commit/bc4fb8bdd37dd64a217126bc6edb48eaee91c454).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597539533
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zsxwing commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
zsxwing commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597717586
One workaround right now is adding this test to this group to use its own jvm: https://github.com/apache/spark/blob/master/project/SparkBuild.scala#L463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597617833
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119667/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597617823
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599910697
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on a change in pull request #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r393039928
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaDelegationTokenSuite.scala
##########
@@ -95,6 +95,11 @@ class KafkaDelegationTokenSuite extends StreamTest with SharedSparkSession with
}
}
+ if (KafkaDelegationTokenSuite.cnt == 0) {
Review comment:
This is again to trigger retry and will be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599627342
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601668576
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-601162126
The latest code has been executed 1k+ times without failure. What do you think guys? Should we clean this approach up and merge it or do you have better approach?
@zsxwing @HyukjinKwon @dongjoon-hyun @HeartSaVioR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zsxwing commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
zsxwing commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597746835
Do we still need `testRetry` when running in a separate JVM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-597617823
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-599627153
**[Test build #119867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119867/testReport)** for PR 27877 at commit [`065ad0d`](https://github.com/apache/spark/commit/065ad0d3569672bd9b36384904d828874d888afb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600458523
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on issue #27877:
[WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on issue #27877: [WIP][SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#issuecomment-600484208
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org