You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/12 08:53:07 UTC
[GitHub] [flink] kl0u commented on a change in pull request #9090:
[FLINK-13124] Don't forward exceptions when finishing SourceStreamTask
kl0u commented on a change in pull request #9090: [FLINK-13124] Don't forward exceptions when finishing SourceStreamTask
URL: https://github.com/apache/flink/pull/9090#discussion_r302887969
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -118,7 +124,9 @@ protected void performDefaultAction(ActionContext context) throws Exception {
}
sourceThread.join();
- sourceThread.checkThrowSourceExecutionException();
+ if (!isFinished) {
Review comment:
Given the above comment, this can be a `protected` getter method for the `finished` flag in the `StreamTask`, available to all `StreamTask`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services