[GitHub] [spark] MaxGekk commented on a change in pull request #31131: [SPARK-34071][SQL][TESTS] Check stats of cached v1 tables after altering

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #31131:
URL: https://github.com/apache/spark/pull/31131#discussion_r555266380



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandTestUtils.scala
##########
@@ -91,4 +91,20 @@ trait DDLCommandTestUtils extends SQLTestUtils {
   }
 
   protected def checkLocation(t: String, spec: TablePartitionSpec, expected: String): Unit
+
+  // Getting the total table size in the filesystem in bytes
+  def getTableSize(t: String): Int = {

Review comment:
       We discussed this with @cloud-fan in other PRs, and decided to use short names for variables with small scope.
   
   If you look at the unified tests, you can see `t` everywhere used for table names. This made sql statements shorter.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org