Re: [PR] API, CORE, Flink, Spark: Deprecate Snapshot Change Methods [iceberg]

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #15241:
URL: https://github.com/apache/iceberg/pull/15241#discussion_r2898273607


##########
core/src/main/java/org/apache/iceberg/CherryPickOperation.java:
##########
@@ -71,6 +71,10 @@ public CherryPickOperation cherrypick(long snapshotId) {
     ValidationException.check(
         cherrypickSnapshot != null, "Cannot cherry-pick unknown snapshot ID: %s", snapshotId);
 
+    Table table = new BaseTable(ops(), tableName);

Review Comment:
   Hm, I'm not a fan of creating table instances when we have just thrown one away like this. Instead, I think we usually prefer a package-private alternative that accepts `TableOperations` instead of `Table`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org