You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/08/01 10:45:53 UTC
[GitHub] [incubator-eventmesh] LIU-WEI-git opened a new pull request, #1061: Dledger connector
LIU-WEI-git opened a new pull request, #1061:
URL: https://github.com/apache/incubator-eventmesh/pull/1061
Hi, I'm the selected student of OSPP2022. This pr is about the [DLedger Connector](https://summer-ospp.ac.cn/#/org/prodetail/229020158). Here is a rough [design doc](https://pasj6mrws2.feishu.cn/docx/doxcntPIZFUy00R7zq6PToKA6Vc) about this module.
### Documentation
- This pull request introduce a new feature.
- The detail doc will be added after all development done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] LIU-WEI-git closed pull request #1061: [ISSUE #1070] DLedger Connector: first exploratory implementation
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git closed pull request #1061: [ISSUE #1070] DLedger Connector: first exploratory implementation
URL: https://github.com/apache/incubator-eventmesh/pull/1061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1061: [ISSUE #1070] DLedger Connector: first exploratory implementation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1061:
URL: https://github.com/apache/incubator-eventmesh/pull/1061#issuecomment-1204565286
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1061](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b437689) into [dledger-connector](https://codecov.io/gh/apache/incubator-eventmesh/commit/dab10863a82a1828ea2e44b164086a1427abd8a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dab1086) will **increase** coverage by `0.20%`.
> The diff coverage is `32.85%`.
> :exclamation: Current head b437689 differs from pull request most recent head 6e4f23b. Consider uploading reports for the commit 6e4f23b to get more accurate results
```diff
@@ Coverage Diff @@
## dledger-connector #1061 +/- ##
======================================================
+ Coverage 8.42% 8.63% +0.20%
- Complexity 534 559 +25
======================================================
Files 362 374 +12
Lines 23228 23508 +280
Branches 2546 2559 +13
======================================================
+ Hits 1958 2029 +71
- Misses 21118 21317 +199
- Partials 152 162 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/eventmesh/connector/dledger/DLedgerConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvRExlZGdlckNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...sh/connector/dledger/broker/CloudEventMessage.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvYnJva2VyL0Nsb3VkRXZlbnRNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...connector/dledger/broker/DLedgerMessageWriter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvYnJva2VyL0RMZWRnZXJNZXNzYWdlV3JpdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ntmesh/connector/dledger/broker/SubscribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvYnJva2VyL1N1YnNjcmliZVRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/dledger/exception/DLedgerConnectorException.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvZXhjZXB0aW9uL0RMZWRnZXJDb25uZWN0b3JFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/eventmesh/connector/dledger/DLedgerProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvRExlZGdlclByb2R1Y2VyLmphdmE=) | `33.33% <33.33%> (ø)` | |
| [...ector/dledger/broker/DLedgerTopicIndexesStore.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvYnJva2VyL0RMZWRnZXJUb3BpY0luZGV4ZXNTdG9yZS5qYXZh) | `33.33% <33.33%> (ø)` | |
| [...onnector/dledger/clientpool/DLedgerClientPool.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvY2xpZW50cG9vbC9ETGVkZ2VyQ2xpZW50UG9vbC5qYXZh) | `43.47% <43.47%> (ø)` | |
| [...or/dledger/config/DLedgerConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvY29uZmlnL0RMZWRnZXJDb25maWd1cmF0aW9uV3JhcHBlci5qYXZh) | `52.63% <52.63%> (ø)` | |
| [...ector/dledger/clientpool/DLedgerClientFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1kbGVkZ2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2RsZWRnZXIvY2xpZW50cG9vbC9ETGVkZ2VyQ2xpZW50RmFjdG9yeS5qYXZh) | `66.66% <66.66%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1061/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on pull request #1061: DLedger Connector
Posted by GitBox <gi...@apache.org>.
Alonexc commented on PR #1061:
URL: https://github.com/apache/incubator-eventmesh/pull/1061#issuecomment-1202071212
Welcome, you need to provide an issue for this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] LIU-WEI-git commented on pull request #1061: DLedger Connector
Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on PR #1061:
URL: https://github.com/apache/incubator-eventmesh/pull/1061#issuecomment-1201057343
DLedger provides only two simple commitlog management operations: append and get. So I have to implement pub/sub mechanism by my self, which brings many design problems for current implement.
- Implement a pub/sub mechanism which is against the separation of computing and storage for connector module.
- Just store cloudevent in DLedger while not store the metadata of pub/sub mechanism.
- Metadata of pub/sub could not synchronize among eventmesh cluster.
- Could not recover the pub/sub status from crash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 commented on pull request #1061: DLedger Connector
Posted by GitBox <gi...@apache.org>.
mytang0 commented on PR #1061:
URL: https://github.com/apache/incubator-eventmesh/pull/1061#issuecomment-1201923056
Great! Excluding other commits will make it easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org