You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/23 08:37:18 UTC
[GitHub] [flink] wsry opened a new pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
wsry opened a new pull request #11877:
URL: https://github.com/apache/flink/pull/11877
## What is the purpose of the change
This is the second ingredient besides FLINK-16404 to solve the deadlock problem without exclusive buffers.
The scenario is as follows:
The data in subpartition with positive backlog can be sent without doubt because the exclusive credits would be feedback finally.
Without exclusive buffers, the receiver would not request floating buffers for 0 backlog. But when the new backlog is added into such subpartition, it has no way to notify the receiver side without positive credits ATM.
So it would result in waiting for each other between receiver and sender sides to cause deadlock. The sender waits for credit to notify backlog and the receiver waits for backlog to request floating credits.
To solve the above problem, the sender needs a separate message to announce backlog sometimes besides existing `BufferResponse`. Then the receiver can get this info to request floating buffers to feedback.
## Brief change log
- Add sender side backlog maintenance and announcement logic;
- Receiver side request floating buffers according to the sender's announced backlog strictly;
- Test cases are added to verify the change.
## Verifying this change
This change is verified by both existing tests and newly added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767)
* ae312385b57ca67cdb73ee96be38c4edbe56478d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b6eb661923f59967a116e9074cf790fd694c578 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b6eb661923f59967a116e9074cf790fd694c578 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863)
* 2c49d1a8cee6485e8f367190f152e58960c901ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5682e0256634e2ce1a38ca132cdaaddc79ee71c0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422466188
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -428,6 +423,23 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
Make the following condition out of `synchronized` part, then we do not need to touch the lock for most of the cases.
```
if (!(initialCredit == 0 && options.isExactlyOnceMode() && !options.isUnalignedCheckpoint())) {
return;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422868983
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -94,13 +99,27 @@ public void requestSubpartitionView(
}
@Override
- public void addCredit(int creditDeltas) {
+ public boolean addCredit(int creditDeltas) {
numCreditsAvailable += creditDeltas;
+ return shouldAnnounceBacklog();
Review comment:
why we need to trigger announce backlog while adding credit?
I assume since the added `creditDeltas` is always more than zero, then we have the chance to announce the backlog later via sending `BufferResponse`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfdb8bfa05b783479697bd3aa3de3fac2628482 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077)
* 66de3ded5740c19aab5984c8650b5d6a355ed6e8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452ba169e20663de86d84ab6ea938bdf772be482 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161590525) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115)
* 929403a9ae1b734c4e72a4585862f994d8c1f5e9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666723543
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -312,6 +323,16 @@ BufferAndBacklog pollBuffer() {
decreaseBuffersInBacklogUnsafe(bufferConsumer.isBuffer());
}
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
Currently, I can only come up with the following way, which depends on the downstream to reset the available credit of the upstream. This at least needs to add a special network message and propagating this message can incur extra overhead. If you think this is really important, I will spend some time to rethink about it and see if I can find a better way to solve it.
> Maybe one way is to not sending any data out after sending a buffer with 0 backlog at sender side, then the receivers clear all floating credits and send a reset message to the senders. Then the senders reset all available credits. This process is similar to the channel blocking and resumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-875373001
@pnowojski Thanks for the review and comments. I will spend some time to split the last commit into smaller ones and update the PR soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-871983588
Hi @akalash really thanks for the review and comments.
I must admit that this PR is pretty fragmented and is not easy to review. One reason is that the existing implementation relies heavily on the assumption that the exclusive credit is not 0. However, this PR breaks this assumption. Many changes in this PR is to achieve the goal of allocating floating credits at the downstream side according to backlog of the upstream task strictly if there is no exclusive credit. One buffer one credit, no more and no less (event does not take any credit). If this is not guaranteed, credit deadlock may occur.
Thanks again for the review. I will run more tests to guarantees the correctness of this change. (Previously, I already ran some tests including the azure pipeline when setting the exclusive buffer to 0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452ba169e20663de86d84ab6ea938bdf772be482 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161590525) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662003477
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -83,8 +84,13 @@ public BufferManager(
// ------------------------------------------------------------------------
@Nullable
- Buffer requestBuffer() {
+ Buffer requestBuffer(int initialCredit) {
Review comment:
You are right, we can avoid this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1814aee57851711782cc2d922c4ef8f118a74c13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878)
* f28812c2d19b7109e851d4cce6cdb9df82868117 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893)
* 048818bd8e4548d20febf9308b83e42146806b6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898)
* 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 048818bd8e4548d20febf9308b83e42146806b6e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898)
* 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735)
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665895504
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -91,10 +91,14 @@ public BufferAndBacklog getNextBuffer() throws IOException {
updateStatistics(current);
- // We simply assume all the data are non-events for batch jobs to avoid pre-fetching the
- // next header
- Buffer.DataType nextDataType =
- numDataAndEventBuffers > 0 ? Buffer.DataType.DATA_BUFFER : Buffer.DataType.NONE;
+ // We simply assume all the data except for the last one (EndOfPartitionEvent)
+ // are non-events for batch jobs to avoid pre-fetching the next header
+ Buffer.DataType nextDataType = Buffer.DataType.NONE;
+ if (numDataBuffers > 0) {
+ nextDataType = Buffer.DataType.DATA_BUFFER;
+ } else if (numDataAndEventBuffers > 0) {
+ nextDataType = Buffer.DataType.EVENT_BUFFER;
+ }
Review comment:
Let's stay with the option 2 (as you have currently implemented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f28812c2d19b7109e851d4cce6cdb9df82868117 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893)
* 048818bd8e4548d20febf9308b83e42146806b6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898)
* 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452ba169e20663de86d84ab6ea938bdf772be482 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662005533
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -130,11 +136,11 @@ private boolean shouldContinueRequest(BufferPool bufferPool) {
/** Requests exclusive buffers from the provider. */
void requestExclusiveBuffers(int numExclusiveBuffers) throws IOException {
- Collection<MemorySegment> segments = globalPool.requestMemorySegments(numExclusiveBuffers);
- checkArgument(
- !segments.isEmpty(),
- "The number of exclusive buffers per channel should be larger than 0.");
+ if (numExclusiveBuffers <= 0) {
Review comment:
You are right, I will add a checkArgument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c49d1a8cee6485e8f367190f152e58960c901ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885)
* c161aff32e5aed483ca0722e0504ec8493348947 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 929403a9ae1b734c4e72a4585862f994d8c1f5e9 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161611411) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128)
* ca6f75c37da358874cc38d7998bce5c4445feff5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162162353) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422972620
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -428,6 +423,23 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
Considering the race condition between this operation and canceler task, it might involve in potential conflicts and deadlock case if `removeBufferListener` and adjust `isWaitingForFloatingBuffers` here. Let me think whether we can lazy remove the listener and adjust `isWaitingForFloatingBuffers` by reusing the existing process `RemoteInputChannel#notifyBufferAvailable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfdb8bfa05b783479697bd3aa3de3fac2628482 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* edabda8971fb299b278a0bd0b42c2dca82c8a6a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489)
* d8b233f483d45b8901cc28770be9da71a39929ef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662003058
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -513,19 +514,20 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
public int getBuffersInBacklog() {
- if (flushRequested || isFinished) {
- return buffersInBacklog;
- } else {
- return Math.max(buffersInBacklog - 1, 0);
+ synchronized (buffers) {
+ if (isBlocked || buffers.isEmpty()) {
Review comment:
After the channel is blocked, we do not need to allocated any credit at the downstream, because no buffer will be sent. As mentioned in your comment, if the initialCredit is 0, it should return 0. If the initialCredit is not 0, we always have exclusive credits, we still do not need allocate any floating credit. Maybe returning the actual value instead of 0 is a small improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r663591285
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
It is pretty simple to send empty buffer only when #exclusiveBuffers == 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1814aee57851711782cc2d922c4ef8f118a74c13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878)
* f28812c2d19b7109e851d4cce6cdb9df82868117 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893)
* 048818bd8e4548d20febf9308b83e42146806b6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898)
* 109e1d36469b537f997a7c844e57e23729a1af21 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665080497
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -433,8 +459,8 @@ public void operationComplete(ChannelFuture future) throws Exception {
@Override
public Object buildMessage() {
- return new AddCredit(
- inputChannel.getAndResetUnannouncedCredit(), inputChannel.getInputChannelId());
+ int credits = inputChannel.getAndResetUnannouncedCredit();
+ return credits > 0 ? new AddCredit(credits, inputChannel.getInputChannelId()) : null;
Review comment:
I will add a @Nullable annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01b2bc58b30a2a3730895f7c50ff59099bd273d2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c161aff32e5aed483ca0722e0504ec8493348947 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c49d1a8cee6485e8f367190f152e58960c901ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885)
* c161aff32e5aed483ca0722e0504ec8493348947 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307)
* 4b4b098f5eb40c7caf885c30b8c12aced99bbe05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662016156
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
+ }
+
// notifies the producer that this channel is ready to
// unblock from checkpoint and resume data consumption
partitionRequestClient.resumeConsumption(this);
}
+ private void onBlockingUpstream() {
+ if (initialCredit == 0) {
Review comment:
I think it does not slow down the load after resuming. It is just for the simplicity of handling unannounced credit. Maybe we have already announced the credits to the producer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661990825
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
The backlog can be 0. For example, after resumption from checkpoint, if there is no pending data in the subpartition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-876406179
Hi @pnowojski , I have split the last commit into smaller ones and updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r663119956
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
Can we measure how many those empty buffers are being sent? Is this an issue of 0.1% more messages or 50%? If it's hard to say or can vary, would it be difficult/would it complicate the code to send the empty buffers only if `#exclusiveBuffers == 0` to make sure that there is no performance regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87c4d9e67b205d7ca2fedf25a5a59402500de2ce Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623)
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665829387
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -315,6 +326,17 @@ BufferAndBacklog pollBuffer() {
if (buffer.readableBytes() > 0) {
break;
}
+
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
Let's maybe focus on the 3rd case first and we assume that the exclusive credit is 0.
1. There are only one data buffer in the queue.
2. Flush triggered.
3. All data of the first buffer is committed but the buffer is still not finished.
4. All data of the buffer is consumed by pollBuffer and the available credit becomes 0.
5. The first buffer is finished, the second event is added and the data available notification is triggered.
6. The upstream announces backlog to the downstream to request a credit.
7. The upstream receives available credit and start to pollBuffer.
8. Skip the first empty buffer and send the second event.
9. The downstream receive the event but the event does not consume any credit.
Do you mean we should change the current logic and release the floating buffer for event in some cases (including reduce the available credit by 1 at the upstream, currently the available credit is not decreased for event)? If there are multiple empty buffers, should we just skip the first one or should we skip all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r425078522
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -163,8 +172,15 @@ boolean hasBuffersAvailable() {
return subpartitionView.isAvailable(Integer.MAX_VALUE);
}
- @Override
- public BufferAndAvailability getNextBuffer() throws IOException {
+ private AddBacklogMessage getAddBacklogMessage() {
+ int backlog = subpartitionView.getAndResetUnannouncedBacklog();
+ if (backlog > 0) {
+ return new AddBacklogMessage(receiverId, backlog, false);
+ }
+ return null;
Review comment:
I guess we should not expect `null` return here. As long as the code path enters `getAddBacklogMessage`, then we should guarantee that the respective backlog should be more than 0.
Maybe add assert backlog instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767)
* ae312385b57ca67cdb73ee96be38c4edbe56478d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774)
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
}, {
"hash" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208",
"triggerID" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4b35b61d395564b24dd98896b785e22c6e3ab30 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-877983397
Hi @pnowojski , I have updated the PR with a fixup commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
}, {
"hash" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208",
"triggerID" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01b2bc58b30a2a3730895f7c50ff59099bd273d2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184)
* d4b35b61d395564b24dd98896b785e22c6e3ab30 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r664651808
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NetworkBufferAllocator.java
##########
@@ -69,6 +69,9 @@ Buffer allocatePooledNetworkBuffer(InputChannelID receiverId) {
* @return The un-pooled network buffer.
*/
Buffer allocateUnPooledNetworkBuffer(int size, Buffer.DataType dataType) {
+ if (size <= 0) {
+ return null;
+ }
Review comment:
1. `@Nullable`
2. Do we really need to support `null` here? Can not we return empty `Buffer`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
But how can this floating credit be assigned to this blocked `RemoteInputChannel`? Wouldn't it cause the same deadlock, when floating buffers are assigned to blocked channels and job/task can not make any progress?
It sounds like maybe this should have been handled sooner when trying to increase `unannouncedCredit`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -315,6 +326,17 @@ BufferAndBacklog pollBuffer() {
if (buffer.readableBytes() > 0) {
break;
}
+
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
Instead of this check here, can not we add similar check outside of the `while (...)` loop? For example replace:
```
if (buffer == null) {
return null;
}
```
with something like:
```
if (buffer == null) {
if (buffersPerChannel == 0) {
return EMPTY_BUFFER;
}
else {
return null;
}
}
```
?
That way, we would avoid sending empty buffer if there are still more buffers in the backlog that are already enqueued?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
Secondly, `getRemainingBacklog()` is a very costly operation (additional synchronisation) that I think could have been avoided:
1. Backlog can go up only as a result of `org.apache.flink.runtime.io.network.netty.PartitionRequestQueue#notifyReaderNonEmpty(reader)`.
2. Backlog can go down, only as a result of polling the data from the `reader`.
3. So instead of using thread safe `reader.getRemainingBacklog()`, we could re-use existing synchronisation in 1. and 2., to maintain `remainingBacklog` in the netty thread (in the `PartitionRequestQueue`.
But it would be even better to completely avoid this check (my comment above).
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -340,7 +355,15 @@ private void decodeBufferOrEvent(
RemoteInputChannel inputChannel, NettyMessage.BufferResponse bufferOrEvent)
throws Throwable {
if (bufferOrEvent.isBuffer() && bufferOrEvent.bufferSize == 0) {
- inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ try {
+ inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ } finally {
+ // recycle the empty buffer directly
+ Buffer buffer = bufferOrEvent.getBuffer();
+ if (buffer != null) {
+ buffer.recycleBuffer();
Review comment:
What do you mean by that @wsry ? That previously `bufferOrEevnt.getBuffer()` was always `null`?
If so why do we need to keep suport for sending both empty buffers or null buffer?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
Have you tested this @wsry ? After all it seems like if reader is available, it should have `backlog > 0`, shouldn't it?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -433,8 +459,8 @@ public void operationComplete(ChannelFuture future) throws Exception {
@Override
public Object buildMessage() {
- return new AddCredit(
- inputChannel.getAndResetUnannouncedCredit(), inputChannel.getInputChannelId());
+ int credits = inputChannel.getAndResetUnannouncedCredit();
+ return credits > 0 ? new AddCredit(credits, inputChannel.getInputChannelId()) : null;
Review comment:
Why is this an issue? Is this an independent optimisation or is it relate with the other parts of the PR?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -468,6 +485,11 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
return;
}
+ if (buffer.getDataType().isBlockingUpstream()) {
+ onBlockingUpstream();
+ checkArgument(backlog == 0, "Illegal number of backlog.");
Review comment:
add the `backlog` value to the error message?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -433,8 +459,8 @@ public void operationComplete(ChannelFuture future) throws Exception {
@Override
public Object buildMessage() {
- return new AddCredit(
- inputChannel.getAndResetUnannouncedCredit(), inputChannel.getInputChannelId());
+ int credits = inputChannel.getAndResetUnannouncedCredit();
+ return credits > 0 ? new AddCredit(credits, inputChannel.getInputChannelId()) : null;
Review comment:
Secondly, return type of the `buildMessage()` is not annotated `@Nullable`, so if we need this code for correctness we need to add this annotation (but it would be better to avoid `null` here)
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -517,19 +539,20 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
public int getBuffersInBacklog() {
- if (flushRequested || isFinished) {
- return buffersInBacklog;
- } else {
- return Math.max(buffersInBacklog - 1, 0);
+ synchronized (buffers) {
Review comment:
`pollBuffer()` would be acquiring the lock twice, wouldn't it? If you really need to make this method `public` you should keep `private int getBuffersInBacklogUnsafe()` without any synchronisation.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -91,10 +91,14 @@ public BufferAndBacklog getNextBuffer() throws IOException {
updateStatistics(current);
- // We simply assume all the data are non-events for batch jobs to avoid pre-fetching the
- // next header
- Buffer.DataType nextDataType =
- numDataAndEventBuffers > 0 ? Buffer.DataType.DATA_BUFFER : Buffer.DataType.NONE;
+ // We simply assume all the data except for the last one (EndOfPartitionEvent)
+ // are non-events for batch jobs to avoid pre-fetching the next header
+ Buffer.DataType nextDataType = Buffer.DataType.NONE;
+ if (numDataBuffers > 0) {
+ nextDataType = Buffer.DataType.DATA_BUFFER;
+ } else if (numDataAndEventBuffers > 0) {
+ nextDataType = Buffer.DataType.EVENT_BUFFER;
+ }
Review comment:
But what would be a problem with requesting for a credit for the `EndOfPartitionEvent`? In other words, what's wrong with doing it as it was done previously: always returning `DATA_BUFFER` or `NONE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665225932
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
Maybe we can reuse the return value of is available. Instead of just return a bool flag, we may also return the backlog. I will give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ed54d10e01403ccbe4478ad086d4859f6f511cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472)
* edabda8971fb299b278a0bd0b42c2dca82c8a6a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca6f75c37da358874cc38d7998bce5c4445feff5 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162162353) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb4c607a5c4780729143d458b1c7633adcba59bf Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae90bc7d6d3753da3e9bbadcc99c80a152801e43 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8b233f483d45b8901cc28770be9da71a39929ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500)
* 3f89d29a4cee4917ff8087e16ab35c5d1274220c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662778055
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
> appending data and finish buffer is not an atomic operation.
It is exactly what I want to emphasize. As I understand, we need the empty buffer only because `appending data and finish buffer is not an atomic operation.` which happens because BufferBuilder has a gap between `commit` and `finish`. So I propose to rewrite BufferBuilder in such a way that if it commits the current state and size == capacity it finishes it immediately(so there is no explicit finish call needed). These changes allow us to avoid all logic with an empty buffer which I think pretty untransparent.
One more time, my proposal:
- Rewriting the `BufferBuilder` in such a way that it will be impossible to have the empty finished buffer(it just requires removing the gap between the last commit and finish).
- Don't send the empty buffer(after changes described above there won't be any empty buffers)
@wsry WDYT?
@pnowojski What is your opinion, is it safe to finish BufferBuilder immediately when it becomes full? I mean not to wait for call explicit `finish` but finish in the `commit` if it is full?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665084877
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -517,19 +539,20 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
public int getBuffersInBacklog() {
- if (flushRequested || isFinished) {
- return buffersInBacklog;
- } else {
- return Math.max(buffersInBacklog - 1, 0);
+ synchronized (buffers) {
Review comment:
I will add a private int getBuffersInBacklogUnsafe() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424902024
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -418,8 +437,8 @@ public Buffer requestBuffer() {
*
* @param backlog The number of unsent buffers in the producer's sub partition.
*/
- void onSenderBacklog(int backlog) throws IOException {
- notifyBufferAvailable(bufferManager.requestFloatingBuffers(backlog + initialCredit));
+ public void onSenderBacklog(int backlog) throws IOException {
Review comment:
nit: also adjust the javadoc of this method accordingly.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -327,6 +322,14 @@ public void notifyBufferAvailable(int numAvailableBuffers) {
}
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
make it only private method inside `RemoteInputChannel`, because it is never used outside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665082678
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NetworkBufferAllocator.java
##########
@@ -69,6 +69,9 @@ Buffer allocatePooledNetworkBuffer(InputChannelID receiverId) {
* @return The un-pooled network buffer.
*/
Buffer allocateUnPooledNetworkBuffer(int size, Buffer.DataType dataType) {
+ if (size <= 0) {
+ return null;
+ }
Review comment:
This method is used to allocate unpooled buffer for event, the size must be positive. I will replace it with a argument check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452ba169e20663de86d84ab6ea938bdf772be482 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161590525) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115)
* 929403a9ae1b734c4e72a4585862f994d8c1f5e9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161611411) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87c4d9e67b205d7ca2fedf25a5a59402500de2ce Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb631b77700e2f05dcfdd50cd50cdea35e7cfb13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047)
* 826c1aaddfc41d54a5b3f52be9feb73a0b193ebc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662816858
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
Does that mean that the BufferBuilder can not finish a partial buffer, for example the last piece of data of the batch execution mode? Besides, there is another case which may lead to the empty buffer: in PipelinedApproximateSubpartition, if a partial record takes more than one buffer in the queue, those partial data will be dropped when recovering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905)
* 028f2185c0bb15c542006065550d04f69b0b06bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665059027
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -91,10 +91,14 @@ public BufferAndBacklog getNextBuffer() throws IOException {
updateStatistics(current);
- // We simply assume all the data are non-events for batch jobs to avoid pre-fetching the
- // next header
- Buffer.DataType nextDataType =
- numDataAndEventBuffers > 0 ? Buffer.DataType.DATA_BUFFER : Buffer.DataType.NONE;
+ // We simply assume all the data except for the last one (EndOfPartitionEvent)
+ // are non-events for batch jobs to avoid pre-fetching the next header
+ Buffer.DataType nextDataType = Buffer.DataType.NONE;
+ if (numDataBuffers > 0) {
+ nextDataType = Buffer.DataType.DATA_BUFFER;
+ } else if (numDataAndEventBuffers > 0) {
+ nextDataType = Buffer.DataType.EVENT_BUFFER;
+ }
Review comment:
I think this is just an optimization. Without this change, the backlog announced to the downstream does not include the event and EVENT_BUFFER and DATA_BUFFER are not distinguished, this means the event buffer also need a credit to send. If there is no exclusive buffer, no enough buffer will be allocated for the event, because we only announce the data buffer backlog to the downstream. As a result, some tests will hang for there is no credit for the event buffer. To solve this dead lock, there are two simple ways:
1. Announce both data buffer and event buffer backlog to the downstream, this lead to allocate more buffers than needed, these buffers will be released when the EOF is received at the downstream task.
2. Distinguish EVENT_BUFFER and DATA_BUFFER just like what is doing now.
These choices are both acceptable to me. I chose the second one because EVENT_BUFFER and DATA_BUFFER are distinguished at the downstream task and we can allocate one less buffer.
Both of the choices need to do some change to BoundedBlockingSubpartitionDirectTransferReader. Which one do you prefer? I think both are acceptable for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 159596e8f11586211a5f54e6aaae2c9fdee532a2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804)
* 1814aee57851711782cc2d922c4ef8f118a74c13 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r664997218
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -340,7 +355,15 @@ private void decodeBufferOrEvent(
RemoteInputChannel inputChannel, NettyMessage.BufferResponse bufferOrEvent)
throws Throwable {
if (bufferOrEvent.isBuffer() && bufferOrEvent.bufferSize == 0) {
- inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ try {
+ inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ } finally {
+ // recycle the empty buffer directly
+ Buffer buffer = bufferOrEvent.getBuffer();
+ if (buffer != null) {
+ buffer.recycleBuffer();
Review comment:
Yes, you are right. Previously, ```bufferOrEevnt.getBuffer()``` was always ```null```. And currently, it should be never null. So we do not need to support null buffer now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666286396
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
Yes you are right. `reader.isAvailable()` is already being called. I'm not sure why I've missed that.
`reader.getAvailabilityAndBacklog();` should work fine :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665933067
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
NetworkSequenceViewReader#isAvailable() has already been called by PartitionRequestQueue#enqueueAvailableReader:
```
private void enqueueAvailableReader(final NetworkSequenceViewReader reader) throws Exception {
if (reader.isRegisteredAsAvailable() || !reader.isAvailable()) {
return;
}
......
}
```
I think we can change it to:
```
private void enqueueAvailableReader(final NetworkSequenceViewReader reader) throws Exception {
if (reader.isRegisteredAsAvailable()) {
return;
}
ResultSubpartitionView.AvailabilityWithBacklog availabilityWithBacklog =
reader.getAvailabilityAndBacklog();
if (!availabilityWithBacklog.isAvailable()) {
int backlog = availabilityWithBacklog.getBacklog();
if (backlog > 0 && reader.needAnnounceBacklog()) {
announceBacklog(reader, backlog);
}
return;
}
......
}
```
What do you think?
> After all even in your version I think there can be a race condition where PartitionRequestQueue is notified reader is non empty, you check the getRemainingBacklog() and send the BacklogAnnouncement message, while before it gets processed by the receiver, some buffer is polled from this reader and backlog goes down to 0. And as a result, receiver assigns as a credit to a sender that doesn't have any data anymore?
I think there is no such problem. One reason is that ```getRemainingBacklog()``` is in netty thread and we can guarantee the order, the downstream will always process the ```BacklogAnnouncement``` before the buffer. The other reason is that we only announce credit when there is no credit available which means if there is credit available, only buffer with backlog will be sent, if there is no credit available, only ```BacklogAnnouncement``` will be send, buffer will be always wait for credit. It is also not a problem if we announce the same credit twice because we can guarantee the process order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662010444
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -215,9 +221,15 @@ public void recycle(MemorySegment segment) {
}
void releaseFloatingBuffers() {
+ Queue<Buffer> buffers;
synchronized (bufferQueue) {
numRequiredBuffers = 0;
- bufferQueue.releaseFloatingBuffers();
+ buffers = bufferQueue.clearFloatingBuffers();
+ }
+
+ // recycle all buffers out of the synchronization block to avoid dead lock
Review comment:
Each RemoteInputChannel has its own BufferManager and bufferQueue, floating buffers recycled by one RemoteInputChannel can be assigned to other RemoteInputChannels directly and the buffer assignment also need to sync the bufferQueue object. Besides, different RemoteInputChannels may recycle buffers simultaneously, which means we may need to lock two bufferQueue objects of different RemoteInputChannels simultaneously in the reverse order. I already encountered this dead lock when running test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662012667
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -265,6 +265,13 @@ public void run() {
channelInfo,
channelStatePersister,
next.getSequenceNumber());
+
+ // ignore the empty buffer directly
+ if (buffer.readableBytes() == 0) {
Review comment:
After this change, we can poll an empty buffer from the Subpartition of the upstream task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666756241
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactory.java
##########
@@ -156,15 +155,16 @@ public ResultPartition create(
bufferCompressor,
bufferPoolFactory);
- BiFunction<Integer, PipelinedResultPartition, PipelinedSubpartition> factory;
- if (type == ResultPartitionType.PIPELINED_APPROXIMATE) {
- factory = PipelinedApproximateSubpartition::new;
- } else {
- factory = PipelinedSubpartition::new;
- }
-
for (int i = 0; i < subpartitions.length; i++) {
- subpartitions[i] = factory.apply(i, pipelinedPartition);
+ if (type == ResultPartitionType.PIPELINED_APPROXIMATE) {
+ subpartitions[i] =
+ new PipelinedApproximateSubpartition(
+ i, networkBuffersPerChannel, pipelinedPartition);
Review comment:
rename `networkBuffersPerChannel` -> `configuredNetworkBuffersPerChannel` to better reflect that we are actually overriding this value for the output?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -112,8 +120,11 @@
// ------------------------------------------------------------------------
- PipelinedSubpartition(int index, ResultPartition parent) {
+ PipelinedSubpartition(int index, int buffersPerChannel, ResultPartition parent) {
super(index, parent);
+
+ checkArgument(buffersPerChannel >= 0, "Buffers per channel must be non-negative.");
+ this.buffersPerChannel = buffersPerChannel;
Review comment:
Can we rename this property to something like `receiverExclusiveBuffersPerChannel`? Because actually this is not the number of `buffersPerChannel` for the sender.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 826c1aaddfc41d54a5b3f52be9feb73a0b193ebc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084)
* 01b2bc58b30a2a3730895f7c50ff59099bd273d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfdb8bfa05b783479697bd3aa3de3fac2628482 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077)
* 66de3ded5740c19aab5984c8650b5d6a355ed6e8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
* 8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307)
* 4b4b098f5eb40c7caf885c30b8c12aced99bbe05 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1814aee57851711782cc2d922c4ef8f118a74c13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878)
* f28812c2d19b7109e851d4cce6cdb9df82868117 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893)
* 048818bd8e4548d20febf9308b83e42146806b6e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665068048
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
This because RemoteInputChannel#notifyBufferAvailable which increases ```unannouncedCredit``` and floating buffer assignment is not an atomic operation. There is a possibility:
1. the floating buffer is assigned;
2. the floating buffer is released because of receiving an event which blocks the channel;
3. the notifyBufferAvailable is called and the unannouncedCredit is increased.
Do you mean we should make RemoteInputChannel#notifyBufferAvailable and floating buffer assignment an atomic operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661557618
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -91,10 +91,14 @@ public BufferAndBacklog getNextBuffer() throws IOException {
updateStatistics(current);
- // We simply assume all the data are non-events for batch jobs to avoid pre-fetching the
- // next header
- Buffer.DataType nextDataType =
- numDataAndEventBuffers > 0 ? Buffer.DataType.DATA_BUFFER : Buffer.DataType.NONE;
+ // We simply assume all the data except for the last one (EndOfPartitionEvent)
+ // are non-events for batch jobs to avoid pre-fetching the next header
+ Buffer.DataType nextDataType = Buffer.DataType.NONE;
+ if (numDataBuffers > 0) {
+ nextDataType = Buffer.DataType.DATA_BUFFER;
+ } else if (numDataAndEventBuffers > 0) {
+ nextDataType = Buffer.DataType.EVENT_BUFFER;
+ }
Review comment:
Is it also a bug? Or why do we distinguish EVENT_BUFFER and DATA_BUFFER now?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -130,11 +136,11 @@ private boolean shouldContinueRequest(BufferPool bufferPool) {
/** Requests exclusive buffers from the provider. */
void requestExclusiveBuffers(int numExclusiveBuffers) throws IOException {
- Collection<MemorySegment> segments = globalPool.requestMemorySegments(numExclusiveBuffers);
- checkArgument(
- !segments.isEmpty(),
- "The number of exclusive buffers per channel should be larger than 0.");
+ if (numExclusiveBuffers <= 0) {
Review comment:
As I understand, the negative number is still illegal. So maybe it makes sense to add checkArgument for `numExclusiveBuffers < 0`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -110,7 +114,12 @@ private void updateStatistics(Buffer buffer) {
public boolean isAvailable(int numCreditsAvailable) {
// We simply assume there are no events except EndOfPartitionEvent for bath jobs,
// then it has no essential effect to ignore the judgement of next event buffer.
- return numCreditsAvailable > 0 && numDataAndEventBuffers > 0;
+ return (numCreditsAvailable > 0 || numDataBuffers == 0) && numDataAndEventBuffers > 0;
Review comment:
Does this mean that we don't need the credit for sending the event?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -100,8 +106,19 @@ public void addCredit(int creditDeltas) {
numCreditsAvailable += creditDeltas;
}
+ @Override
+ public boolean needAnnounceBacklog() {
+ return initialCredit == 0 && numCreditsAvailable == 0;
+ }
+
@Override
public void resumeConsumption() {
+ if (initialCredit == 0) {
+ // reset available credit if no exclusive buffer is available at the
+ // consumer side for all floating buffers must have been released
+ numCreditsAvailable = 0;
Review comment:
Do we do it because we know that all floating buffers would be released before the checkpoint when `initialCredit == 0`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
as I understand, the backlog can not be less or equal to 0 here. So maybe convert it to checkArgument? Or I missed something?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -340,7 +355,15 @@ private void decodeBufferOrEvent(
RemoteInputChannel inputChannel, NettyMessage.BufferResponse bufferOrEvent)
throws Throwable {
if (bufferOrEvent.isBuffer() && bufferOrEvent.bufferSize == 0) {
- inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ try {
+ inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ } finally {
+ // recycle the empty buffer directly
+ Buffer buffer = bufferOrEvent.getBuffer();
+ if (buffer != null) {
+ buffer.recycleBuffer();
Review comment:
Before these changes where this buffer was recycled? or was it the bug?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
I don't really get the idea of these changes.
Let's suppose PipelindedSubpartition#buffers contain several but the first one is empty and finished already.
How it was before the changes:
- PartitionRequestQueue requests the buffer.
- in any case, PipelindedSubpartition#pollBuffer returns a buffer(it skip the first one because it is empty and finished but it returns the buffer from the next consumer)
- PartitionRequestQueue continues to request from this Reader until PipelindedSubpartition#buffers is not empty.
After the changes:
- PartitionRequestQueue requests the buffer.
- PipelindedSubpartition#pollBuffer returns null.
- PartitionRequestQueue remove this reader from the available readers
- Other buffers from PipelindedSubpartition#buffers will be sent only when timeout happens and this reader is added to the available list again.
What the point to delay the sending if we already have credit for it and we have the buffer ready to be sent?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -513,19 +514,20 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
public int getBuffersInBacklog() {
- if (flushRequested || isFinished) {
- return buffersInBacklog;
- } else {
- return Math.max(buffersInBacklog - 1, 0);
+ synchronized (buffers) {
+ if (isBlocked || buffers.isEmpty()) {
+ return 0;
+ }
+
+ if (flushRequested
+ || isFinished
+ || !checkNotNull(buffers.peekLast()).getBufferConsumer().isBuffer()) {
Review comment:
So dangerous, why you so sure that buffers contain at least one object?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -265,6 +265,13 @@ public void run() {
channelInfo,
channelStatePersister,
next.getSequenceNumber());
+
+ // ignore the empty buffer directly
+ if (buffer.readableBytes() == 0) {
+ buffer.recycleBuffer();
Review comment:
The same question that earlier - is this bug? or where did we recycle the buffer before this changes?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -83,8 +84,13 @@ public BufferManager(
// ------------------------------------------------------------------------
@Nullable
- Buffer requestBuffer() {
+ Buffer requestBuffer(int initialCredit) {
synchronized (bufferQueue) {
+ // decrease the number of buffers require to avoid the possibility of
+ // allocating more than required buffers after the buffer is taken
+ if (initialCredit == 0) {
+ --numRequiredBuffers;
Review comment:
I don't understand why `initialCredit == 0` should be handled differently here. Even if `initialCredit == 1` and the Buffer is requested we should decrease this value, or am I wrong?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
Do we need to do so because we released all buffers in onBlockingUpstream? If so can we hold this code in one place, ex. to move it into onBlockingUpstream?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -83,8 +84,13 @@ public BufferManager(
// ------------------------------------------------------------------------
@Nullable
- Buffer requestBuffer() {
+ Buffer requestBuffer(int initialCredit) {
Review comment:
As I understand, initialCredit is an unchangeable value, and BufferManager and AvailableBufferQueue know this value so maybe it is better to avoid this parameter?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
+ }
+
// notifies the producer that this channel is ready to
// unblock from checkpoint and resume data consumption
partitionRequestClient.resumeConsumption(this);
}
+ private void onBlockingUpstream() {
+ if (initialCredit == 0) {
Review comment:
Why can not we do the same thing for any number of credits not only for `initialCredit == 0`? Or does it slow down the load after resuming?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -215,9 +221,15 @@ public void recycle(MemorySegment segment) {
}
void releaseFloatingBuffers() {
+ Queue<Buffer> buffers;
synchronized (bufferQueue) {
numRequiredBuffers = 0;
- bufferQueue.releaseFloatingBuffers();
+ buffers = bufferQueue.clearFloatingBuffers();
+ }
+
+ // recycle all buffers out of the synchronization block to avoid dead lock
Review comment:
Can you explain what kind of deadlock can happen? Between LocalBufferPool and BufferManager?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -265,6 +265,13 @@ public void run() {
channelInfo,
channelStatePersister,
next.getSequenceNumber());
+
+ // ignore the empty buffer directly
+ if (buffer.readableBytes() == 0) {
Review comment:
How is it even possible to get an empty buffer? Who is sending it?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -513,19 +514,20 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
public int getBuffersInBacklog() {
- if (flushRequested || isFinished) {
- return buffersInBacklog;
- } else {
- return Math.max(buffersInBacklog - 1, 0);
+ synchronized (buffers) {
+ if (isBlocked || buffers.isEmpty()) {
Review comment:
It seems that it is the wrong place for such condition. Logically, even if the subpartition is blocked it still has the buffers. But as I understand, specifically for the case where 'initialCredit == 0' it should return 0. So it needs to think how does it do better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666626886
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -312,6 +323,16 @@ BufferAndBacklog pollBuffer() {
decreaseBuffersInBacklogUnsafe(bufferConsumer.isBuffer());
}
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
> One thing to add (unless we are not doing it already) would be to use this backlog information, to maybe release floating buffers if backlog dropped to 0?
Currently, we are not doing that. Actually, I think it is a little complicated to do so. Because we need to keep consistency between the sender side available credit and the receiver side floating buffers. If we just release the floating buffers at the receiver side, if the sender side available credit is not reset, then there is may data sent out without buffers at receiver side to receive them. If we also reset the available credit at the sender side when the backlog is 0, there is a possibility that some AddCredit messages are on the way and we are not resetting this part. Maybe one way is to not sending any data out after sending a buffer with 0 backlog at sender side, then the receivers clear all floating credits and send a reset message to the senders. Then the senders reset all available credits. This process is similar to the channel blocking and resumption. I think this is a little complicated and can incur extra overhead.
What do you think? Or is there any simple way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661993643
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -110,7 +114,12 @@ private void updateStatistics(Buffer buffer) {
public boolean isAvailable(int numCreditsAvailable) {
// We simply assume there are no events except EndOfPartitionEvent for bath jobs,
// then it has no essential effect to ignore the judgement of next event buffer.
- return numCreditsAvailable > 0 && numDataAndEventBuffers > 0;
+ return (numCreditsAvailable > 0 || numDataBuffers == 0) && numDataAndEventBuffers > 0;
Review comment:
Yes, you are right. At the downstream task, no credit is needed when decoding an event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb4c607a5c4780729143d458b1c7633adcba59bf Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301)
* 0ed54d10e01403ccbe4478ad086d4859f6f511cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
* 8550965d808fe7b4d6ff2d48034612878937a579 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841)
* 7b6eb661923f59967a116e9074cf790fd694c578 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
}, {
"hash" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208",
"triggerID" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"triggerType" : "PUSH"
}, {
"hash" : "da81fde5fc9e110075cff4982048b7f7ee3a0d61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20264",
"triggerID" : "da81fde5fc9e110075cff4982048b7f7ee3a0d61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4b35b61d395564b24dd98896b785e22c6e3ab30 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208)
* da81fde5fc9e110075cff4982048b7f7ee3a0d61 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666761438
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -312,6 +323,16 @@ BufferAndBacklog pollBuffer() {
decreaseBuffersInBacklogUnsafe(bufferConsumer.isBuffer());
}
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
OK, thanks a lot. I will spend some time thinking if we can improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661992459
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -91,10 +91,14 @@ public BufferAndBacklog getNextBuffer() throws IOException {
updateStatistics(current);
- // We simply assume all the data are non-events for batch jobs to avoid pre-fetching the
- // next header
- Buffer.DataType nextDataType =
- numDataAndEventBuffers > 0 ? Buffer.DataType.DATA_BUFFER : Buffer.DataType.NONE;
+ // We simply assume all the data except for the last one (EndOfPartitionEvent)
+ // are non-events for batch jobs to avoid pre-fetching the next header
+ Buffer.DataType nextDataType = Buffer.DataType.NONE;
+ if (numDataBuffers > 0) {
+ nextDataType = Buffer.DataType.DATA_BUFFER;
+ } else if (numDataAndEventBuffers > 0) {
+ nextDataType = Buffer.DataType.EVENT_BUFFER;
+ }
Review comment:
An EVENT_BUFFER does not need any credit to be sent. The BoundedBlockingSubpartitionDirectTransferReader Implementation does not distinguish EVENT_BUFFER and DATA_BUFFER for simplicity. However, after this change, we need to distinguish EVENT_BUFFER and DATA_BUFFER because we do not want to allocate any credit at downstream for an EVENT_BUFFER.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c49d1a8cee6485e8f367190f152e58960c901ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-877007008
> Thanks @wsry for all of the changes and your work with addressing the feedback. I think this looks almost good to me % a couple of renames and we need to update the config option descriptions to describe the actual state that there never can be 0 buffers per channel on the sender side. Currently the variable naming in the code and docs/description are misleading in this regard.
@pnowojski Thanks very much for the review and feedback. I will update the PR soon accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665830690
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -91,10 +91,14 @@ public BufferAndBacklog getNextBuffer() throws IOException {
updateStatistics(current);
- // We simply assume all the data are non-events for batch jobs to avoid pre-fetching the
- // next header
- Buffer.DataType nextDataType =
- numDataAndEventBuffers > 0 ? Buffer.DataType.DATA_BUFFER : Buffer.DataType.NONE;
+ // We simply assume all the data except for the last one (EndOfPartitionEvent)
+ // are non-events for batch jobs to avoid pre-fetching the next header
+ Buffer.DataType nextDataType = Buffer.DataType.NONE;
+ if (numDataBuffers > 0) {
+ nextDataType = Buffer.DataType.DATA_BUFFER;
+ } else if (numDataAndEventBuffers > 0) {
+ nextDataType = Buffer.DataType.EVENT_BUFFER;
+ }
Review comment:
After rethink about it, the first choice can support more events type in the future and the second choice make the assumption that we only have one event at the end of the data. Maybe the first choice is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662020472
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
Doing this in the onBlockingUpstream method can guarantee that after resumeConsumption the unannouncedCredit is in a clean state. Because the unannouncedCredit may get increased after that if there is any new available floating credit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r664999767
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -340,7 +355,15 @@ private void decodeBufferOrEvent(
RemoteInputChannel inputChannel, NettyMessage.BufferResponse bufferOrEvent)
throws Throwable {
if (bufferOrEvent.isBuffer() && bufferOrEvent.bufferSize == 0) {
- inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ try {
+ inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ } finally {
+ // recycle the empty buffer directly
+ Buffer buffer = bufferOrEvent.getBuffer();
+ if (buffer != null) {
+ buffer.recycleBuffer();
Review comment:
I think I can keep this logic unchanged and release the buffer in decoder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb631b77700e2f05dcfdd50cd50cdea35e7cfb13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 028f2185c0bb15c542006065550d04f69b0b06bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955)
* fb631b77700e2f05dcfdd50cd50cdea35e7cfb13 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r667798432
##########
File path: docs/layouts/shortcodes/generated/all_taskmanager_network_section.html
##########
@@ -30,7 +30,7 @@
<td><h5>taskmanager.network.memory.buffers-per-channel</h5></td>
<td style="word-wrap: break-word;">2</td>
<td>Integer</td>
- <td>Number of exclusive network buffers to use for each outgoing/incoming channel (subpartition/inputchannel) in the credit-based flow control model. It should be configured at least 2 for good performance. 1 buffer is for receiving in-flight data in the subpartition and 1 buffer is for parallel serialization.</td>
+ <td>Number of exclusive network buffers to use for each outgoing/incoming channel (subpartition/input channel) in the credit-based flow control model. It should be configured at least 2 for good performance. 1 buffer is for receiving in-flight data in the subpartition and 1 buffer is for parallel serialization. The minimum valid value can be configured is 0 and when 0 is configured, the exclusive network buffers used per downstream incoming channel will be 0, but for each upstream outgoing channel, max(1, configured value) will be used which means that at least one buffer is needed and this behavior is for performance. If it's not guaranteed that each outgoing channel can get at least one buffer, more partial buffers with little data will be outputted to network/disk and recycled to be used by other channels which can not get a buffer for data caching.</td>
Review comment:
Maybe a minor reword to:
> The minimum valid value that can be configured is 0. When 0 buffers-per-channel is configured, the exclusive network buffers used per downstream incoming channel will be 0, but for each upstream outgoing channel, max(1, configured value) will be used. In other words we ensure that, for performance reasons, there is at least one buffer per outgoing channel regardless of the configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422863695
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -70,6 +70,10 @@
@GuardedBy("buffers")
private int buffersInBacklog;
+ /** The number of non-event buffers to be announced to the downstream. */
+ @GuardedBy("buffers")
+ private int unannouncedBacklog;
Review comment:
The previous `buffersInBacklog` variable should be replaced by this new variable, to avoid maintaining two variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c161aff32e5aed483ca0722e0504ec8493348947 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767)
* 159596e8f11586211a5f54e6aaae2c9fdee532a2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b4b098f5eb40c7caf885c30b8c12aced99bbe05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310)
* 87c4d9e67b205d7ca2fedf25a5a59402500de2ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59b651c070adcca2b7e4e4a78e6b10411429c589 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168)
* e033307ba22ee660cd6c39063896500075b60671 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59b651c070adcca2b7e4e4a78e6b10411429c589 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59b651c070adcca2b7e4e4a78e6b10411429c589 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168)
* e033307ba22ee660cd6c39063896500075b60671 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9963994d6a37e8c1721d31519ac7346e25922248 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147)
* 5682e0256634e2ce1a38ca132cdaaddc79ee71c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9963994d6a37e8c1721d31519ac7346e25922248 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f89d29a4cee4917ff8087e16ab35c5d1274220c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674)
* 7dfdb8bfa05b783479697bd3aa3de3fac2628482 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae312385b57ca67cdb73ee96be38c4edbe56478d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774)
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662004311
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -83,8 +84,13 @@ public BufferManager(
// ------------------------------------------------------------------------
@Nullable
- Buffer requestBuffer() {
+ Buffer requestBuffer(int initialCredit) {
synchronized (bufferQueue) {
+ // decrease the number of buffers require to avoid the possibility of
+ // allocating more than required buffers after the buffer is taken
+ if (initialCredit == 0) {
+ --numRequiredBuffers;
Review comment:
You are right, we should always decrease this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r425079339
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -94,13 +99,22 @@ public void requestSubpartitionView(
}
@Override
- public void addCredit(int creditDeltas) {
+ public void addCredit(int creditDeltas) throws Exception {
numCreditsAvailable += creditDeltas;
+ requestQueue.enqueueAvailableReader(this, this::isAvailable);
+ }
+
+ @Override
+ public boolean shouldAnnounceBacklog() {
+ return !withoutExclusiveCredits && numCreditsAvailable == 0 && subpartitionView.isAvailable(Integer.MAX_VALUE);
}
@Override
- public void resumeConsumption() {
+ public void resumeConsumption(int availableCredit, boolean hasUnfulfilledBacklog) throws Exception {
Review comment:
nit: availableCredit -> availableCredits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11877:
URL: https://github.com/apache/flink/pull/11877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 826c1aaddfc41d54a5b3f52be9feb73a0b193ebc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb631b77700e2f05dcfdd50cd50cdea35e7cfb13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047)
* 826c1aaddfc41d54a5b3f52be9feb73a0b193ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b6eb661923f59967a116e9074cf790fd694c578 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863)
* 2c49d1a8cee6485e8f367190f152e58960c901ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662688120
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
If there is only one buffer in the buffer queue, after all data is read, the flushRequested flag will be turned off. Consider the following scenario (correct me if I am wrong):
1. There is an unfinished buffer in the queue and all data is read.
2. Then the buffer is finished but no new data is appended. Note appending data and finish buffer is not an atomic operation.
3. New buffer or event is added to the buffer queue.
4. When polling buffer, an empty buffer is at the head of the queue and we already allocate a credit for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665092084
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -315,6 +326,17 @@ BufferAndBacklog pollBuffer() {
if (buffer.readableBytes() > 0) {
break;
}
+
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
I was not suggesting that. I was suggesting to:
> we would avoid sending empty buffer if there are still more buffers in the backlog that are already enqueued
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 929403a9ae1b734c4e72a4585862f994d8c1f5e9 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161611411) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424866076
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -349,7 +373,7 @@ int unsynchronizedGetFloatingBuffersAvailable() {
*/
int addExclusiveBuffer(Buffer buffer, int numRequiredBuffers) {
exclusiveBuffers.add(buffer);
- if (getAvailableBufferSize() > numRequiredBuffers) {
+ if (numRequiredBuffers == 0) {
Review comment:
It should not be changed here. If the `numRequiredBuffers` is 0, `getAvailableBufferSize()` must be more than it. If `numRequiredBuffers` is `1` or something else, as long as the `getAvailableBufferSize()` is more than it, we also need to release a floating buffer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9963994d6a37e8c1721d31519ac7346e25922248 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147)
* 5682e0256634e2ce1a38ca132cdaaddc79ee71c0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 159596e8f11586211a5f54e6aaae2c9fdee532a2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804)
* 1814aee57851711782cc2d922c4ef8f118a74c13 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661999741
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -513,19 +514,20 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
public int getBuffersInBacklog() {
- if (flushRequested || isFinished) {
- return buffersInBacklog;
- } else {
- return Math.max(buffersInBacklog - 1, 0);
+ synchronized (buffers) {
+ if (isBlocked || buffers.isEmpty()) {
+ return 0;
+ }
+
+ if (flushRequested
+ || isFinished
+ || !checkNotNull(buffers.peekLast()).getBufferConsumer().isBuffer()) {
Review comment:
In the previous if block in this method, we have already filtered the case when the buffer queue is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665073463
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
I think there is one thing blocking us from reusing the backlog from PartitionRequestQueue#notifyReaderNonEmpty(reader): we have duplicated availability notifications. We may get outdated backlog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267)
* 379905b396355d37f565230cbcbee323dc626dce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275)
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae90bc7d6d3753da3e9bbadcc99c80a152801e43 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277)
* fb4c607a5c4780729143d458b1c7633adcba59bf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r663119956
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
How common is that case? Can we measure how many those empty buffers are being sent? Is this an issue of 0.1% more messages or 50%? If it's hard to say or can vary, would it be difficult/would it complicate the code to send the empty buffers only if `#exclusiveBuffers == 0` to make sure that there is no performance regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247)
* ae90bc7d6d3753da3e9bbadcc99c80a152801e43 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424911901
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -129,7 +132,6 @@ private boolean shouldContinueRequest(BufferPool bufferPool) {
*/
void requestExclusiveBuffers() throws IOException {
Collection<MemorySegment> segments = globalPool.requestMemorySegments();
- checkArgument(!segments.isEmpty(), "The number of exclusive buffers per channel should be larger than 0.");
Review comment:
Got it. So do you think we add the `if (initialCredit > 0)` before calling this method inside `RemoteInputChannel#assignExclusiveSegments`? Just for not necessary to `synchronized` below for empty segments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 929403a9ae1b734c4e72a4585862f994d8c1f5e9 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161611411) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 452ba169e20663de86d84ab6ea938bdf772be482 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161590525) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66de3ded5740c19aab5984c8650b5d6a355ed6e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081)
* 9963994d6a37e8c1721d31519ac7346e25922248 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662778055
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
> appending data and finish buffer is not an atomic operation.
It is exactly what I want to emphasize. As I understand, we need the empty buffer only because `appending data and finish buffer is not an atomic operation.` which happens because BufferBuilder has a gap between `commit` and `finish`. So I propose to rewrite BufferBuilder in such a way that if it commits the current state and size == capacity it finishes it immediately(so there is no explicit finish call needed). These changes allow us to avoid all logic with an empty buffer which I think pretty untransparent.
One more time, my proposal:
- Rewriting the `BufferBuilder` in such a way that it will be impossible to have the empty finished buffer(it just requires removing the gap between the last commit and finish).
- Don't send the empty buffer(after changes described above there won't be any empty buffers)
@wsry WDYT?
@pnowojski What is your opinion, is it safe to finish BufferBuilder immediately when it becomes full? I mean not to wait for call explicit `finish` but finish in the `commit` if it is full?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422884550
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java
##########
@@ -305,19 +311,18 @@ protected CheckpointBarrier parseCheckpointBarrierOrNull(Buffer buffer) throws I
/**
* A combination of a {@link Buffer} and a flag indicating availability of further buffers,
- * and the backlog length indicating how many non-event buffers are available in the
- * subpartition.
+ * and the backlog length indicating how many credits the subpartition.
*/
public static final class BufferAndAvailability {
private final Buffer buffer;
private final boolean moreAvailable;
- private final int buffersInBacklog;
+ private final int backlog;
- public BufferAndAvailability(Buffer buffer, boolean moreAvailable, int buffersInBacklog) {
- this.buffer = checkNotNull(buffer);
+ public BufferAndAvailability(@Nullable Buffer buffer, boolean moreAvailable, int backlog) {
Review comment:
We can also avoid introducing `nullable` buffer by this comment https://github.com/apache/flink/pull/11877/files#r422847423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 826c1aaddfc41d54a5b3f52be9feb73a0b193ebc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084)
* 01b2bc58b30a2a3730895f7c50ff59099bd273d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665222497
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -315,6 +326,17 @@ BufferAndBacklog pollBuffer() {
if (buffer.readableBytes() > 0) {
break;
}
+
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
I guess I did not fully understand the comment, could you please explain a bit more? From my understand, even there are multiple buffers in the queue and the first is empty, if we do not send the first empty buffer out, how could we guarantee the downstream tasks are not allocating too many buffers if the exclusive credit is 0? For example, if there is two buffers, the first one is empty and the second one is an event, we may already announce 1 backlog to the downstream task and if we send the event directly, dose that mean we can not release the credit already allocated? Correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618265825
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4609625eac16247f2d70d8c36c42b3e2dfec8768 (Thu Sep 23 18:01:49 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b4b098f5eb40c7caf885c30b8c12aced99bbe05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310)
* 87c4d9e67b205d7ca2fedf25a5a59402500de2ce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8b233f483d45b8901cc28770be9da71a39929ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
* 8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424860940
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -151,23 +150,43 @@ int requestFloatingBuffers(int numRequired) throws IOException {
return numRequestedBuffers;
}
- numRequiredBuffers = numRequired;
+ numRequiredBuffers += numRequired;
+ numRequestedBuffers = internalRequestFloatingBuffers(numRequiredBuffers);
+ numRequiredBuffers -= numRequestedBuffers;
+ }
+ return numRequestedBuffers;
+ }
- while (bufferQueue.getAvailableBufferSize() < numRequiredBuffers && !isWaitingForFloatingBuffers) {
- BufferPool bufferPool = inputChannel.inputGate.getBufferPool();
- Buffer buffer = bufferPool.requestBuffer();
- if (buffer != null) {
- bufferQueue.addFloatingBuffer(buffer);
- numRequestedBuffers++;
- } else if (bufferPool.addBufferListener(this)) {
- isWaitingForFloatingBuffers = true;
- break;
- }
+ private int internalRequestFloatingBuffers(int numBuffersToRequest) throws IOException {
+ assert Thread.holdsLock(bufferQueue);
+
+ int numRequestedBuffers = 0;
+ while (numRequestedBuffers < numBuffersToRequest && !isWaitingForFloatingBuffers) {
+ BufferPool bufferPool = inputChannel.inputGate.getBufferPool();
+ Buffer buffer = bufferPool.requestBuffer();
+ if (buffer != null) {
+ bufferQueue.addFloatingBuffer(buffer);
+ numRequestedBuffers++;
+ } else if (bufferPool.addBufferListener(this)) {
+ isWaitingForFloatingBuffers = true;
+ break;
}
}
return numRequestedBuffers;
}
+ public void unregisterBufferListenerAndReleaseFloatingBuffers() {
+ synchronized (bufferQueue) {
+ if (isWaitingForFloatingBuffers) {
+ inputChannel.inputGate.getBufferPool().removeBufferListener(this);
+ isWaitingForFloatingBuffers = false;
+ }
+
+ int bufferReleased = bufferQueue.releaseFloatingBuffers();
Review comment:
nit: bufferReleased -> numReleasedBuffers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735)
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767)
* ae312385b57ca67cdb73ee96be38c4edbe56478d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662016156
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
+ }
+
// notifies the producer that this channel is ready to
// unblock from checkpoint and resume data consumption
partitionRequestClient.resumeConsumption(this);
}
+ private void onBlockingUpstream() {
+ if (initialCredit == 0) {
Review comment:
We can also release the floating buffers if the initialCredit != 0. I think it does not slow down the load after resuming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 028f2185c0bb15c542006065550d04f69b0b06bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955)
* fb631b77700e2f05dcfdd50cd50cdea35e7cfb13 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248)
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248)
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267)
* 379905b396355d37f565230cbcbee323dc626dce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662020759
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -100,8 +106,19 @@ public void addCredit(int creditDeltas) {
numCreditsAvailable += creditDeltas;
}
+ @Override
+ public boolean needAnnounceBacklog() {
+ return initialCredit == 0 && numCreditsAvailable == 0;
+ }
+
@Override
public void resumeConsumption() {
+ if (initialCredit == 0) {
+ // reset available credit if no exclusive buffer is available at the
+ // consumer side for all floating buffers must have been released
+ numCreditsAvailable = 0;
Review comment:
Yes, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666752113
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -312,6 +323,16 @@ BufferAndBacklog pollBuffer() {
decreaseBuffersInBacklogUnsafe(bufferConsumer.isBuffer());
}
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
Ok, let's go with the current way for now, as with `buffersPerChannel == 0` check it's not that critical. But it would be nice if you could spend a little time thinking if we can improve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 028f2185c0bb15c542006065550d04f69b0b06bd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f89d29a4cee4917ff8087e16ab35c5d1274220c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
* 8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424863522
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -151,23 +149,42 @@ int requestFloatingBuffers(int numRequired) throws IOException {
return numRequestedBuffers;
}
- numRequiredBuffers = numRequired;
+ numRequiredBuffers += numRequired;
+ numRequestedBuffers = internalRequestFloatingBuffers(numRequiredBuffers);
+ numRequiredBuffers -= numRequestedBuffers;
+ }
+ return numRequestedBuffers;
+ }
- while (bufferQueue.getAvailableBufferSize() < numRequiredBuffers && !isWaitingForFloatingBuffers) {
- BufferPool bufferPool = inputChannel.inputGate.getBufferPool();
- Buffer buffer = bufferPool.requestBuffer();
- if (buffer != null) {
- bufferQueue.addFloatingBuffer(buffer);
- numRequestedBuffers++;
- } else if (bufferPool.addBufferListener(this)) {
- isWaitingForFloatingBuffers = true;
- break;
- }
+ private int internalRequestFloatingBuffers(int numBuffersToRequest) throws IOException {
+ assert Thread.holdsLock(bufferQueue);
+
+ int numRequestedBuffers = 0;
+ while (numRequestedBuffers < numBuffersToRequest && !isWaitingForFloatingBuffers) {
+ BufferPool bufferPool = inputChannel.inputGate.getBufferPool();
+ Buffer buffer = bufferPool.requestBuffer();
+ if (buffer != null) {
+ bufferQueue.addFloatingBuffer(buffer);
+ numRequestedBuffers++;
+ } else if (bufferPool.addBufferListener(this)) {
+ isWaitingForFloatingBuffers = true;
+ break;
}
}
return numRequestedBuffers;
}
+ public void unregisterBufferListenerAndReleaseFloatingBuffers() {
Review comment:
This method should be placed into the below section `Buffer recycle`.
I think it is better to integrate this method with existing `#releaseFloatingBuffers` to provide a general one, otherwise it might bring confusing to understand the difference among them, especially for the different handle of `numRequiredBuffers`, to make them seem customized logic.
The integration is as below
```
void releaseFloatingBuffers(boolean isTemporaryRelease) {
synchronized (bufferQueue) {
if (isWaitingForFloatingBuffers) {
inputChannel.inputGate.getBufferPool().removeBufferListener(this);
isWaitingForFloatingBuffers = false;
}
int numReleasedBuffers = bufferQueue.releaseFloatingBuffers();
if (isTemporaryRelease) {
numRequiredBuffers += numReleasedBuffers;
} else {
numRequiredBuffers = 0;
}
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb4c607a5c4780729143d458b1c7633adcba59bf Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301)
* 0ed54d10e01403ccbe4478ad086d4859f6f511cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247)
* ae90bc7d6d3753da3e9bbadcc99c80a152801e43 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* edabda8971fb299b278a0bd0b42c2dca82c8a6a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424906972
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -313,7 +313,7 @@ int getNumberOfAvailableBuffers() {
}
}
- int unsynchronizedGetExclusiveBuffersUsed() {
+ int unsynchronizedGetExclusiveBuffers() {
Review comment:
unsynchronizedGetAvailableExclusiveBuffers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 929403a9ae1b734c4e72a4585862f994d8c1f5e9 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161611411) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128)
* ca6f75c37da358874cc38d7998bce5c4445feff5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735)
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae90bc7d6d3753da3e9bbadcc99c80a152801e43 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277)
* fb4c607a5c4780729143d458b1c7633adcba59bf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665394550
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
Something sounds wrong here. The race condition that you described above, does it mean that `unannouncedCredit` can be out of sync? That we in reality have released all floating buffers, channel is blocked, but actually `unannouncedCredit > 0`? And it's only fixed after calling `resumeConsumption()`?
And as I understand it, without your change, this problem doesn't exist, as floating buffers are kept assigned to the blocked channel and the `unannouncedCredit` (or maybe even assigned `AddCredit` that might have been sent to the upstream node) are consistent with the reality. Also those assigned floating buffers are not used because channel is blocked, but that is not a big issue, because thanks to the exclusive buffers, other channels can make a progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618265825
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 452ba169e20663de86d84ab6ea938bdf772be482 (Thu Apr 23 08:41:11 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r425072084
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -328,4 +325,67 @@ public void operationComplete(ChannelFuture future) throws Exception {
}
}
}
+
+ /**
+ * Outbound message to be sent to the client.
+ */
+ public static abstract class ServerOutboundMessage {
+ protected final InputChannelID receiverId;
+ protected final int backlog;
+ private final boolean moreAvailable;
+
+ ServerOutboundMessage(InputChannelID receiverId, int backlog, boolean moreAvailable) {
+ checkArgument(backlog >= 0, "Number of backlog must be non-negative.");
+ this.receiverId = checkNotNull(receiverId);
+ this.backlog = backlog;
+ this.moreAvailable = moreAvailable;
+ }
+
+ abstract Object build();
+
+ public boolean isMoreAvailable() {
+ return moreAvailable;
+ }
+
+ void recycleBufferIfNeeded() {
+ }
+ }
+
+ static class BufferResponseMessage extends ServerOutboundMessage {
+ private final Buffer buffer;
+ private final int sequenceNumber;
+
+ BufferResponseMessage(
+ Buffer buffer,
+ InputChannelID receiverId,
+ int sequenceNumber,
+ int backlog,
+ boolean moreAvailable) {
+ super(receiverId, backlog, moreAvailable);
+ this.buffer = checkNotNull(buffer);
+ this.sequenceNumber = sequenceNumber;
+ }
+
+ @Override
+ Object build() {
+ return new BufferResponse(buffer, sequenceNumber, receiverId, backlog);
+ }
+
+ @Override
+ void recycleBufferIfNeeded() {
+ buffer.recycleBuffer();
+ }
+ }
+
+ static class AddBacklogMessage extends ServerOutboundMessage {
+
+ AddBacklogMessage(InputChannelID receiverId, int backlog, boolean moreAvailable) {
Review comment:
remove `moreAvailable` argument from the constructor, because it seems strange for `AddBacklogMessage`, then we can give false in below `super` instead.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -94,10 +97,11 @@ void notifyReaderNonEmpty(final NetworkSequenceViewReader reader) {
* <p>NOTE: Only one thread would trigger the actual enqueue after checking the reader's
* availability, so there is no race condition here.
*/
- private void enqueueAvailableReader(final NetworkSequenceViewReader reader) throws Exception {
- if (reader.isRegisteredAsAvailable() || !reader.isAvailable()) {
+ void enqueueAvailableReader(final NetworkSequenceViewReader reader, BooleanSupplier condition) throws Exception {
Review comment:
Adjust the javadoc accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* edabda8971fb299b278a0bd0b42c2dca82c8a6a4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489)
* d8b233f483d45b8901cc28770be9da71a39929ef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8550965d808fe7b4d6ff2d48034612878937a579 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841)
* 7b6eb661923f59967a116e9074cf790fd694c578 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767)
* ae312385b57ca67cdb73ee96be38c4edbe56478d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774)
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662689103
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -215,9 +221,15 @@ public void recycle(MemorySegment segment) {
}
void releaseFloatingBuffers() {
+ Queue<Buffer> buffers;
synchronized (bufferQueue) {
numRequiredBuffers = 0;
- bufferQueue.releaseFloatingBuffers();
+ buffers = bufferQueue.clearFloatingBuffers();
+ }
+
+ // recycle all buffers out of the synchronization block to avoid dead lock
Review comment:
It is the new logic added by this PR causes the problem. RemoteInputChannel#onBlockingUpstream will call BufferManager#releaseFloatingBuffers in netty thread and different RemoteInputChannels can have different netty thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ed54d10e01403ccbe4478ad086d4859f6f511cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472)
* edabda8971fb299b278a0bd0b42c2dca82c8a6a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422864980
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
##########
@@ -158,11 +158,18 @@ public boolean add(BufferConsumer bufferConsumer) throws IOException {
private final Buffer buffer;
private final boolean isDataAvailable;
private final int buffersInBacklog;
+ private final int unannouncedBacklog;
Review comment:
`buffersInBacklog` and `unannouncedBacklog` should be retained only one finally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca6f75c37da358874cc38d7998bce5c4445feff5 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162162353) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5682e0256634e2ce1a38ca132cdaaddc79ee71c0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154)
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5682e0256634e2ce1a38ca132cdaaddc79ee71c0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154)
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665080164
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -433,8 +459,8 @@ public void operationComplete(ChannelFuture future) throws Exception {
@Override
public Object buildMessage() {
- return new AddCredit(
- inputChannel.getAndResetUnannouncedCredit(), inputChannel.getInputChannelId());
+ int credits = inputChannel.getAndResetUnannouncedCredit();
+ return credits > 0 ? new AddCredit(credits, inputChannel.getInputChannelId()) : null;
Review comment:
It is relevant to this PR, it is because we add the reset logic in ```RemoteInputChannel#resumeConsumption``` method.
```
if (initialCredit == 0) {
unannouncedCredit.set(0);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665084629
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -315,6 +326,17 @@ BufferAndBacklog pollBuffer() {
if (buffer.readableBytes() > 0) {
break;
}
+
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
I am afraid we can not skip the empty buffer is the exclusive credit is 0, because we may already allocate the floating credit for it and we can not just release the floating credit because we may already announce the credit to the upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
}, {
"hash" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208",
"triggerID" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"triggerType" : "PUSH"
}, {
"hash" : "da81fde5fc9e110075cff4982048b7f7ee3a0d61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da81fde5fc9e110075cff4982048b7f7ee3a0d61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4b35b61d395564b24dd98896b785e22c6e3ab30 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208)
* da81fde5fc9e110075cff4982048b7f7ee3a0d61 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-876895192
@pnowojski I have rebased the latest master branch and appended a fixup commit which fixes the comments and enables 0 exclusive credit for unaligned checkpoint itcase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
* 8550965d808fe7b4d6ff2d48034612878937a579 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841)
* 7b6eb661923f59967a116e9074cf790fd694c578 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661998885
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
After the changes, if the first buffer is finished and empty. The empty buffer will be sent to the downstream to release the allocated credit for it instead of recycled directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666302680
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -517,16 +520,16 @@ private void increaseBuffersInBacklog(BufferConsumer buffer) {
}
}
- /**
- * Gets the number of non-event buffers in this subpartition.
- *
- * <p><strong>Beware:</strong> This method should only be used in tests in non-concurrent access
- * scenarios since it does not make any concurrency guarantees.
- */
- @SuppressWarnings("FieldAccessNotGuarded")
- @VisibleForTesting
+ /** Gets the number of non-event buffers in this subpartition. */
+ @Override
public int getBuffersInBacklog() {
Review comment:
nit: Rename to `getBuffersInBacklogUnsafe()` (previously it was a private method just made `@VisibleForTesting`)
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
Ok, can you at least add a comment explaining why this is set to `0` here?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -312,6 +323,16 @@ BufferAndBacklog pollBuffer() {
decreaseBuffersInBacklogUnsafe(bufferConsumer.isBuffer());
}
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
I can not seem to respond in the previous thread, so I need to start a new one.
> Let's maybe focus on the 3rd case first and we assume that the exclusive credit is 0.
>
> 1. There are only one data buffer in the queue.
> 2. Flush triggered.
> 3. All data of the first buffer is committed but the buffer is still not finished.
> 4. All data of the buffer is consumed by pollBuffer and the available credit becomes 0.
> 5. The first buffer is finished, the second event is added and the data available notification is triggered.
> 6. The upstream announces backlog to the downstream to request a credit.
> 7. The upstream receives available credit and start to pollBuffer.
> 8. Skip the first empty buffer and send the second event.
> 9. The downstream receive the event but the event does not consume any credit.
>
> Do you mean we should change the current logic and release the floating buffer for event in some cases (including reduce the available credit by 1 at the upstream, currently the available credit is not decreased for event)?
No, but I think we could send this regardless if any is credit available or not as we are doing right now. I think we are also already attaching information about the backlog to such event. One thing to add (unless we are not doing it already) would be to use this backlog information, to maybe release floating buffers if backlog dropped to 0?
> If there are multiple empty buffers, should we just skip the first one or should we skip all?
We could skip all of them, until we reach one of the three options:
1. non empty data buffer
2. event (check above)
3. last empty buffer, without any events after it - here we would indeed need to send that empty buffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662011666
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -265,6 +265,13 @@ public void run() {
channelInfo,
channelStatePersister,
next.getSequenceNumber());
+
+ // ignore the empty buffer directly
+ if (buffer.readableBytes() == 0) {
+ buffer.recycleBuffer();
Review comment:
Before this change, the buffer is recycled in the pollBuffer method of Subpartition because no empty buffer is sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1814aee57851711782cc2d922c4ef8f118a74c13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665814336
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
> Something sounds wrong here. The race condition that you described above, does it mean that unannouncedCredit can be out of sync? That we in reality have released all floating buffers, channel is blocked, but actually unannouncedCredit > 0? And it's only fixed after calling resumeConsumption()?
Yes, exactly.
> And as I understand it, without your change, this problem doesn't exist, as floating buffers are kept assigned to the blocked channel and the unannouncedCredit (or maybe even assigned AddCredit that might have been sent to the upstream node) are consistent with the reality. Also those assigned floating buffers are not used because channel is blocked, but that is not a big issue, because thanks to the exclusive buffers, other channels can make a progress?
That only happens when the exclusive credit is 0. If the exclusive credit is not 0, the allocated floating buffers will not be released and if the exclusive credit is 0, we release the floating buffers allocated to let other channel use them to avoid deadlock, an extreme case is that we only have 1 floating buffer and no exclusive buffer. At downstream, the unannounced credit will be reset, at the upstream, the available credit is also reset to 0 when resume consumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267)
* 379905b396355d37f565230cbcbee323dc626dce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422889022
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -94,13 +99,27 @@ public void requestSubpartitionView(
}
@Override
- public void addCredit(int creditDeltas) {
+ public boolean addCredit(int creditDeltas) {
numCreditsAvailable += creditDeltas;
+ return shouldAnnounceBacklog();
+ }
+
+ @Override
+ public boolean shouldAnnounceBacklog() {
+ return initialCredit == 0 && numCreditsAvailable == 0 && subpartitionView.isAvailable(Integer.MAX_VALUE);
}
@Override
- public void resumeConsumption() {
+ public boolean resumeConsumption(int availableCredit, int unfulfilledBacklog) {
+ if (initialCredit > 0) {
+ checkState(numCreditsAvailable == availableCredit, "Illegal number of available credit.");
Review comment:
I guess this check is not necessary or invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c161aff32e5aed483ca0722e0504ec8493348947 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767)
* 159596e8f11586211a5f54e6aaae2c9fdee532a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735)
* a5c416aee052ec8ed5b4ad88d6b7707c3df9d061 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767)
* ae312385b57ca67cdb73ee96be38c4edbe56478d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66de3ded5740c19aab5984c8650b5d6a355ed6e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081)
* 9963994d6a37e8c1721d31519ac7346e25922248 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665394550
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
Something sounds wrong here. The race condition that you described above, does it mean that `unannouncedCredit` can be out of sync? That we in reality have released all floating buffers, channel is blocked, but actually `unannouncedCredit > 0`? And it's only fixed after calling `resumeConsumption()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b4b098f5eb40c7caf885c30b8c12aced99bbe05 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 379905b396355d37f565230cbcbee323dc626dce Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275)
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422847423
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -234,11 +236,16 @@ private void writeAndFlushNextMessageIfPossible(final Channel channel) throws IO
registerAvailableReader(reader);
}
- BufferResponse msg = new BufferResponse(
- next.buffer(),
- reader.getSequenceNumber(),
- reader.getReceiverId(),
- next.buffersInBacklog());
+ Object msg;
+ if (next.buffer() != null) {
Review comment:
The different message path is distinguished in both `PartitionRequestQueue` and `CreditBasedSequenceNumberingViewReader` now. We can improve it to judge only in one place instead.
1. Introduce `ServerOutboundMessage` class to extend `NettyMessage` and make `AddBacklog` and `BufferResponse` both extend `ServerOutboundMessage`.
2. Introduce `NetworkSequenceViewReader#getNextMessage` instead of existing `NetworkSequenceViewReader#getNextBuffer`. And inside `CreditBasedSequenceNumberingViewReader` implementation, we can judge the condition for distinguish.
```
public NettyMessage.ServerOutboundMessage getNextMessage() throws IOException {
if (numCreditsAvailable == 0 && initialCredit == 0 && !subpartitionView.isAvailable(numCreditsAvailable)) {
return getBacklogMessage();
} else {
return getNextBufferResponse();
}
}
```
To do so we can also reduce the necessary transformation between `BufferAndAvailability` and `BufferResponse`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665900515
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
`NetworkSequenceViewReader#isAvailable()` has the same problem of synchronisation costs.
> I think there is one thing blocking us from reusing the backlog from PartitionRequestQueue#notifyReaderNonEmpty(reader): we have duplicated availability notifications. We may get outdated backlog.
What is the problem? Keep in mind that spurious notifications shouldn't be that big of a problem. If we sometimes wake up too many times, and we rarely send incorrect backlog information that should be fine, as long as we always over estimate the backlog.
After all even in your version I think there can be a race condition where `PartitionRequestQueue` is notified reader is non empty, you check the `getRemainingBacklog()` and send the `BacklogAnnouncement` message, while before it gets processed by the receiver, some buffer is polled from this reader and backlog goes down to `0`. And as a result, receiver assigns as a credit to a sender that doesn't have any data anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665342075
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -315,6 +326,17 @@ BufferAndBacklog pollBuffer() {
if (buffer.readableBytes() > 0) {
break;
}
+
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
If there are two buffers, first is empty the second one can be:
1. non empty buffer
2. empty buffer
3. event
In all cases, instead of sending this first empty buffer with the backlog information, as far as I understand, it should be possible to just send any of the above instead with the updated backlog information. From the downstream node perspective, it should make no difference if we hide this empty buffer. If this is 2nd or 3rd case, we should be able to release the floating buffer regardless of that, shouldn't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
}, {
"hash" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20208",
"triggerID" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"triggerType" : "PUSH"
}, {
"hash" : "da81fde5fc9e110075cff4982048b7f7ee3a0d61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20264",
"triggerID" : "da81fde5fc9e110075cff4982048b7f7ee3a0d61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da81fde5fc9e110075cff4982048b7f7ee3a0d61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665012443
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
##########
@@ -164,6 +168,27 @@ void addCreditOrResumeConsumption(
}
}
+ /**
+ * Announces remaining backlog to the consumer after the available data notification or data
+ * consumption resumption.
+ */
+ private void announceBacklog(NetworkSequenceViewReader reader) {
+ int backlog = reader.getRemainingBacklog();
+ if (backlog > 0) {
Review comment:
You are right, we can do some optimization here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e033307ba22ee660cd6c39063896500075b60671 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238)
* 10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248)
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267)
* 379905b396355d37f565230cbcbee323dc626dce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661986812
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -340,7 +355,15 @@ private void decodeBufferOrEvent(
RemoteInputChannel inputChannel, NettyMessage.BufferResponse bufferOrEvent)
throws Throwable {
if (bufferOrEvent.isBuffer() && bufferOrEvent.bufferSize == 0) {
- inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ try {
+ inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ } finally {
+ // recycle the empty buffer directly
+ Buffer buffer = bufferOrEvent.getBuffer();
+ if (buffer != null) {
+ buffer.recycleBuffer();
Review comment:
It is not a bug. The empty buffer will not be sent to the downstream before. However, after this change, the empty buffer will be sent to the downstream task to release the credit already allocated for it. If we do not send the empty buffer to the downstream, the corresponding downstream channel will occupy more credits than needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-878379326
Thanks @wsry , merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-877001547
Thanks @wsry for all of the changes and your work with addressing the feedback. I think this looks almost good to me % a couple of renames and we need to update the config option descriptions to describe the actual state that there never can be 0 buffers per channel on the sender side. Currently the variable naming in the code and docs/description are misleading in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662239062
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -215,9 +221,15 @@ public void recycle(MemorySegment segment) {
}
void releaseFloatingBuffers() {
+ Queue<Buffer> buffers;
synchronized (bufferQueue) {
numRequiredBuffers = 0;
- bufferQueue.releaseFloatingBuffers();
+ buffers = bufferQueue.clearFloatingBuffers();
+ }
+
+ // recycle all buffers out of the synchronization block to avoid dead lock
Review comment:
As I understand from your explanation, it relates to this BufferManager#notifyBufferAvailable. But I still don't get which threads can call the releaseFloatingBuffers simultaneously. It is not so important, but just for curiosity if you have the stacktrace of this deadlock can you share it with me(or just tell me which test)?
Anyway, your changes look correct here.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
Ok, I think I understand it now. Please, tell me I indeed understand the scenario right:
- Suppose the buffers contain one unfinished Buffer.
- The flush was requested
- When pollBuffer() was called it collects all readable bytes from this unfinished buffer and getBuffersInBacklog returns 1(because `flushRequested` set to true)
- One more credit is requested from downstream because getBuffersInBacklog equal to 1.
- When pollBuffer() was called again it reads nothing because all data was read last time. But it already has one credit that should be released(it is exactly what you told about?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1814aee57851711782cc2d922c4ef8f118a74c13 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878)
* f28812c2d19b7109e851d4cce6cdb9df82868117 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
* 8550965d808fe7b4d6ff2d48034612878937a579 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661986812
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -340,7 +355,15 @@ private void decodeBufferOrEvent(
RemoteInputChannel inputChannel, NettyMessage.BufferResponse bufferOrEvent)
throws Throwable {
if (bufferOrEvent.isBuffer() && bufferOrEvent.bufferSize == 0) {
- inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ try {
+ inputChannel.onEmptyBuffer(bufferOrEvent.sequenceNumber, bufferOrEvent.backlog);
+ } finally {
+ // recycle the empty buffer directly
+ Buffer buffer = bufferOrEvent.getBuffer();
+ if (buffer != null) {
+ buffer.recycleBuffer();
Review comment:
It is not a bug. The empty buffer will not be sent to the downstream before. However, after this change, the empty buffer will be sent to the downstream task to release the credit already allocated for it. If we do not send the empty buffer to the downstream, the corresponding downstream channel will occupy more buffers than needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422970729
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -428,6 +423,23 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
It might be better to trigger this action by netty thread when received this barrier immediately. Otherwise the task processing might delay much time to better reuse the floating buffers for other channels.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422950710
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -99,7 +100,7 @@
/** The number of available buffers that have not been announced to the producer yet. */
private final AtomicInteger unannouncedCredit = new AtomicInteger(0);
- /** The number of required buffers that equals to sender's backlog plus initial credit. */
+ /** The number of buffers to requested that equals to unfulfilled sender's backlog. */
@GuardedBy("bufferQueue")
private int numRequiredBuffers;
Review comment:
nit: might rename to `numRequiredFloatingBuffers` for better reflecting the current semantic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8b233f483d45b8901cc28770be9da71a39929ef Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500)
* 3f89d29a4cee4917ff8087e16ab35c5d1274220c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 66de3ded5740c19aab5984c8650b5d6a355ed6e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [Flink-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r422466188
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -428,6 +423,23 @@ public void notifyBufferDestroyed() {
// Nothing to do actually.
}
+ @Override
+ public void onCheckpointBarrier(CheckpointBarrier barrier) {
Review comment:
Make the following condition out of `synchronized` part, then we do not need to touch the lock for most of the cases.
```
CheckpointOptions options = barrier.getCheckpointOptions();
if (!(initialCredit == 0 && options.isExactlyOnceMode() && !options.isUnalignedCheckpoint())) {
return;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248)
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794)
* 8550965d808fe7b4d6ff2d48034612878937a579 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r666677997
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -312,6 +323,16 @@ BufferAndBacklog pollBuffer() {
decreaseBuffersInBacklogUnsafe(bufferConsumer.isBuffer());
}
+ // if we have an empty finished buffer and the exclusive credit is 0, we just return
+ // the empty buffer so that the downstream task can release the allocated credit for
+ // this empty buffer, this happens in two main scenarios currently:
+ // 1. all data of a buffer builder has been read and after that the buffer builder
+ // is finished
+ // 2. in approximate recovery mode, a partial record takes a whole buffer builder
+ if (buffersPerChannel == 0 && bufferConsumer.isFinished()) {
+ break;
+ }
+
Review comment:
Yes, you are right. It wouldn't be that simple. In that case, how complicated would it be to optimise the code to skip the all of the empty buffers until:
1. non empty data buffer
2. event (then send empty buffer first)
3. last empty buffer, without any events after it - here we would indeed need to send that empty buffer
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-878195799
Hi @pnowojski , I have updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
}, {
"hash" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20047",
"triggerID" : "fb631b77700e2f05dcfdd50cd50cdea35e7cfb13",
"triggerType" : "PUSH"
}, {
"hash" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20084",
"triggerID" : "826c1aaddfc41d54a5b3f52be9feb73a0b193ebc",
"triggerType" : "PUSH"
}, {
"hash" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184",
"triggerID" : "01b2bc58b30a2a3730895f7c50ff59099bd273d2",
"triggerType" : "PUSH"
}, {
"hash" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4b35b61d395564b24dd98896b785e22c6e3ab30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 01b2bc58b30a2a3730895f7c50ff59099bd273d2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20184)
* d4b35b61d395564b24dd98896b785e22c6e3ab30 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
}, {
"hash" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19878",
"triggerID" : "1814aee57851711782cc2d922c4ef8f118a74c13",
"triggerType" : "PUSH"
}, {
"hash" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19893",
"triggerID" : "f28812c2d19b7109e851d4cce6cdb9df82868117",
"triggerType" : "PUSH"
}, {
"hash" : "048818bd8e4548d20febf9308b83e42146806b6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19898",
"triggerID" : "048818bd8e4548d20febf9308b83e42146806b6e",
"triggerType" : "PUSH"
}, {
"hash" : "109e1d36469b537f997a7c844e57e23729a1af21",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905",
"triggerID" : "109e1d36469b537f997a7c844e57e23729a1af21",
"triggerType" : "PUSH"
}, {
"hash" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955",
"triggerID" : "028f2185c0bb15c542006065550d04f69b0b06bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 109e1d36469b537f997a7c844e57e23729a1af21 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19905)
* 028f2185c0bb15c542006065550d04f69b0b06bd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19955)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r665814336
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -357,11 +359,26 @@ public void resumeConsumption() throws IOException {
checkState(!isReleased.get(), "Channel released.");
checkPartitionRequestQueueInitialized();
+ if (initialCredit == 0) {
+ unannouncedCredit.set(0);
Review comment:
>>> Something sounds wrong here. The race condition that you described above, does it mean that unannouncedCredit can be out of sync? That we in reality have released all floating buffers, channel is blocked, but actually unannouncedCredit > 0? And it's only fixed after calling resumeConsumption()?
Yes, exactly.
>>> And as I understand it, without your change, this problem doesn't exist, as floating buffers are kept assigned to the blocked channel and the unannouncedCredit (or maybe even assigned AddCredit that might have been sent to the upstream node) are consistent with the reality. Also those assigned floating buffers are not used because channel is blocked, but that is not a big issue, because thanks to the exclusive buffers, other channels can make a progress?
That only happens when the exclusive credit is 0. If the exclusive credit is not 0, the allocated floating buffers will not be released and if the exclusive credit is 0, we release the floating buffers allocated to let other channel use them to avoid deadlock, an extreme case is that we only have 1 floating buffer and no exclusive buffer. At downstream, the unannounced credit will be reset, at the upstream, the available credit is also reset to 0 when resume consumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r425117136
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -163,8 +172,15 @@ boolean hasBuffersAvailable() {
return subpartitionView.isAvailable(Integer.MAX_VALUE);
}
- @Override
- public BufferAndAvailability getNextBuffer() throws IOException {
+ private AddBacklogMessage getAddBacklogMessage() {
+ int backlog = subpartitionView.getAndResetUnannouncedBacklog();
+ if (backlog > 0) {
+ return new AddBacklogMessage(receiverId, backlog, false);
+ }
+ return null;
Review comment:
It can be null because of redundant data available notification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
}, {
"hash" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17767",
"triggerID" : "a5c416aee052ec8ed5b4ad88d6b7707c3df9d061",
"triggerType" : "PUSH"
}, {
"hash" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17774",
"triggerID" : "ae312385b57ca67cdb73ee96be38c4edbe56478d",
"triggerType" : "PUSH"
}, {
"hash" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17794",
"triggerID" : "4f4ce33b815167b23c8ee3dc8d65e1e97cc0cd07",
"triggerType" : "PUSH"
}, {
"hash" : "8550965d808fe7b4d6ff2d48034612878937a579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17841",
"triggerID" : "8550965d808fe7b4d6ff2d48034612878937a579",
"triggerType" : "PUSH"
}, {
"hash" : "7b6eb661923f59967a116e9074cf790fd694c578",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17863",
"triggerID" : "7b6eb661923f59967a116e9074cf790fd694c578",
"triggerType" : "PUSH"
}, {
"hash" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17885",
"triggerID" : "2c49d1a8cee6485e8f367190f152e58960c901ff",
"triggerType" : "PUSH"
}, {
"hash" : "c161aff32e5aed483ca0722e0504ec8493348947",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19767",
"triggerID" : "c161aff32e5aed483ca0722e0504ec8493348947",
"triggerType" : "PUSH"
}, {
"hash" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804",
"triggerID" : "159596e8f11586211a5f54e6aaae2c9fdee532a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 159596e8f11586211a5f54e6aaae2c9fdee532a2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19804)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87c4d9e67b205d7ca2fedf25a5a59402500de2ce Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623)
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ed54d10e01403ccbe4478ad086d4859f6f511cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14310",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
}, {
"hash" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15623",
"triggerID" : "87c4d9e67b205d7ca2fedf25a5a59402500de2ce",
"triggerType" : "PUSH"
}, {
"hash" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735",
"triggerID" : "86af5b748a70ba9bb997d654b6f76c0f3a343bc0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86af5b748a70ba9bb997d654b6f76c0f3a343bc0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r425078707
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -69,6 +73,7 @@
this.receiverId = receiverId;
this.numCreditsAvailable = initialCredit;
this.requestQueue = requestQueue;
+ this.withoutExclusiveCredits = initialCredit > 0;
Review comment:
initialCredit == 0;
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -69,6 +73,7 @@
this.receiverId = receiverId;
this.numCreditsAvailable = initialCredit;
this.requestQueue = requestQueue;
+ this.withoutExclusiveCredits = initialCredit > 0;
Review comment:
initialCredit == 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e033307ba22ee660cd6c39063896500075b60671 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238)
* 10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662841374
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -288,9 +288,7 @@ BufferAndBacklog pollBuffer() {
if (buffers.isEmpty()) {
flushRequested = false;
- }
-
- while (!buffers.isEmpty()) {
+ } else {
Review comment:
Yes, the batch execution mode still requires the manual calling of finish which brokes my idea. The same about PipelinedApproximateSubpartition. As I understand, it is impossible to know that a partial record will be sent or not before the request the credit.
So I still believe that it would be better to avoid sending the empty buffer if it is possible. But perhaps you right and it will be not so easy to do so in the current implementation, especially because of the scenarios which you described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
}, {
"hash" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307",
"triggerID" : "8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c",
"triggerType" : "PUSH"
}, {
"hash" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b4b098f5eb40c7caf885c30b8c12aced99bbe05",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 522dfaaf4295b903fa0c2d88e79db6d267086730 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14281)
* 8006bdc42eddf90eaaf8b1a426e3ee3c9b635e3c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14307)
* 4b4b098f5eb40c7caf885c30b8c12aced99bbe05 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r424860940
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -151,23 +150,43 @@ int requestFloatingBuffers(int numRequired) throws IOException {
return numRequestedBuffers;
}
- numRequiredBuffers = numRequired;
+ numRequiredBuffers += numRequired;
+ numRequestedBuffers = internalRequestFloatingBuffers(numRequiredBuffers);
+ numRequiredBuffers -= numRequestedBuffers;
+ }
+ return numRequestedBuffers;
+ }
- while (bufferQueue.getAvailableBufferSize() < numRequiredBuffers && !isWaitingForFloatingBuffers) {
- BufferPool bufferPool = inputChannel.inputGate.getBufferPool();
- Buffer buffer = bufferPool.requestBuffer();
- if (buffer != null) {
- bufferQueue.addFloatingBuffer(buffer);
- numRequestedBuffers++;
- } else if (bufferPool.addBufferListener(this)) {
- isWaitingForFloatingBuffers = true;
- break;
- }
+ private int internalRequestFloatingBuffers(int numBuffersToRequest) throws IOException {
+ assert Thread.holdsLock(bufferQueue);
+
+ int numRequestedBuffers = 0;
+ while (numRequestedBuffers < numBuffersToRequest && !isWaitingForFloatingBuffers) {
+ BufferPool bufferPool = inputChannel.inputGate.getBufferPool();
+ Buffer buffer = bufferPool.requestBuffer();
+ if (buffer != null) {
+ bufferQueue.addFloatingBuffer(buffer);
+ numRequestedBuffers++;
+ } else if (bufferPool.addBufferListener(this)) {
+ isWaitingForFloatingBuffers = true;
+ break;
}
}
return numRequestedBuffers;
}
+ public void unregisterBufferListenerAndReleaseFloatingBuffers() {
+ synchronized (bufferQueue) {
+ if (isWaitingForFloatingBuffers) {
+ inputChannel.inputGate.getBufferPool().removeBufferListener(this);
+ isWaitingForFloatingBuffers = false;
+ }
+
+ int bufferReleased = bufferQueue.releaseFloatingBuffers();
Review comment:
nit: numReleasedBuffers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11877: [FLINK-16641][network] Announce sender's backlog to solve the deadlock issue without exclusive buffers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11877:
URL: https://github.com/apache/flink/pull/11877#issuecomment-618273998
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161590525",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "452ba169e20663de86d84ab6ea938bdf772be482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=115",
"triggerID" : "452ba169e20663de86d84ab6ea938bdf772be482",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=128",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161611411",
"triggerID" : "929403a9ae1b734c4e72a4585862f994d8c1f5e9",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=290",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162162353",
"triggerID" : "ca6f75c37da358874cc38d7998bce5c4445feff5",
"triggerType" : "PUSH"
}, {
"hash" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1087",
"triggerID" : "3046802f6bfcf476af447fffbc9af3f20a96ed61",
"triggerType" : "PUSH"
}, {
"hash" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1140",
"triggerID" : "708b2ceb97564084900c555d6f38e6ba1174d735",
"triggerType" : "PUSH"
}, {
"hash" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1168",
"triggerID" : "59b651c070adcca2b7e4e4a78e6b10411429c589",
"triggerType" : "PUSH"
}, {
"hash" : "e033307ba22ee660cd6c39063896500075b60671",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1238",
"triggerID" : "e033307ba22ee660cd6c39063896500075b60671",
"triggerType" : "PUSH"
}, {
"hash" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1247",
"triggerID" : "10deae9993244cb215af6f0bb3bd6a9b0f9ef9fd",
"triggerType" : "PUSH"
}, {
"hash" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1277",
"triggerID" : "ae90bc7d6d3753da3e9bbadcc99c80a152801e43",
"triggerType" : "PUSH"
}, {
"hash" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1301",
"triggerID" : "fb4c607a5c4780729143d458b1c7633adcba59bf",
"triggerType" : "PUSH"
}, {
"hash" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1472",
"triggerID" : "0ed54d10e01403ccbe4478ad086d4859f6f511cf",
"triggerType" : "PUSH"
}, {
"hash" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1489",
"triggerID" : "edabda8971fb299b278a0bd0b42c2dca82c8a6a4",
"triggerType" : "PUSH"
}, {
"hash" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1500",
"triggerID" : "d8b233f483d45b8901cc28770be9da71a39929ef",
"triggerType" : "PUSH"
}, {
"hash" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1674",
"triggerID" : "3f89d29a4cee4917ff8087e16ab35c5d1274220c",
"triggerType" : "PUSH"
}, {
"hash" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4077",
"triggerID" : "7dfdb8bfa05b783479697bd3aa3de3fac2628482",
"triggerType" : "PUSH"
}, {
"hash" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4081",
"triggerID" : "66de3ded5740c19aab5984c8650b5d6a355ed6e8",
"triggerType" : "PUSH"
}, {
"hash" : "9963994d6a37e8c1721d31519ac7346e25922248",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4147",
"triggerID" : "9963994d6a37e8c1721d31519ac7346e25922248",
"triggerType" : "PUSH"
}, {
"hash" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4154",
"triggerID" : "5682e0256634e2ce1a38ca132cdaaddc79ee71c0",
"triggerType" : "PUSH"
}, {
"hash" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14248",
"triggerID" : "1440a6f1d30fc6cb7f4107facb3f9a5d08f34e87",
"triggerType" : "PUSH"
}, {
"hash" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267",
"triggerID" : "57cd88378e64e7c534d592d4538b2aa8222a2b00",
"triggerType" : "PUSH"
}, {
"hash" : "379905b396355d37f565230cbcbee323dc626dce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275",
"triggerID" : "379905b396355d37f565230cbcbee323dc626dce",
"triggerType" : "PUSH"
}, {
"hash" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "522dfaaf4295b903fa0c2d88e79db6d267086730",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57cd88378e64e7c534d592d4538b2aa8222a2b00 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14267)
* 379905b396355d37f565230cbcbee323dc626dce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14275)
* 522dfaaf4295b903fa0c2d88e79db6d267086730 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org