You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 01:06:52 UTC
[GitHub] [airflow] flavio-assis opened a new pull request #13173: Move logging properties on values.yaml
flavio-assis opened a new pull request #13173:
URL: https://github.com/apache/airflow/pull/13173
Since `remote_logging` and `logging_level` was under `core` section on config, it was throwing deprecation messages on the Pods logs. I moved it into the `logging` section
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#discussion_r546257063
##########
File path: chart/values.yaml
##########
@@ -644,13 +644,13 @@ config:
core:
dags_folder: '{{ include "airflow_dags" . }}'
load_examples: 'False'
- colored_console_log: 'False'
executor: '{{ .Values.executor }}'
- remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
# Authentication backend used for the experimental API
api:
auth_backend: airflow.api.auth.backend.deny_all
logging:
+ remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
Review comment:
Where possible, we try to maintain compatibility with Airflow 1.10 and 2.0 at the same time. I think we need to duplicate these keys. See: https://github.com/apache/airflow/blob/833c53b6a4ebd580c0e5daf75215d38e875d5ddd/chart/values.yaml#L668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] flavio-assis commented on pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
flavio-assis commented on pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#issuecomment-748405954
In addition t[o the PR that adds a new default Airflow Version in chart](https://github.com/apache/airflow/pull/13125), I think we should adjust the default `{{ .Values.config }}` to match this version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#issuecomment-748548271
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#issuecomment-748397697
[The Workflow run](https://github.com/apache/airflow/actions/runs/431694483) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] flavio-assis commented on a change in pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
flavio-assis commented on a change in pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#discussion_r546267774
##########
File path: chart/values.yaml
##########
@@ -644,13 +644,13 @@ config:
core:
dags_folder: '{{ include "airflow_dags" . }}'
load_examples: 'False'
- colored_console_log: 'False'
executor: '{{ .Values.executor }}'
- remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
# Authentication backend used for the experimental API
api:
auth_backend: airflow.api.auth.backend.deny_all
logging:
+ remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13173:
URL: https://github.com/apache/airflow/pull/13173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#issuecomment-748394778
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#discussion_r546257063
##########
File path: chart/values.yaml
##########
@@ -644,13 +644,13 @@ config:
core:
dags_folder: '{{ include "airflow_dags" . }}'
load_examples: 'False'
- colored_console_log: 'False'
executor: '{{ .Values.executor }}'
- remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
# Authentication backend used for the experimental API
api:
auth_backend: airflow.api.auth.backend.deny_all
logging:
+ remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled }}'
Review comment:
Where possible, we try to be compatible with Airflow 1.10 and 2.0 at the same time. I think we need to duplicate these keys. See: https://github.com/apache/airflow/blob/833c53b6a4ebd580c0e5daf75215d38e875d5ddd/chart/values.yaml#L668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#issuecomment-748495809
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13173: Move logging properties on values.yaml
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13173:
URL: https://github.com/apache/airflow/pull/13173#issuecomment-748548413
Thanks for fixing it. Less noise in the log is always helpful.
Would you be willing to deal with one more related ticket? This would allow others to better understand this change.
https://github.com/apache/airflow/issues/12772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org