You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/03/09 19:44:10 UTC

Review Request 44586: SQOOP-2883: Sqoop2: Update model classes to represent new constant for connector resource bundles

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44586/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2883
    https://issues.apache.org/jira/browse/SQOOP-2883


Repository: sqoop-sqoop2


Description
-------

As part of the parent umbrella JIRA, I've made few changes to the resource bundles that connectors are providing:

# Added a new key for example that we should add to [{{MNamedElement}}|https://github.com/apache/sqoop/blob/sqoop2/common/src/main/java/org/apache/sqoop/model/MNamedElement.java]
# Added a new key {{connector.name}} with human readable connector name. The constant should be referred somewhere in the code.


Diffs
-----

  common/src/main/java/org/apache/sqoop/model/MNamedElement.java 2e4dab3 
  common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java 8556302 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 6733906 

Diff: https://reviews.apache.org/r/44586/diff/


Testing
-------


Thanks,

Jarek Cecho