[GitHub] [pulsar] eolivelli commented on a change in pull request #9598: Make `LocalPolicies` immutable to avoid concurrent modify inconsistent.

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9598:
URL: https://github.com/apache/pulsar/pull/9598#discussion_r583443688



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/LocalPolicies.java
##########
@@ -19,37 +19,34 @@
 package org.apache.pulsar.common.policies.data;
 
 import static org.apache.pulsar.common.policies.data.Policies.defaultBundle;
-import com.google.common.base.Objects;
+import lombok.EqualsAndHashCode;
+import lombok.ToString;
 
 /**
  * Local policies.
  */
+@ToString
+@EqualsAndHashCode
 public class LocalPolicies {

Review comment:
       can this change impact compatibility with existing clusters ?
   
   Jackson Mapper uses Java reflection
   How do we guarantee that the JSON code of this version is compatible with the one of the previous version ?
   
   Can we add tests that try to deserialise a JSON produced with the old version ? or do we already have some ?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org