You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/02/08 06:25:04 UTC
[GitHub] carbondata pull request #1951: [CARBONDATA-1763] Dropped table if exception ...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1951
[CARBONDATA-1763] Dropped table if exception thrown while creation
Preaggregate table is not getting dropped when creation fails because
1. Exceptions from undo metadata is not handled
2. If preaggregate table is not registered with main table(main table updation fails) then it is not dropped from metastore.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata drop_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1951.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1951
----
commit d9628fc31c02dce51dabb8a329626f489b431358
Author: kunal642 <ku...@...>
Date: 2018-02-08T06:20:23Z
dropped table if exception thrown while creation
----
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3431/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3460/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2376/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2345/
---
[GitHub] carbondata pull request #1951: [CARBONDATA-1763] Dropped table if exception ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1951#discussion_r166845879
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/package.scala ---
@@ -87,8 +87,8 @@ abstract class AtomicRunnableCommand
extends RunnableCommand with MetadataProcessOpeation with DataProcessOperation {
override def run(sparkSession: SparkSession): Seq[Row] = {
- processMetadata(sparkSession)
--- End diff --
This change may impact other commands. Better don't include in try block. Let the individual command handle it.
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2343/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1951
@ravipesala Build success
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2336/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3442/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3433/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3618/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1951
@ravipesala done
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3583/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2378/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3461/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3424/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3615/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
@kunal642 Please rebase
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3581/
---
[GitHub] carbondata pull request #1951: [CARBONDATA-1763] Dropped table if exception ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1951
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3617/
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1951
retest sdv please
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1951
LGTM
---
[GitHub] carbondata issue #1951: [CARBONDATA-1763] Dropped table if exception thrown ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1951
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3574/
---