You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2018/01/24 02:58:29 UTC

[GitHub] nifi pull request #2162: NIFI-1706 Extend QueryDatabaseTable to support arbi...

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2162#discussion_r163441205
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java ---
    @@ -366,10 +401,22 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory
     
         protected String getQuery(DatabaseAdapter dbAdapter, String tableName, String columnNames, List<String> maxValColumnNames,
                                   String customWhereClause, Map<String, String> stateMap) {
    +
    +        return getQuery(dbAdapter, tableName, "", columnNames, maxValColumnNames, customWhereClause, stateMap);
    --- End diff --
    
    `null` may be preferable over the empty string object for `sqlQuery`.


---