You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/03 07:51:32 UTC
[GitHub] [airflow] sharingan-no-kakashi opened a new issue #16790: Support manual task annotation.
sharingan-no-kakashi opened a new issue #16790:
URL: https://github.com/apache/airflow/issues/16790
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
**Description**
I have been an airflow user for since a long time and I have often asked myself "what did happen to this task 4 months ago?".
Usually, this question starts a long and tedious process of going through slack/github/jira/emails to understand what was the problem.
Wouldn't be nice having a small airflow component where users can insert notes about tasks?
**What do you want to happen?**
The idea is to have a "task note" which is related to a task instance. We would have a new table: task_notes which has 5 columns dag_id, task_id, execution_date, task_notes, timestamp, (potentially others such a user etc)
We would have a new view similar to the xcom (second screenshot) and we modify the task instance view and model to refer to this task note view (first screenshot).
Users would be able to insert notes from this view.
In my current implementation, it looks something similar to this.
(external links to screenshots)
[https://ibb.co/vQPGQmb](url)
[https://ibb.co/wRxbtF9](url)
-->
**Are you willing to submit a PR?**
Yes. I have been working on this for fun as a POC.
**Related Issues**
<!-- Is there currently another issue associated with this? -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey edited a comment on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
Acehaidrey edited a comment on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-997109040
@sharingan-no-kakashi can you let me know are you planning to get this PR in? that would be great for us.
Sorry I see it was not implemented in. It was closed. Any way to get you to consider merging it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharingan-no-kakashi commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
sharingan-no-kakashi commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-877094534
> See also #12199 which asks for a new state -- So that you can "acknowledge" the failure without marking it as success.
They are indeed very similar. Has it already been brainstormed/implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
Jorricks commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-873413890
+1 seems like a valuable contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-875532566
See also https://github.com/apache/airflow/issues/12199 which asks for a new state -- So that you can "acknowledge" the failure without marking it as success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-997109040
@sharingan-no-kakashi can you let me know are you planning to get this PR in? that would be great for us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharingan-no-kakashi commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
sharingan-no-kakashi commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-997188745
Hi @Acehaidrey I have a relatively free weekend! I can rebase the work of this PR and the other one into 1 with the minimal POC and I or someone else(and feel free to continue this work if you fancy) can improve it/finish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-879612265
1. Not sure if I understand the question correctly. For a new (web) view, you should add a file in `tests/www/views` to test it. Other files in the same directory should provide some hints how the tests can be configured/implemented.
2. Yes, a draft PR would be best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharingan-no-kakashi commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
sharingan-no-kakashi commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-877085836
Hi, @potiuk I think I am almost done with my base implementation, but before opening a PR (I have read the CONTRIBUTION and PULL_REQUEST instructions) I would like to ask a few questions 😄.
1. I cannot find in the codebase similar unit tests to be added when a view (and a new template) is added here `airflow/www/views.py`. (In my case the new view would be Task Note with a get and a post operation)
Would you be able to point me to something similar in the codebase/github?
2. In case I would like to collect feedback for my work that is not 100% completed (missing tests), can I open a PR nevertheless, maybe in DRAFT or is there any specific guideline for this?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-873364900
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
Acehaidrey commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-995065028
Hi all can you provide a status for this PR. What do we think, can we work to allow this to record notes during actions? Is that still the goal here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Acehaidrey edited a comment on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
Acehaidrey edited a comment on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-997109040
@sharingan-no-kakashi can you let me know are you planning to get this PR in? that would be great for us.
Sorry I see the PR get in: https://github.com/apache/airflow/pull/16953. Then is this issue resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-873367867
Nice. I think It's a nice addition. Go ahead with the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sharingan-no-kakashi commented on issue #16790: Support manual task annotation.
Posted by GitBox <gi...@apache.org>.
sharingan-no-kakashi commented on issue #16790:
URL: https://github.com/apache/airflow/issues/16790#issuecomment-873545564
Ok! I am going to work on this! Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org