You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "damik3 (via GitHub)" <gi...@apache.org> on 2024/04/19 15:25:42 UTC
[PR] Multicontext features [incubator-wayang]
damik3 opened a new pull request, #429:
URL: https://github.com/apache/incubator-wayang/pull/429
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "kbeedkar (via GitHub)" <gi...@apache.org>.
kbeedkar commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2074562288
Yes, WayangMulticontext, or simply multicontext is also fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "damik3 (via GitHub)" <gi...@apache.org>.
damik3 commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2072636165
Yes, the error changed, now it's
```
org.apache.wayang.core.api.exception.WayangException: Executing T[JavaCollect[convert out@JavaMap[1->1, id=17a8194f]]] failed.
at org.apache.wayang.tests.TensorflowIrisIT.test(TensorflowIrisIT.java:153)
Caused by: java.lang.IllegalArgumentException: Comparison method violates its general contract!
at org.apache.wayang.tests.TensorflowIrisIT.test(TensorflowIrisIT.java:153)
```
I'm not sure why the `TensorflowIrisIT` test would break. I didn't make any relevant changes. Does the test have any degree of unpredictability in it? I ran it a few times locally, and at first it failed but then without changing anything, it would pass.
I did a new commit with some irrelevant cleanup, maybe we should try the checks again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2076575593
Thanks a lot Michalis :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "damik3 (via GitHub)" <gi...@apache.org>.
damik3 commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2070677873
Did a tweak, I think its working now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2067950584
The online checks give this error:
Error: Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.8.1:testCompile (compile-scala) on project wayang-api-scala-java: Execution compile-scala of goal net.alchim31.maven:scala-maven-plugin:4.8.1:testCompile failed: Compilation failed: InterfaceCompileFailed -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn <args> -rf :wayang-api-scala-java
Error: Process completed with exit code 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi merged PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2074745268
Yes, let's keep it simple: MultiContext. @damik3 could you please make the corresponding changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "damik3 (via GitHub)" <gi...@apache.org>.
damik3 commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2077712773
My pleasure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2071597595
Got this error now:
Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project wayang-tests-integration: There are test failures.
Error:
Error: Please refer to /home/runner/work/incubator-wayang/incubator-wayang/wayang-tests-integration/target/surefire-reports for the individual test results.
Error: Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn <args> -rf :wayang-tests-integration
Error: Process completed with exit code 1.
Any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "damik3 (via GitHub)" <gi...@apache.org>.
damik3 commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2074542004
@zkaoudi Yes `BlossomContext` extends `WayangContext`, so they can't have the same name, we have to choose something different. Maybe something like `MultiWayangContext` or `MultiCapableWayangContext` because the thing is that `BlossomContext` still is only one context, but it is the class that should be used for multi context operations instead of the original wayangcontext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2074559245
How about WayangMultiContext? Anyone else preferences or ideas? @kbeedkar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "zkaoudi (via GitHub)" <gi...@apache.org>.
zkaoudi commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2074236032
Great! It worked now. But before merging one more thing. Can we rename the BlossomContext to WayangContext? Does it contain more things than the WayangContext?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Multicontext features [incubator-wayang]
Posted by "damik3 (via GitHub)" <gi...@apache.org>.
damik3 commented on PR #429:
URL: https://github.com/apache/incubator-wayang/pull/429#issuecomment-2074905428
Just made the changes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org