You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 07:53:02 UTC
[GitHub] [airflow] Khrol opened a new pull request #14187: Use apache.spark provider without kubernetes
Khrol opened a new pull request #14187:
URL: https://github.com/apache/airflow/pull/14187
Steps to reproduce the problem:
1. `pip install "apache-airflow[apache.spark]"`
2. Run the following:
```
>>> from airflow.providers.apache.spark.hooks.spark_submit import SparkSubmitHook
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/khroliz/.local/share/virtualenvs/airflow_2_0_1_spark-2XiasV-V/lib/python3.8/site-packages/airflow/providers/apache/spark/hooks/spark_submit.py", line 32, in <module>
from airflow.kubernetes import kube_client
File "/Users/khroliz/.local/share/virtualenvs/airflow_2_0_1_spark-2XiasV-V/lib/python3.8/site-packages/airflow/kubernetes/kube_client.py", line 101, in <module>
) -> client.CoreV1Api:
NameError: name 'client' is not defined
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Khrol commented on pull request #14187: Use apache.spark provider without kubernetes
Posted by GitBox <gi...@apache.org>.
Khrol commented on pull request #14187:
URL: https://github.com/apache/airflow/pull/14187#issuecomment-777718760
@tooptoop4 I don't think so. That places are started with `from kubernetes...` which is throwing `ImportError` right away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14187: Use apache.spark provider without kubernetes
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14187:
URL: https://github.com/apache/airflow/pull/14187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tooptoop4 commented on pull request #14187: Use apache.spark provider without kubernetes
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on pull request #14187:
URL: https://github.com/apache/airflow/pull/14187#issuecomment-777716416
@Khrol is same fix needed at https://github.com/apache/airflow/blob/master/airflow/models/taskinstance.py#L82 and https://github.com/apache/airflow/blob/master/airflow/serialization/serialized_objects.py#L57 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14187: Use apache.spark provider without kubernetes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14187:
URL: https://github.com/apache/airflow/pull/14187#issuecomment-777277597
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org