You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2009/05/13 22:44:45 UTC
[jira] Created: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Fix javac warnings in several dfs tests related to unncessary casts
-------------------------------------------------------------------
Key: HADOOP-5822
URL: https://issues.apache.org/jira/browse/HADOOP-5822
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Jakob Homan
Assignee: Jakob Homan
There are quite a few unnecessary casts as reported in javac in the following files:
/src/test/OAH/hdfs/TestDataTransferProtocol.java
/src/test/OAH/hdfs/TestFSInputChecker.java
/src/test/OAH/hdfs/TestFileAppend.java
/src/test/OAH/hdfs/TestPread.java
/src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5822:
--------------------------------
Attachment: HADOOP-5822.patch
Patch fixes all the javac warnings in the files listed above. All are unnecessary cast warnings. Also cleaned up some imports, dead code and formatting.
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709639#action_12709639 ]
Jakob Homan commented on HADOOP-5822:
-------------------------------------
Hudson seems to be messed up at the moment, I can't see the test results, but I'm sure there no issues with the contrib tests. There are no functional changes to the code from this patch.
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5822:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709632#action_12709632 ]
Hadoop QA commented on HADOOP-5822:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408070/HADOOP-5822.patch
against trunk revision 774859.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/340/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/340/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/340/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/340/console
This message is automatically generated.
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5822:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Jakob!
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5822:
-------------------------------------------
Component/s: (was: dfs)
test
Fix Version/s: 0.21.0
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709644#action_12709644 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5822:
------------------------------------------------
> Hudson seems to be messed up at the moment, I can't see the test results, but I'm sure there no issues with the contrib tests. There are no functional changes to the code from this patch.
The patch only changed some hdfs unit tests. The failed contrib tests are definitely unrelated. BTW, some contrib tests already have a long history of failing (e.g. some have age 5 in [build #337|http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/testReport/]). Hope that they will be fixed soon.
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5822) Fix javac warnings in several dfs
tests related to unncessary casts
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5822:
--------------------------------
Status: Patch Available (was: Open)
submitting patch
> Fix javac warnings in several dfs tests related to unncessary casts
> -------------------------------------------------------------------
>
> Key: HADOOP-5822
> URL: https://issues.apache.org/jira/browse/HADOOP-5822
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HADOOP-5822.patch
>
>
> There are quite a few unnecessary casts as reported in javac in the following files:
> /src/test/OAH/hdfs/TestDataTransferProtocol.java
> /src/test/OAH/hdfs/TestFSInputChecker.java
> /src/test/OAH/hdfs/TestFileAppend.java
> /src/test/OAH/hdfs/TestPread.java
> /src/test/OAH/hdfs/server/namenode/TestNodeCount.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.