[jira] [Commented] (ZOOKEEPER-2507) C unit test improvement: line break between 'ZooKeeper server started' and 'Running'

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412452#comment-15412452 ] 

Hadoop QA commented on ZOOKEEPER-2507:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12822651/ZOOKEEPER-2507.patch
  against trunk revision 1755379.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3335//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3335//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3335//console

This message is automatically generated.

> C unit test improvement: line break between 'ZooKeeper server started' and 'Running'
> ------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2507
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2507
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 3.4.8, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>            Priority: Minor
>             Fix For: 3.5.3, 3.4.10
>
>         Attachments: ZOOKEEPER-2507.patch
>
>
> Currently we have this on C unit test output:
> {noformat}
> ZooKeeper server startedRunning
> ......
> OK
> {noformat}
> This is because the zkServer.sh, when eco 'ZooKeeper server started', does not put a line break at the end. It will be clearer for readers of the console output if we fix this by adding a line break in between, so we can separate the script output and the test output. After the fix the output would look like:
> {noformat}
> ZooKeeper server started
> Running
> .....
> OK
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)